feat: don't allow without timezone

This commit is contained in:
Shivam Mishra
2026-03-05 14:34:03 +05:30
parent ea5a46ee0c
commit dfd92acd4a
2 changed files with 5 additions and 5 deletions
@@ -45,7 +45,7 @@ module V2::Reports::Concerns::RollupConditions
end
def timezone_matches_account?
return true if params[:timezone_offset].blank?
return false if params[:timezone_offset].blank?
offset_in_seconds = params[:timezone_offset].to_f * 3600
account_zone = ActiveSupport::TimeZone[account.reporting_timezone]
@@ -190,10 +190,10 @@ describe V2::Reports::Concerns::RollupConditions do
expect(builder.use_rollup?).to be true
end
it 'returns true when timezone_offset is blank (defaults to account timezone)' do
it 'returns false when timezone_offset is blank' do
builder.params = valid_params.merge(timezone_offset: nil)
expect(builder.use_rollup?).to be true
expect(builder.use_rollup?).to be false
end
end
@@ -284,9 +284,9 @@ describe V2::Reports::Concerns::RollupConditions do
end
describe '#timezone_matches_account?' do
it 'returns true when timezone_offset is blank' do
it 'returns false when timezone_offset is blank' do
builder.params = { timezone_offset: nil }
expect(builder.timezone_matches_account?).to be true
expect(builder.timezone_matches_account?).to be false
end
it 'returns true when offset matches account timezone current offset' do