diff --git a/app/builders/v2/reports/concerns/rollup_conditions.rb b/app/builders/v2/reports/concerns/rollup_conditions.rb index 9300e8c5c..0cda631e4 100644 --- a/app/builders/v2/reports/concerns/rollup_conditions.rb +++ b/app/builders/v2/reports/concerns/rollup_conditions.rb @@ -45,7 +45,7 @@ module V2::Reports::Concerns::RollupConditions end def timezone_matches_account? - return true if params[:timezone_offset].blank? + return false if params[:timezone_offset].blank? offset_in_seconds = params[:timezone_offset].to_f * 3600 account_zone = ActiveSupport::TimeZone[account.reporting_timezone] diff --git a/spec/builders/v2/reports/concerns/rollup_conditions_spec.rb b/spec/builders/v2/reports/concerns/rollup_conditions_spec.rb index e9dc7911a..b13ea2e5f 100644 --- a/spec/builders/v2/reports/concerns/rollup_conditions_spec.rb +++ b/spec/builders/v2/reports/concerns/rollup_conditions_spec.rb @@ -190,10 +190,10 @@ describe V2::Reports::Concerns::RollupConditions do expect(builder.use_rollup?).to be true end - it 'returns true when timezone_offset is blank (defaults to account timezone)' do + it 'returns false when timezone_offset is blank' do builder.params = valid_params.merge(timezone_offset: nil) - expect(builder.use_rollup?).to be true + expect(builder.use_rollup?).to be false end end @@ -284,9 +284,9 @@ describe V2::Reports::Concerns::RollupConditions do end describe '#timezone_matches_account?' do - it 'returns true when timezone_offset is blank' do + it 'returns false when timezone_offset is blank' do builder.params = { timezone_offset: nil } - expect(builder.timezone_matches_account?).to be true + expect(builder.timezone_matches_account?).to be false end it 'returns true when offset matches account timezone current offset' do