Fix RuboCop spec offenses

This commit is contained in:
Sojan Jose
2026-01-16 00:26:21 -08:00
parent 45533f6bf8
commit 251ef4f8bb
12 changed files with 12 additions and 14 deletions
-2
View File
@@ -1,8 +1,6 @@
require 'rails_helper'
# rubocop:disable RSpec/DescribeClass
describe 'Markdown Embeds Configuration' do
# rubocop:enable RSpec/DescribeClass
let(:config) { YAML.load_file(Rails.root.join('config/markdown_embeds.yml')) }
describe 'YAML structure' do
@@ -1,6 +1,6 @@
require 'rails_helper'
RSpec.describe DeviseOverrides::SessionsController, type: :controller do
RSpec.describe DeviseOverrides::SessionsController do
include Devise::Test::ControllerHelpers
before do
+1 -1
View File
@@ -1,6 +1,6 @@
require 'rails_helper'
RSpec.describe ReportingEventHelper, type: :helper do
RSpec.describe ReportingEventHelper do
describe '#last_non_human_activity' do
let(:account) { create(:account) }
let(:inbox) { create(:inbox, account: account) }
@@ -1,6 +1,6 @@
require 'rails_helper'
RSpec.describe AutoAssignment::AssignmentJob, type: :job do
RSpec.describe AutoAssignment::AssignmentJob do
let(:account) { create(:account) }
let(:inbox) { create(:inbox, account: account, enable_auto_assignment: true) }
let(:agent) { create(:user, account: account, role: :agent, availability: :online) }
@@ -1,6 +1,6 @@
require 'rails_helper'
RSpec.describe AutoAssignment::PeriodicAssignmentJob, type: :job do
RSpec.describe AutoAssignment::PeriodicAssignmentJob do
let(:account) { create(:account) }
let(:inbox) { create(:inbox, account: account, enable_auto_assignment: true) }
let(:assignment_policy) { create(:assignment_policy, account: account) }
+1 -1
View File
@@ -1,6 +1,6 @@
require 'rails_helper'
RSpec.describe Contacts::BulkActionJob, type: :job do
RSpec.describe Contacts::BulkActionJob do
let(:account) { create(:account) }
let(:user) { create(:user, account: account) }
let(:params) { { 'ids' => [1], 'labels' => { 'add' => ['vip'] } } }
@@ -1,6 +1,6 @@
require 'rails_helper'
RSpec.describe ConversationReplyEmailJob, type: :job do
RSpec.describe ConversationReplyEmailJob do
let(:conversation) { create(:conversation) }
let(:mailer) { double }
let(:mailer_action) { double }
+1 -1
View File
@@ -1,6 +1,6 @@
require 'rails_helper'
RSpec.describe DeleteObjectJob, type: :job do
RSpec.describe DeleteObjectJob do
describe '#perform' do
context 'when object is heavy (Inbox)' do
let!(:account) { create(:account) }
+2 -2
View File
@@ -143,13 +143,13 @@ RSpec.describe Account do
context 'when auto_resolve_after' do
it 'validates minimum value' do
account.settings = { auto_resolve_after: 4 }
expect(account).to be_invalid
expect(account).not_to be_valid
expect(account.errors.messages).to eq({ auto_resolve_after: ['must be greater than or equal to 10'] })
end
it 'validates maximum value' do
account.settings = { auto_resolve_after: 1_439_857 }
expect(account).to be_invalid
expect(account).not_to be_valid
expect(account.errors.messages).to eq({ auto_resolve_after: ['must be less than or equal to 1439856'] })
end
@@ -1,6 +1,6 @@
require 'rails_helper'
RSpec.describe 'Conversation Audit', type: :model do
RSpec.describe 'Conversation Audit' do
let(:account) { create(:account) }
let(:conversation) { create(:conversation, account: account) }
@@ -1,6 +1,6 @@
require 'rails_helper'
RSpec.describe 'Api::V1::Accounts::BaseController', type: :request do
RSpec.describe 'Api::V1::Accounts::BaseController' do
let(:account) { create(:account) }
let(:inbox) { create(:inbox, account: account) }
let!(:conversation) { create(:conversation, account: account, inbox: inbox) }
@@ -1,6 +1,6 @@
require 'rails_helper'
RSpec.describe 'MFA API', type: :request do
RSpec.describe 'MFA API' do
before do
skip('Skipping since MFA is not configured in this environment') unless Chatwoot.encryption_configured?
allow(Chatwoot).to receive(:mfa_enabled?).and_return(true)