From 251ef4f8bb1dd768f6518f5782f6126337f597a6 Mon Sep 17 00:00:00 2001 From: Sojan Jose Date: Fri, 16 Jan 2026 00:26:21 -0800 Subject: [PATCH] Fix RuboCop spec offenses --- spec/config/markdown_embeds_spec.rb | 2 -- spec/controllers/devise_overrides/sessions_controller_spec.rb | 2 +- spec/helpers/reporting_event_helper_spec.rb | 2 +- spec/jobs/auto_assignment/assignment_job_spec.rb | 2 +- spec/jobs/auto_assignment/periodic_assignment_job_spec.rb | 2 +- spec/jobs/contacts/bulk_action_job_spec.rb | 2 +- spec/jobs/conversation_reply_email_job_spec.rb | 2 +- spec/jobs/delete_object_job_spec.rb | 2 +- spec/models/account_spec.rb | 4 ++-- spec/models/enterprise/audit/conversation_spec.rb | 2 +- spec/requests/api/v1/accounts/base_controller_spec.rb | 2 +- spec/requests/api/v1/profile/mfa_controller_spec.rb | 2 +- 12 files changed, 12 insertions(+), 14 deletions(-) diff --git a/spec/config/markdown_embeds_spec.rb b/spec/config/markdown_embeds_spec.rb index 9e9e56898..c91ab60d2 100644 --- a/spec/config/markdown_embeds_spec.rb +++ b/spec/config/markdown_embeds_spec.rb @@ -1,8 +1,6 @@ require 'rails_helper' -# rubocop:disable RSpec/DescribeClass describe 'Markdown Embeds Configuration' do - # rubocop:enable RSpec/DescribeClass let(:config) { YAML.load_file(Rails.root.join('config/markdown_embeds.yml')) } describe 'YAML structure' do diff --git a/spec/controllers/devise_overrides/sessions_controller_spec.rb b/spec/controllers/devise_overrides/sessions_controller_spec.rb index 8ee012670..6c968cdc8 100644 --- a/spec/controllers/devise_overrides/sessions_controller_spec.rb +++ b/spec/controllers/devise_overrides/sessions_controller_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -RSpec.describe DeviseOverrides::SessionsController, type: :controller do +RSpec.describe DeviseOverrides::SessionsController do include Devise::Test::ControllerHelpers before do diff --git a/spec/helpers/reporting_event_helper_spec.rb b/spec/helpers/reporting_event_helper_spec.rb index e4a3c0255..841df4529 100644 --- a/spec/helpers/reporting_event_helper_spec.rb +++ b/spec/helpers/reporting_event_helper_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -RSpec.describe ReportingEventHelper, type: :helper do +RSpec.describe ReportingEventHelper do describe '#last_non_human_activity' do let(:account) { create(:account) } let(:inbox) { create(:inbox, account: account) } diff --git a/spec/jobs/auto_assignment/assignment_job_spec.rb b/spec/jobs/auto_assignment/assignment_job_spec.rb index d13f9fef8..c47df2e16 100644 --- a/spec/jobs/auto_assignment/assignment_job_spec.rb +++ b/spec/jobs/auto_assignment/assignment_job_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -RSpec.describe AutoAssignment::AssignmentJob, type: :job do +RSpec.describe AutoAssignment::AssignmentJob do let(:account) { create(:account) } let(:inbox) { create(:inbox, account: account, enable_auto_assignment: true) } let(:agent) { create(:user, account: account, role: :agent, availability: :online) } diff --git a/spec/jobs/auto_assignment/periodic_assignment_job_spec.rb b/spec/jobs/auto_assignment/periodic_assignment_job_spec.rb index 4b06decd0..2ff30a46b 100644 --- a/spec/jobs/auto_assignment/periodic_assignment_job_spec.rb +++ b/spec/jobs/auto_assignment/periodic_assignment_job_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -RSpec.describe AutoAssignment::PeriodicAssignmentJob, type: :job do +RSpec.describe AutoAssignment::PeriodicAssignmentJob do let(:account) { create(:account) } let(:inbox) { create(:inbox, account: account, enable_auto_assignment: true) } let(:assignment_policy) { create(:assignment_policy, account: account) } diff --git a/spec/jobs/contacts/bulk_action_job_spec.rb b/spec/jobs/contacts/bulk_action_job_spec.rb index 12a727000..d2caf15f4 100644 --- a/spec/jobs/contacts/bulk_action_job_spec.rb +++ b/spec/jobs/contacts/bulk_action_job_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -RSpec.describe Contacts::BulkActionJob, type: :job do +RSpec.describe Contacts::BulkActionJob do let(:account) { create(:account) } let(:user) { create(:user, account: account) } let(:params) { { 'ids' => [1], 'labels' => { 'add' => ['vip'] } } } diff --git a/spec/jobs/conversation_reply_email_job_spec.rb b/spec/jobs/conversation_reply_email_job_spec.rb index 32758c48e..f0d068a7d 100644 --- a/spec/jobs/conversation_reply_email_job_spec.rb +++ b/spec/jobs/conversation_reply_email_job_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -RSpec.describe ConversationReplyEmailJob, type: :job do +RSpec.describe ConversationReplyEmailJob do let(:conversation) { create(:conversation) } let(:mailer) { double } let(:mailer_action) { double } diff --git a/spec/jobs/delete_object_job_spec.rb b/spec/jobs/delete_object_job_spec.rb index 8267ba0f0..56969b400 100644 --- a/spec/jobs/delete_object_job_spec.rb +++ b/spec/jobs/delete_object_job_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -RSpec.describe DeleteObjectJob, type: :job do +RSpec.describe DeleteObjectJob do describe '#perform' do context 'when object is heavy (Inbox)' do let!(:account) { create(:account) } diff --git a/spec/models/account_spec.rb b/spec/models/account_spec.rb index 5ccff6517..5402532db 100644 --- a/spec/models/account_spec.rb +++ b/spec/models/account_spec.rb @@ -143,13 +143,13 @@ RSpec.describe Account do context 'when auto_resolve_after' do it 'validates minimum value' do account.settings = { auto_resolve_after: 4 } - expect(account).to be_invalid + expect(account).not_to be_valid expect(account.errors.messages).to eq({ auto_resolve_after: ['must be greater than or equal to 10'] }) end it 'validates maximum value' do account.settings = { auto_resolve_after: 1_439_857 } - expect(account).to be_invalid + expect(account).not_to be_valid expect(account.errors.messages).to eq({ auto_resolve_after: ['must be less than or equal to 1439856'] }) end diff --git a/spec/models/enterprise/audit/conversation_spec.rb b/spec/models/enterprise/audit/conversation_spec.rb index 56ea2910d..01def63a5 100644 --- a/spec/models/enterprise/audit/conversation_spec.rb +++ b/spec/models/enterprise/audit/conversation_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -RSpec.describe 'Conversation Audit', type: :model do +RSpec.describe 'Conversation Audit' do let(:account) { create(:account) } let(:conversation) { create(:conversation, account: account) } diff --git a/spec/requests/api/v1/accounts/base_controller_spec.rb b/spec/requests/api/v1/accounts/base_controller_spec.rb index 6493bc986..9252bf748 100644 --- a/spec/requests/api/v1/accounts/base_controller_spec.rb +++ b/spec/requests/api/v1/accounts/base_controller_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -RSpec.describe 'Api::V1::Accounts::BaseController', type: :request do +RSpec.describe 'Api::V1::Accounts::BaseController' do let(:account) { create(:account) } let(:inbox) { create(:inbox, account: account) } let!(:conversation) { create(:conversation, account: account, inbox: inbox) } diff --git a/spec/requests/api/v1/profile/mfa_controller_spec.rb b/spec/requests/api/v1/profile/mfa_controller_spec.rb index 97a2e206f..c5830cac1 100644 --- a/spec/requests/api/v1/profile/mfa_controller_spec.rb +++ b/spec/requests/api/v1/profile/mfa_controller_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -RSpec.describe 'MFA API', type: :request do +RSpec.describe 'MFA API' do before do skip('Skipping since MFA is not configured in this environment') unless Chatwoot.encryption_configured? allow(Chatwoot).to receive(:mfa_enabled?).and_return(true)