akadmin/chatwoot
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

refactor: use the new registry

Browse Source
This commit is contained in:
Shivam Mishra
2026-03-13 12:46:12 +05:30
parent 3fd14942f1
commit 10f1c23742
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/services/reports/rollup_data_source.rb
+7 -7
View File
@@ -94,11 +94,11 @@ class Reports::RollupDataSource < Reports::DataSource
end
def summary_select_fields_for_metric(definition)
return [sum_count_select(definition[:rollup_metric], definition[:summary_key])] if definition[:aggregate] == :count
return [sum_count_select(definition.rollup_metric, definition.summary_key)] if definition.count?
[
sum_count_select(definition[:rollup_metric], summary_count_alias(definition)),
sum_value_select(definition[:rollup_metric], summary_sum_alias(definition))
sum_count_select(definition.rollup_metric, summary_count_alias(definition)),
sum_value_select(definition.rollup_metric, summary_sum_alias(definition))
]
end
@@ -112,22 +112,22 @@ class Reports::RollupDataSource < Reports::DataSource
def summary_attributes_for(row, conversations_count = 0)
summary_metrics.each_with_object({ conversations_count: conversations_count.to_i }) do |definition, attributes|
attributes[definition[:summary_key]] = summary_value_for(row, definition)
attributes[definition.summary_key] = summary_value_for(row, definition)
end
end
def summary_value_for(row, definition)
return row&.public_send(definition[:summary_key]).to_i if definition[:aggregate] == :count
return row&.public_send(definition.summary_key).to_i if definition.count?
average_from(row&.public_send(summary_sum_alias(definition)), row&.public_send(summary_count_alias(definition)))
end
def summary_count_alias(definition)
"#{definition[:summary_key]}_count"
"#{definition.summary_key}_count"
end
def summary_sum_alias(definition)
"#{definition[:summary_key]}_sum_value"
"#{definition.summary_key}_sum_value"
end
def dimension_id_for_rollup