From 10f1c2374247de5aadedb5a8cd8b3521804ac82d Mon Sep 17 00:00:00 2001
From: Shivam Mishra <scm.mymail@gmail.com>
Date: Fri, 13 Mar 2026 12:46:12 +0530
Subject: [PATCH] refactor: use the new registry

---
 app/services/reports/rollup_data_source.rb | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/app/services/reports/rollup_data_source.rb b/app/services/reports/rollup_data_source.rb
index 765afba8a..956911051 100644
--- a/app/services/reports/rollup_data_source.rb
+++ b/app/services/reports/rollup_data_source.rb
@@ -94,11 +94,11 @@ class Reports::RollupDataSource < Reports::DataSource
   end
 
   def summary_select_fields_for_metric(definition)
-    return [sum_count_select(definition[:rollup_metric], definition[:summary_key])] if definition[:aggregate] == :count
+    return [sum_count_select(definition.rollup_metric, definition.summary_key)] if definition.count?
 
     [
-      sum_count_select(definition[:rollup_metric], summary_count_alias(definition)),
-      sum_value_select(definition[:rollup_metric], summary_sum_alias(definition))
+      sum_count_select(definition.rollup_metric, summary_count_alias(definition)),
+      sum_value_select(definition.rollup_metric, summary_sum_alias(definition))
     ]
   end
 
@@ -112,22 +112,22 @@ class Reports::RollupDataSource < Reports::DataSource
 
   def summary_attributes_for(row, conversations_count = 0)
     summary_metrics.each_with_object({ conversations_count: conversations_count.to_i }) do |definition, attributes|
-      attributes[definition[:summary_key]] = summary_value_for(row, definition)
+      attributes[definition.summary_key] = summary_value_for(row, definition)
     end
   end
 
   def summary_value_for(row, definition)
-    return row&.public_send(definition[:summary_key]).to_i if definition[:aggregate] == :count
+    return row&.public_send(definition.summary_key).to_i if definition.count?
 
     average_from(row&.public_send(summary_sum_alias(definition)), row&.public_send(summary_count_alias(definition)))
   end
 
   def summary_count_alias(definition)
-    "#{definition[:summary_key]}_count"
+    "#{definition.summary_key}_count"
   end
 
   def summary_sum_alias(definition)
-    "#{definition[:summary_key]}_sum_value"
+    "#{definition.summary_key}_sum_value"
   end
 
   def dimension_id_for_rollup