# Pull Request Template ## Description - Wires up Controllers to auto-sync job - adds plan based sync schedule - a scheduler that runs every hour to check syncable documents - guards the whole feature behind feature flag by reclaiming `twilio_content_templates` - Adds a global and account level cap on how many documents to enqueue to prevent sudden burst at first run - some refactor to simplify code - specs Fixes # (issue) ## Type of change - [x] New feature (non-breaking change which adds functionality) ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. specs and locally ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] Any dependent changes have been merged and published in downstream modules
139 lines
5.4 KiB
Ruby
139 lines
5.4 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe Captain::Onboarding::WebsiteAnalyzerService do
|
|
let(:website_url) { 'https://example.com' }
|
|
let(:service) { described_class.new(website_url) }
|
|
let(:mock_crawler) { instance_double(Captain::Tools::SimplePageCrawlService) }
|
|
let(:mock_chat) { instance_double(RubyLLM::Chat) }
|
|
let(:business_info) do
|
|
{
|
|
'business_name' => 'Example Corp',
|
|
'suggested_assistant_name' => 'Alex from Example Corp',
|
|
'description' => 'You specialize in helping customers with business solutions and support'
|
|
}
|
|
end
|
|
let(:mock_response) do
|
|
instance_double(RubyLLM::Message, content: business_info.to_json)
|
|
end
|
|
|
|
before do
|
|
create(:installation_config, name: 'CAPTAIN_OPEN_AI_API_KEY', value: 'test-key')
|
|
allow(Captain::Tools::SimplePageCrawlService).to receive(:new).and_return(mock_crawler)
|
|
allow(RubyLLM).to receive(:chat).and_return(mock_chat)
|
|
allow(mock_chat).to receive(:with_temperature).and_return(mock_chat)
|
|
allow(mock_chat).to receive(:with_params).and_return(mock_chat)
|
|
allow(mock_chat).to receive(:with_instructions).and_return(mock_chat)
|
|
allow(mock_chat).to receive(:ask).and_return(mock_response)
|
|
end
|
|
|
|
describe '#analyze' do
|
|
context 'when website content is available and LLM call is successful' do
|
|
before do
|
|
allow(mock_crawler).to receive(:body_markdown).and_return('Welcome to Example Corp')
|
|
allow(mock_crawler).to receive(:page_title).and_return('Example Corp - Home')
|
|
allow(mock_crawler).to receive(:meta_description).and_return('Leading provider of business solutions')
|
|
allow(mock_crawler).to receive(:favicon_url).and_return('https://example.com/favicon.ico')
|
|
end
|
|
|
|
it 'returns successful analysis with extracted business info' do
|
|
result = service.analyze
|
|
|
|
expect(result[:success]).to be true
|
|
expect(result[:data]).to include(
|
|
business_name: 'Example Corp',
|
|
suggested_assistant_name: 'Alex from Example Corp',
|
|
description: 'You specialize in helping customers with business solutions and support',
|
|
website_url: website_url,
|
|
favicon_url: 'https://example.com/favicon.ico'
|
|
)
|
|
end
|
|
|
|
it 'uses low temperature for deterministic analysis' do
|
|
expect(mock_chat).to receive(:with_temperature).with(0.1).and_return(mock_chat)
|
|
service.analyze
|
|
end
|
|
end
|
|
|
|
context 'when website content fetch raises an error' do
|
|
before do
|
|
allow(mock_crawler).to receive(:body_markdown).and_raise(StandardError, 'Network error')
|
|
end
|
|
|
|
it 'returns error response' do
|
|
result = service.analyze
|
|
|
|
expect(result[:success]).to be false
|
|
expect(result[:error]).to eq('Failed to fetch website content')
|
|
end
|
|
end
|
|
|
|
context 'when website content is empty' do
|
|
before do
|
|
allow(mock_crawler).to receive(:body_markdown).and_return('')
|
|
allow(mock_crawler).to receive(:page_title).and_return('')
|
|
allow(mock_crawler).to receive(:meta_description).and_return('')
|
|
end
|
|
|
|
it 'returns error for unavailable content' do
|
|
result = service.analyze
|
|
|
|
expect(result[:success]).to be false
|
|
expect(result[:error]).to eq('Failed to fetch website content')
|
|
end
|
|
end
|
|
|
|
context 'when LLM call fails' do
|
|
before do
|
|
allow(mock_crawler).to receive(:body_markdown).and_return('Welcome to Example Corp')
|
|
allow(mock_crawler).to receive(:page_title).and_return('Example Corp - Home')
|
|
allow(mock_crawler).to receive(:meta_description).and_return('Leading provider of business solutions')
|
|
allow(mock_crawler).to receive(:favicon_url).and_return('https://example.com/favicon.ico')
|
|
allow(mock_chat).to receive(:ask).and_raise(StandardError, 'API error')
|
|
end
|
|
|
|
it 'returns error response with message' do
|
|
result = service.analyze
|
|
|
|
expect(result[:success]).to be false
|
|
expect(result[:error]).to eq('API error')
|
|
end
|
|
end
|
|
|
|
context 'when LLM returns invalid JSON' do
|
|
let(:invalid_response) { instance_double(RubyLLM::Message, content: 'not valid json') }
|
|
|
|
before do
|
|
allow(mock_crawler).to receive(:body_markdown).and_return('Welcome to Example Corp')
|
|
allow(mock_crawler).to receive(:page_title).and_return('Example Corp - Home')
|
|
allow(mock_crawler).to receive(:meta_description).and_return('Leading provider of business solutions')
|
|
allow(mock_crawler).to receive(:favicon_url).and_return('https://example.com/favicon.ico')
|
|
allow(mock_chat).to receive(:ask).and_return(invalid_response)
|
|
end
|
|
|
|
it 'returns error for parsing failure' do
|
|
result = service.analyze
|
|
|
|
expect(result[:success]).to be false
|
|
expect(result[:error]).to eq('Failed to parse business information from website')
|
|
end
|
|
end
|
|
|
|
context 'when URL normalization is needed' do
|
|
let(:website_url) { 'example.com' }
|
|
|
|
before do
|
|
allow(mock_crawler).to receive(:body_markdown).and_return('Welcome')
|
|
allow(mock_crawler).to receive(:page_title).and_return('Example')
|
|
allow(mock_crawler).to receive(:meta_description).and_return('Description')
|
|
allow(mock_crawler).to receive(:favicon_url).and_return(nil)
|
|
end
|
|
|
|
it 'normalizes URL by adding https prefix' do
|
|
result = service.analyze
|
|
|
|
expect(result[:data][:website_url]).to eq('https://example.com')
|
|
end
|
|
end
|
|
end
|
|
end
|