Vishnu NarayananandGitHub
f66b551c7d
## Description Reverts [#14726](https://github.com/chatwoot/chatwoot/pull/14726) (\"feat: Add sidebar unread counts for filters (CW-7262)\"), which shipped in 4.15.0. After 4.15.0 rolled out to prod the unread-counts-for-filters code path caused a cascading incident: - `Counter#ensure_filters_cache!` fires on every `/unread_counts/index` and `update_last_seen` request. - On cache miss it calls `Builder#build_filters_for!`, which: - invokes `store.clear_user_filters!` -> `delete_matching` -> a Redis `SCAN_each` over a per-user pattern keyspace, and - runs 4 fresh SQL passes per user (mentions, participating, unattended, and per-folder `Conversations::FilterService` queries). - Threads blocked in the SCAN held their DB connections, the connection pool exhausted, Sidekiq jobs were discarded with `ActiveJob::DeserializationError: could not obtain a connection from the pool`, and the enqueued queue blew past 200K. Related: [CW-7262](https://linear.app/chatwoot/issue/CW-7262/unread-counts-for-filters-folders) ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality not to work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
67 lines
2.6 KiB
Vue
67 lines
2.6 KiB
Vue
<script setup>
|
|
import { isVNode, computed } from 'vue';
|
|
import Icon from 'next/icon/Icon.vue';
|
|
import Policy from 'dashboard/components/policy.vue';
|
|
import { useSidebarContext } from './provider';
|
|
import SidebarUnreadBadge from './SidebarUnreadBadge.vue';
|
|
|
|
const props = defineProps({
|
|
label: { type: String, required: true },
|
|
to: { type: [String, Object], required: true },
|
|
icon: { type: [String, Object], default: null },
|
|
active: { type: Boolean, default: false },
|
|
component: { type: Function, default: null },
|
|
badgeCount: { type: [Number, String], default: 0 },
|
|
hideTreeLine: { type: Boolean, default: false },
|
|
thinTreeLine: { type: Boolean, default: false },
|
|
});
|
|
|
|
const { resolvePermissions, resolveFeatureFlag } = useSidebarContext();
|
|
|
|
const shouldRenderComponent = computed(() => {
|
|
return typeof props.component === 'function' || isVNode(props.component);
|
|
});
|
|
|
|
// Tree-line connector per leaf: vertical line (::before) + rounded elbow on the
|
|
// last child (::after). Logical props (start / border-s / rounded-es)
|
|
const TREE_CONNECTOR =
|
|
"child-item before:content-[''] before:absolute before:start-0 before:w-0.5 before:h-full before:bg-n-slate-4 first:before:rounded-t last:before:h-1/5 last:after:content-[''] last:after:absolute last:after:start-0 last:after:bottom-[calc(50%_-_2px)] last:after:h-3 last:after:w-2.5 last:after:border-b-2 last:after:border-s-2 last:after:rounded-es last:after:border-n-slate-4";
|
|
</script>
|
|
|
|
<template>
|
|
<Policy
|
|
:permissions="resolvePermissions(to)"
|
|
:feature-flag="resolveFeatureFlag(to)"
|
|
as="li"
|
|
class="py-0.5 ps-2 ms-3 relative text-n-slate-11 min-w-0"
|
|
:class="{
|
|
[TREE_CONNECTOR]: !hideTreeLine,
|
|
'before:!w-px last:after:!border-b last:after:!border-s':
|
|
!hideTreeLine && thinTreeLine,
|
|
}"
|
|
>
|
|
<component
|
|
:is="to ? 'router-link' : 'div'"
|
|
:to="to"
|
|
:title="label"
|
|
class="flex h-8 items-center gap-2 px-2 py-1 rounded-lg ltr:hover:bg-gradient-to-r rtl:hover:bg-gradient-to-l from-transparent via-n-slate-3/70 to-n-slate-3/70 group min-w-0"
|
|
:class="{
|
|
'text-n-slate-12 bg-n-alpha-2 active': active,
|
|
}"
|
|
>
|
|
<component
|
|
:is="component"
|
|
v-if="shouldRenderComponent"
|
|
v-bind="{ label, icon, active, badgeCount }"
|
|
/>
|
|
<template v-else>
|
|
<span v-if="icon" class="size-4 grid place-content-center rounded-full">
|
|
<Icon :icon="icon" class="size-4 inline-block" />
|
|
</span>
|
|
<div class="flex-1 truncate min-w-0 text-sm">{{ label }}</div>
|
|
<SidebarUnreadBadge :count="badgeCount" />
|
|
</template>
|
|
</component>
|
|
</Policy>
|
|
</template>
|