akadmin/chatwoot
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

update the leave policy spec

Browse Source
This commit is contained in:
Tanmay Deep Sharma
2025-08-18 21:08:33 +05:30
parent 081a812243
commit fe1c29a15e
1 changed files with 126 additions and 199 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spec/enterprise/policies/leave_record_policy_spec.rb
+126 -199
View File
@@ -4,216 +4,164 @@ RSpec.describe LeaveRecordPolicy, type: :policy do
let(:account) { create(:account) }
let(:administrator) { create(:user, account: account, role: :administrator) }
let(:agent) { create(:user, account: account, role: :agent) }
let(:other_agent) { create(:user, account: account, role: :agent) }
let(:admin_context) { { user: administrator, account: account, account_user: administrator.account_users.find_by(account: account) } }
let(:agent_context) { { user: agent, account: account, account_user: agent.account_users.find_by(account: account) } }
let(:other_agent_context) { { user: other_agent, account: account, account_user: other_agent.account_users.find_by(account: account) } }
describe 'update?' do
let(:agent_leave_record) { create(:leave_record, account: account, user: agent, status: :pending) }
context 'when leave record is pending' do
context 'when user is administrator' do
it 'allows update of any leave record' do
policy = described_class.new(admin_context, agent_leave_record)
expect(policy.update?).to be true
end
end
context 'when user owns the leave record' do
it 'allows update' do
policy = described_class.new(agent_context, agent_leave_record)
expect(policy.update?).to be true
end
end
context 'when user does not own the leave record' do
it 'denies update' do
policy = described_class.new(other_agent_context, agent_leave_record)
expect(policy.update?).to be false
end
end
describe 'index?' do
it 'allows administrators to list leave records' do
policy = described_class.new(admin_context, LeaveRecord)
expect(policy.index?).to be true
end
context 'when leave record is not pending' do
context 'when user is administrator' do
it 'denies update of approved leave record' do
approved_leave_record = create(:leave_record, account: account, user: agent, status: :approved)
policy = described_class.new(admin_context, approved_leave_record)
expect(policy.update?).to be false
end
it 'allows agents to list leave records' do
policy = described_class.new(agent_context, LeaveRecord)
expect(policy.index?).to be true
end
end
it 'denies update of rejected leave record' do
rejected_leave_record = create(:leave_record, account: account, user: agent, status: :rejected)
policy = described_class.new(admin_context, rejected_leave_record)
expect(policy.update?).to be false
end
describe 'show?' do
let(:leave_record) { create(:leave_record, account: account, user: agent) }
it 'denies update of cancelled leave record' do
cancelled_leave_record = create(:leave_record, account: account, user: agent, status: :cancelled)
policy = described_class.new(admin_context, cancelled_leave_record)
expect(policy.update?).to be false
end
end
it 'allows administrators to view any leave record' do
policy = described_class.new(admin_context, leave_record)
expect(policy.show?).to be true
end
context 'when user owns the leave record' do
it 'denies update of approved leave record' do
approved_leave_record = create(:leave_record, account: account, user: agent, status: :approved)
policy = described_class.new(agent_context, approved_leave_record)
expect(policy.update?).to be false
end
it 'allows agents to view leave records' do
policy = described_class.new(agent_context, leave_record)
expect(policy.show?).to be true
end
end
it 'denies update of rejected leave record' do
rejected_leave_record = create(:leave_record, account: account, user: agent, status: :rejected)
policy = described_class.new(agent_context, rejected_leave_record)
expect(policy.update?).to be false
end
describe 'create?' do
it 'allows administrators to create leave records' do
policy = described_class.new(admin_context, LeaveRecord)
expect(policy.create?).to be true
end
it 'denies update of cancelled leave record' do
cancelled_leave_record = create(:leave_record, account: account, user: agent, status: :cancelled)
policy = described_class.new(agent_context, cancelled_leave_record)
expect(policy.update?).to be false
end
end
it 'allows agents to create leave records' do
policy = described_class.new(agent_context, LeaveRecord)
expect(policy.create?).to be true
end
end
describe 'update?' do
let(:leave_record) { create(:leave_record, account: account, user: agent) }
it 'allows administrators to access update action' do
policy = described_class.new(admin_context, leave_record)
expect(policy.update?).to be true
end
it 'allows agents to access update action' do
policy = described_class.new(agent_context, leave_record)
expect(policy.update?).to be true
end
end
describe 'destroy?' do
context 'when leave record can be cancelled' do
context 'when user is administrator' do
it 'allows destroy of pending leave record' do
pending_leave_record = create(:leave_record, account: account, user: agent, status: :pending)
policy = described_class.new(admin_context, pending_leave_record)
expect(policy.destroy?).to be true
end
let(:leave_record) { create(:leave_record, account: account, user: agent) }
it 'allows destroy of approved future leave record' do
approved_future_leave_record = create(:leave_record, account: account, user: agent, status: :approved,
start_date: 1.week.from_now.to_date,
end_date: 2.weeks.from_now.to_date)
policy = described_class.new(admin_context, approved_future_leave_record)
expect(policy.destroy?).to be true
end
it 'allows destroy of other user leave records' do
other_leave_record = create(:leave_record, account: account, user: other_agent, status: :pending)
policy = described_class.new(admin_context, other_leave_record)
expect(policy.destroy?).to be true
end
end
context 'when user owns the leave record' do
it 'allows destroy of own pending leave record' do
pending_leave_record = create(:leave_record, account: account, user: agent, status: :pending)
policy = described_class.new(agent_context, pending_leave_record)
expect(policy.destroy?).to be true
end
it 'allows destroy of own approved future leave record' do
approved_future_leave_record = create(:leave_record, account: account, user: agent, status: :approved,
start_date: 1.week.from_now.to_date,
end_date: 2.weeks.from_now.to_date)
policy = described_class.new(agent_context, approved_future_leave_record)
expect(policy.destroy?).to be true
end
end
context 'when user does not own the leave record' do
it 'denies destroy of other user leave record' do
pending_leave_record = create(:leave_record, account: account, user: agent, status: :pending)
policy = described_class.new(other_agent_context, pending_leave_record)
expect(policy.destroy?).to be false
end
end
it 'allows administrators to access destroy action' do
policy = described_class.new(admin_context, leave_record)
expect(policy.destroy?).to be true
end
context 'when leave record cannot be cancelled' do
context 'when user is administrator' do
it 'denies destroy of current approved leave record' do
approved_current_leave_record = create(:leave_record, account: account, user: agent, status: :approved,
start_date: Date.current, end_date: Date.current + 2.days)
policy = described_class.new(admin_context, approved_current_leave_record)
expect(policy.destroy?).to be false
end
it 'allows agents to access destroy action' do
policy = described_class.new(agent_context, leave_record)
expect(policy.destroy?).to be true
end
end
it 'denies destroy of past approved leave record' do
approved_past_leave_record = create(:leave_record, account: account, user: agent, status: :approved,
start_date: 1.week.ago.to_date, end_date: 3.days.ago.to_date)
policy = described_class.new(admin_context, approved_past_leave_record)
expect(policy.destroy?).to be false
end
describe 'approve?' do
let(:leave_record) { create(:leave_record, account: account, user: agent) }
it 'denies destroy of rejected leave record' do
rejected_leave_record = create(:leave_record, account: account, user: agent, status: :rejected)
policy = described_class.new(admin_context, rejected_leave_record)
expect(policy.destroy?).to be false
end
end
it 'allows only administrators to approve leave records' do
policy = described_class.new(admin_context, leave_record)
expect(policy.approve?).to be true
end
context 'when user owns the leave record' do
it 'denies destroy of current approved leave record' do
approved_current_leave_record = create(:leave_record, account: account, user: agent, status: :approved,
start_date: Date.current, end_date: Date.current + 2.days)
policy = described_class.new(agent_context, approved_current_leave_record)
expect(policy.destroy?).to be false
end
it 'denies agents from approving leave records' do
policy = described_class.new(agent_context, leave_record)
expect(policy.approve?).to be false
end
end
it 'denies destroy of past approved leave record' do
approved_past_leave_record = create(:leave_record, account: account, user: agent, status: :approved,
start_date: 1.week.ago.to_date, end_date: 3.days.ago.to_date)
policy = described_class.new(agent_context, approved_past_leave_record)
expect(policy.destroy?).to be false
end
describe 'reject?' do
let(:leave_record) { create(:leave_record, account: account, user: agent) }
it 'denies destroy of rejected leave record' do
rejected_leave_record = create(:leave_record, account: account, user: agent, status: :rejected)
policy = described_class.new(agent_context, rejected_leave_record)
expect(policy.destroy?).to be false
end
end
it 'allows only administrators to reject leave records' do
policy = described_class.new(admin_context, leave_record)
expect(policy.reject?).to be true
end
it 'denies agents from rejecting leave records' do
policy = described_class.new(agent_context, leave_record)
expect(policy.reject?).to be false
end
end
describe 'Scope' do
before do
create(:leave_record, account: account, user: administrator)
create(:leave_record, account: account, user: agent)
create(:leave_record, account: account, user: other_agent)
end
let(:other_agent) { create(:user, account: account, role: :agent) }
context 'when user is administrator' do
it 'returns all leave records in account with includes' do
scope = LeaveRecordPolicy::Scope.new(admin_context, account.leave_records)
result = scope.resolve
describe '#resolve' do
before do
create(:leave_record, account: account, user: administrator)
create(:leave_record, account: account, user: agent)
create(:leave_record, account: account, user: other_agent)
end
expect(result.count).to eq(3)
expect(result.includes_values).to include(:user, :approver)
expect(result.map(&:user_id)).to contain_exactly(administrator.id, agent.id, other_agent.id)
context 'when user is administrator' do
it 'returns all leave records in the account' do
scope = LeaveRecordPolicy::Scope.new(admin_context, account.leave_records)
result = scope.resolve
expect(result.count).to eq(3)
expect(result.map(&:user_id)).to contain_exactly(
administrator.id,
agent.id,
other_agent.id
)
end
it 'includes user and approver associations for performance' do
scope = LeaveRecordPolicy::Scope.new(admin_context, account.leave_records)
result = scope.resolve
expect(result.includes_values).to include(:user, :approver)
end
end
context 'when user is agent' do
it 'returns only the agent\'s own leave records' do
scope = LeaveRecordPolicy::Scope.new(agent_context, account.leave_records)
result = scope.resolve
expect(result.count).to eq(1)
expect(result.first.user_id).to eq(agent.id)
end
it 'does not return other agents\' leave records' do
scope = LeaveRecordPolicy::Scope.new(agent_context, account.leave_records)
result = scope.resolve
user_ids = result.map(&:user_id)
expect(user_ids).not_to include(other_agent.id)
expect(user_ids).not_to include(administrator.id)
end
it 'includes user and approver associations for performance' do
scope = LeaveRecordPolicy::Scope.new(agent_context, account.leave_records)
result = scope.resolve
expect(result.includes_values).to include(:user, :approver)
end
end
end
context 'when user is not administrator' do
it 'returns only own leave records with includes' do
scope = LeaveRecordPolicy::Scope.new(agent_context, account.leave_records)
result = scope.resolve
expect(result.count).to eq(1)
expect(result.first.user_id).to eq(agent.id)
expect(result.includes_values).to include(:user, :approver)
end
it 'filters correctly for other agent' do
scope = LeaveRecordPolicy::Scope.new(other_agent_context, account.leave_records)
result = scope.resolve
expect(result.count).to eq(1)
expect(result.first.user_id).to eq(other_agent.id)
end
end
context 'when initializing scope' do
it 'properly initializes all context variables' do
describe 'initialization' do
it 'properly sets all context attributes' do
scope = LeaveRecordPolicy::Scope.new(admin_context, account.leave_records)
expect(scope.user_context).to eq(admin_context)
@@ -224,25 +172,4 @@ RSpec.describe LeaveRecordPolicy, type: :policy do
end
end
end
describe 'ownership checks' do
describe '#owned_by_user?' do
it 'returns true when user owns the leave record' do
agent_leave_record = create(:leave_record, account: account, user: agent, status: :pending)
policy = described_class.new(agent_context, agent_leave_record)
expect(policy.send(:owned_by_user?)).to be true
end
it 'returns false when user does not own the leave record' do
agent_leave_record = create(:leave_record, account: account, user: agent, status: :pending)
policy = described_class.new(other_agent_context, agent_leave_record)
expect(policy.send(:owned_by_user?)).to be false
end
it 'returns false when record is nil' do
policy = described_class.new(agent_context, nil)
expect(policy.send(:owned_by_user?)).to be false
end
end
end
end