akadmin/chatwoot
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

chore: update link issue API

Browse Source
This commit is contained in:
Muhsin Keloth
2024-05-10 15:50:13 +05:30
parent 4d47fc1c25
commit ecce6e021b
2 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/controllers/api/v1/accounts/integrations/linear_controller.rb
+12 -3
View File
@@ -1,4 +1,6 @@
class Api::V1::Accounts::Integrations::LinearController < Api::V1::Accounts::BaseController
before_action :fetch_conversation, only: [:link_issue]
def teams
teams = linear_processor_service.teams
if teams.is_a?(Hash) && teams[:error]
@@ -28,9 +30,8 @@ class Api::V1::Accounts::Integrations::LinearController < Api::V1::Accounts::Bas
end
def link_issue
link = params[:link]
issue_id = params[:issue_id]
issue = linear_processor_service.link_issue(link, issue_id)
issue = linear_processor_service.link_issue(conversation_link, issue_id)
if issue.is_a?(Hash) && issue[:error]
render json: { error: issue[:error] }, status: :unprocessable_entity
else
@@ -76,11 +77,19 @@ class Api::V1::Accounts::Integrations::LinearController < Api::V1::Accounts::Bas
private
def conversation_link
"#{ENV.fetch('FRONTEND_URL', nil)}/app/accounts/#{Current.account.id}/conversations/#{@conversation.display_id}"
end
def fetch_conversation
@conversation = Current.account.conversations.find_by!(display_id: permitted_params[:conversation_id])
end
def linear_processor_service
Integrations::Linear::ProcessorService.new(account: Current.account)
end
def permitted_params
params.permit(:team_id, :link, :issue_id, :link_id, :title, :description, :assignee_id, :priority, label_ids: [])
params.permit(:team_id, :conversation_id, :issue_id, :link_id, :title, :description, :assignee_id, :priority, label_ids: [])
end
end
spec/controllers/api/v1/accounts/integrations/linear_controller_spec.rb
+4 -3
View File
@@ -124,8 +124,9 @@ RSpec.describe 'Linear Integration API', type: :request do
end
describe 'POST /api/v1/accounts/:account_id/integrations/linear/link_issue' do
let(:link) { 'https://linear.app/issue1' }
let(:issue_id) { 'issue1' }
let(:conversation) { create(:conversation, account: account) }
let(:link) { "#{ENV.fetch('FRONTEND_URL', nil)}/app/accounts/#{account.id}/conversations/#{conversation.display_id}" }
context 'when it is an authenticated user' do
context 'when the issue is linked successfully' do
@@ -134,7 +135,7 @@ RSpec.describe 'Linear Integration API', type: :request do
it 'returns the linked issue' do
allow(processor_service).to receive(:link_issue).with(link, issue_id).and_return(linked_issue)
post "/api/v1/accounts/#{account.id}/integrations/linear/link_issue",
params: { link: link, issue_id: issue_id },
params: { conversation_id: conversation.display_id, issue_id: issue_id },
headers: agent.create_new_auth_token,
as: :json
expect(response).to have_http_status(:ok)
@@ -146,7 +147,7 @@ RSpec.describe 'Linear Integration API', type: :request do
it 'returns error message' do
allow(processor_service).to receive(:link_issue).with(link, issue_id).and_return(error: 'error message')
post "/api/v1/accounts/#{account.id}/integrations/linear/link_issue",
params: { link: link, issue_id: issue_id },
params: { conversation_id: conversation.display_id, issue_id: issue_id },
headers: agent.create_new_auth_token,
as: :json
expect(response).to have_http_status(:unprocessable_entity)