chore: Review fix

This commit is contained in:
iamsivin
2026-05-08 21:03:18 +05:30
parent 19a012648c
commit a780de064d
2 changed files with 23 additions and 2 deletions
+7 -2
View File
@@ -68,7 +68,12 @@ class DataImport::ContactManager
def assign_additional_attributes(params, contact)
contact.additional_attributes[:company_name] = params[:company_name] if params[:company_name].present?
contact.additional_attributes[:city] = params[:city] if params[:city].present?
contact.additional_attributes[:country] = params[:country] if params[:country].present?
contact.additional_attributes[:country_code] = params[:country_code] if params[:country_code].present?
assign_country_attributes(params, contact)
end
def assign_country_attributes(params, contact)
contact.additional_attributes['country'] = params[:country] if params[:country].present?
contact.additional_attributes['country_code'] = params[:country_code] if params[:country_code].present?
contact.country_code = params[:country] if params[:country].present?
end
end
+16
View File
@@ -214,6 +214,22 @@ RSpec.describe DataImportJob do
expect(bob.additional_attributes['country']).to be_nil
expect(bob.additional_attributes['country_code']).to be_nil
end
it 'populates the country_code column for new contacts via the bulk import path' do
described_class.perform_now(country_data_import)
expect(Contact.from_email('john-country@example.com').country_code).to eq('United States')
expect(Contact.from_email('jane-country@example.com').country_code).to eq('India')
expect(Contact.from_email('bob-country@example.com').country_code).to eq('')
end
it 'populates the country_code column when updating an existing contact' do
existing = create(:contact, account: country_data_import.account, email: 'john-country@example.com')
described_class.perform_now(country_data_import)
expect(existing.reload.country_code).to eq('United States')
end
end
context 'when the data contains labels column' do