fix: update WhatsApp GlobalConfigService.load calls

This commit is contained in:
Tanmay Deep Sharma
2025-06-09 10:24:26 +05:30
parent 71ddd6c2c2
commit 4a7a68e6e7
6 changed files with 15 additions and 15 deletions
@@ -39,7 +39,8 @@ class SuperAdmin::AppConfigsController < SuperAdmin::ApplicationController
'email' => ['MAILER_INBOUND_EMAIL_DOMAIN'],
'linear' => %w[LINEAR_CLIENT_ID LINEAR_CLIENT_SECRET],
'slack' => %w[SLACK_CLIENT_ID SLACK_CLIENT_SECRET],
'instagram' => %w[INSTAGRAM_APP_ID INSTAGRAM_APP_SECRET INSTAGRAM_VERIFY_TOKEN INSTAGRAM_API_VERSION ENABLE_INSTAGRAM_CHANNEL_HUMAN_AGENT]
'instagram' => %w[INSTAGRAM_APP_ID INSTAGRAM_APP_SECRET INSTAGRAM_VERIFY_TOKEN INSTAGRAM_API_VERSION ENABLE_INSTAGRAM_CHANNEL_HUMAN_AGENT],
'whatsapp_embedded' => %w[WHATSAPP_APP_ID WHATSAPP_APP_SECRET WHATSAPP_CONFIGURATION_ID]
}
@allowed_configs = mapping.fetch(@config, %w[ENABLE_ACCOUNT_SIGNUP FIREBASE_PROJECT_ID FIREBASE_CREDENTIALS])
@@ -11,8 +11,7 @@ class Whatsapp::EmbeddedController < ApplicationController
status: 'ready',
app_id: GlobalConfigService.load('WHATSAPP_APP_ID', ''),
config_id: GlobalConfigService.load('WHATSAPP_CONFIGURATION_ID', ''),
partner_id: GlobalConfigService.load('WHATSAPP_PARTNER_ID', ''),
graph_api_version: GlobalConfigService.load('WHATSAPP_GRAPH_API_VERSION', 'v21.0')
app_secret: GlobalConfigService.load('WHATSAPP_APP_SECRET', '')
}
end
@@ -15,6 +15,7 @@ class Whatsapp::EmbeddedSignupService
raise ArgumentError, 'Code, business_id, waba_id, and phone_number_id are all required'
end
GlobalConfig.clear_cache
# Exchange code for user access token
access_token = exchange_code_for_token
+3 -8
View File
@@ -135,14 +135,9 @@
display_title: 'WhatsApp Configuration ID'
description: 'The Configuration ID for WhatsApp Embedded Signup flow (required for embedded signup)'
locked: false
- name: WHATSAPP_PARTNER_ID
display_title: 'WhatsApp Partner ID'
description: 'Your Partner ID for WhatsApp Business (required for Solution Partners)'
locked: false
- name: WHATSAPP_GRAPH_API_VERSION
display_title: 'WhatsApp Graph API Version'
description: 'The Graph API version to use for WhatsApp Business API'
value: 'v21.0'
- name: WHATSAPP_APP_SECRET
display_title: 'WhatsApp App Secret'
description: 'The App Secret for WhatsApp Embedded Signup flow (required for embedded signup)'
locked: false
# ------- End of WhatsApp Channel Related Config ------- #
@@ -97,6 +97,12 @@ slack:
enabled: true
icon: 'icon-slack'
config_key: 'slack'
whatsapp_embedded:
name: 'WhatsApp Embedded'
description: 'Configuration for setting up WhatsApp Embedded Integration'
enabled: true
icon: 'icon-whatsapp-line'
config_key: 'whatsapp_embedded'
shopify:
name: 'Shopify'
description: 'Configuration for setting up Shopify Integration'
@@ -8,8 +8,7 @@ RSpec.describe 'WhatsApp Embedded API', type: :request do
before do
allow(GlobalConfigService).to receive(:load).with('WHATSAPP_APP_ID', '').and_return('test_app_id')
allow(GlobalConfigService).to receive(:load).with('WHATSAPP_CONFIGURATION_ID', '').and_return('test_config_id')
allow(GlobalConfigService).to receive(:load).with('WHATSAPP_PARTNER_ID', '').and_return('test_partner_id')
allow(GlobalConfigService).to receive(:load).with('WHATSAPP_GRAPH_API_VERSION', 'v21.0').and_return('v21.0')
allow(GlobalConfigService).to receive(:load).with('WHATSAPP_APP_SECRET', '').and_return('test_app_secret')
end
context 'when user is authenticated' do
@@ -24,8 +23,7 @@ RSpec.describe 'WhatsApp Embedded API', type: :request do
'status' => 'ready',
'app_id' => 'test_app_id',
'config_id' => 'test_config_id',
'partner_id' => 'test_partner_id',
'graph_api_version' => 'v21.0'
'app_secret' => 'test_app_secret'
)
end
end