fix(storage): preserve application logger
Remove the ActiveStorage migrator class-load logger override so eager loading does not replace the configured Rails logger or log level.
This commit is contained in:
@@ -1,11 +1,7 @@
|
||||
require 'yaml'
|
||||
require 'erb'
|
||||
require 'logger'
|
||||
|
||||
class ActiveStorage::Migrator
|
||||
Rails.logger = Logger.new($stdout)
|
||||
Rails.logger.level = Logger::DEBUG
|
||||
|
||||
def self.migrate(from_service_name, to_service_name, update_service_name: true)
|
||||
configs = load_storage_config
|
||||
# Check if services are configured correctly
|
||||
|
||||
@@ -24,6 +24,14 @@ RSpec.describe ActiveStorage::Migrator do
|
||||
|
||||
described_class.migrate('local', 'amazon', update_service_name: false)
|
||||
end
|
||||
|
||||
it 'does not override the application logger' do
|
||||
allow(described_class).to receive(:migrate_blobs)
|
||||
|
||||
expect(Rails).not_to receive(:logger=)
|
||||
|
||||
described_class.migrate('local', 'amazon')
|
||||
end
|
||||
end
|
||||
|
||||
context 'when services are not configured correctly' do
|
||||
|
||||
Reference in New Issue
Block a user