# Pull Request Template ## Description - Validates openai key while configuring hooks - added backfill logic Fixes # (issue) ## Type of change - [x] New feature (non-breaking change which adds functionality) ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. locally <img width="1710" height="1234" alt="CleanShot 2026-04-15 at 16 15 02@2x" src="https://github.com/user-attachments/assets/3d319fe0-19f9-4fd0-9308-74987daac2e1" /> <img width="2884" height="1136" alt="CleanShot 2026-05-11 at 19 22 53@2x" src="https://github.com/user-attachments/assets/5eae8650-985b-4c4a-af42-35f7175ff52d" /> ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Vishnu Narayanan <iamwishnu@gmail.com>
129 lines
3.8 KiB
Ruby
129 lines
3.8 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe Integrations::App do
|
|
let(:apps) { described_class }
|
|
let(:app) { apps.find(id: app_name) }
|
|
let(:account) { create(:account) }
|
|
|
|
before { allow(Integrations::Openai::KeyValidator).to receive(:valid?).and_return(true) }
|
|
|
|
describe '#name' do
|
|
let(:app_name) { 'slack' }
|
|
|
|
it 'returns the name' do
|
|
expect(app.name).to eq('Slack')
|
|
end
|
|
end
|
|
|
|
describe '#logo' do
|
|
let(:app_name) { 'slack' }
|
|
|
|
it 'returns the logo' do
|
|
expect(app.logo).to eq('slack.png')
|
|
end
|
|
end
|
|
|
|
describe '#action' do
|
|
let(:app_name) { 'slack' }
|
|
|
|
before do
|
|
allow(Current).to receive(:account).and_return(account)
|
|
end
|
|
|
|
context 'when the app is slack' do
|
|
it 'returns the action URL with client_id and redirect_uri' do
|
|
with_modified_env SLACK_CLIENT_ID: 'dummy_client_id' do
|
|
expect(app.action).to include('client_id=dummy_client_id')
|
|
expect(app.action).to include(
|
|
"/app/accounts/#{account.id}/settings/integrations/slack"
|
|
)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#active?' do
|
|
let(:app_name) { 'slack' }
|
|
|
|
context 'when the app is slack' do
|
|
it 'returns true if SLACK_CLIENT_SECRET is present' do
|
|
with_modified_env SLACK_CLIENT_SECRET: 'random_secret' do
|
|
expect(app.active?(account)).to be true
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when the app is shopify' do
|
|
let(:app_name) { 'shopify' }
|
|
|
|
it 'returns true if the shopify integration feature is enabled' do
|
|
account.enable_features('shopify_integration')
|
|
allow(GlobalConfigService).to receive(:load).with('SHOPIFY_CLIENT_ID', nil).and_return('client_id')
|
|
expect(app.active?(account)).to be true
|
|
end
|
|
|
|
it 'returns false if the shopify integration feature is disabled' do
|
|
allow(GlobalConfigService).to receive(:load).with('SHOPIFY_CLIENT_ID', nil).and_return('client_id')
|
|
expect(app.active?(account)).to be false
|
|
end
|
|
|
|
it 'returns false if SHOPIFY_CLIENT_ID is not present, even if feature is enabled' do
|
|
account.enable_features('shopify_integration')
|
|
allow(GlobalConfigService).to receive(:load).with('SHOPIFY_CLIENT_ID', nil).and_return(nil)
|
|
expect(app.active?(account)).to be false
|
|
end
|
|
end
|
|
|
|
context 'when the app is linear' do
|
|
let(:app_name) { 'linear' }
|
|
|
|
it 'returns false if the linear integration feature is disabled' do
|
|
expect(app.active?(account)).to be false
|
|
end
|
|
|
|
it 'returns true if the linear integration feature is enabled' do
|
|
account.enable_features('linear_integration')
|
|
account.save!
|
|
allow(GlobalConfigService).to receive(:load).with('LINEAR_CLIENT_ID', nil).and_return('client_id')
|
|
expect(app.active?(account)).to be true
|
|
end
|
|
end
|
|
|
|
context 'when other apps are queried' do
|
|
let(:app_name) { 'webhook' }
|
|
|
|
it 'returns true' do
|
|
expect(app.active?(account)).to be true
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#enabled?' do
|
|
context 'when the app is webhook' do
|
|
let(:app_name) { 'webhook' }
|
|
|
|
it 'returns false if the account does not have any webhooks' do
|
|
expect(app.enabled?(account)).to be false
|
|
end
|
|
|
|
it 'returns true if the account has webhooks' do
|
|
create(:webhook, account: account)
|
|
expect(app.enabled?(account)).to be true
|
|
end
|
|
end
|
|
|
|
context 'when the app is anything other than webhook' do
|
|
let(:app_name) { 'openai' }
|
|
|
|
it 'returns false if the account does not have any hooks for the app' do
|
|
expect(app.enabled?(account)).to be false
|
|
end
|
|
|
|
it 'returns true if the account has hooks for the app' do
|
|
create(:integrations_hook, :openai, account: account)
|
|
expect(app.enabled?(account)).to be true
|
|
end
|
|
end
|
|
end
|
|
end
|