# Pull Request Template ## Description This PR fixes a crash where opening a conversation threw `TypeError: Cannot read properties of null (reading 'localeCompare')` and prevented the agent assignment dropdown from rendering. Since #14866, agent bots are included in the assignable agents list. `AgentBot#name` is not presence-validated, so system bots (account-less, global) can have a `null` name. Those nameless bots flowed into name-based operations that assumed a string, causing crashes and warnings across multiple surfaces: * **Assignment dropdown sort:** `getAgentsByAvailability` called `a.name.localeCompare(b.name)`, causing a `localeCompare` `TypeError`. * **Dropdown search:** `MultiselectDropdownItems` called `option.name.toLowerCase()`, causing a `toLowerCase` `TypeError`. * **Agent Bots settings:** `Avatar` received `name=null` for a `String` prop, triggering a Vue prop validation warning. ### What changed * Keep nameless agent bots in the assignment dropdown and render a `-` fallback label in `useAgentsList`. These are still valid, assignable-by-ID records: the assignable agents API includes accessible bots, and `Conversations::AssignmentService` assigns them by ID. Preserving them avoids hiding valid assignment targets. Bots are still included only when `includeAgentBots` is enabled. * Make the sort in `getAgentsByAvailability` null-safe by coercing missing names to an empty string (defense in depth). * Make the search filter in `MultiselectDropdownItems` null-safe (defense in depth). * Pass a null-safe `name` prop to `Avatar` in the Agent Bots settings list to eliminate the Vue prop validation warning. Fixes https://linear.app/chatwoot/issue/CW-7670/agent-assignment-dropdown-crashes-with-cannot-read-properties-of-null ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? 1. Have a system agent bot (`name: null`) that is assignable to an inbox. 2. Open any conversation in that inbox. * The agent assignment dropdown renders without console errors. * The nameless bot is listed with a `-` label and can be assigned. 3. Go to **Settings → Agent Bots**. * The page renders without the `Avatar` prop validation warning. ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
208 lines
5.7 KiB
Vue
208 lines
5.7 KiB
Vue
<script>
|
|
import WootDropdownItem from 'shared/components/ui/dropdown/DropdownItem.vue';
|
|
import WootDropdownMenu from 'shared/components/ui/dropdown/DropdownMenu.vue';
|
|
import Avatar from 'next/avatar/Avatar.vue';
|
|
import Icon from 'dashboard/components-next/icon/Icon.vue';
|
|
import EmojiIcon from 'dashboard/components-next/emoji-icon-picker/EmojiIcon.vue';
|
|
import NextButton from 'dashboard/components-next/button/Button.vue';
|
|
|
|
export default {
|
|
components: {
|
|
WootDropdownItem,
|
|
WootDropdownMenu,
|
|
Avatar,
|
|
Icon,
|
|
EmojiIcon,
|
|
NextButton,
|
|
},
|
|
|
|
props: {
|
|
options: {
|
|
type: Array,
|
|
default: () => [],
|
|
},
|
|
selectedItems: {
|
|
type: Array,
|
|
default: () => [],
|
|
},
|
|
hasThumbnail: {
|
|
type: Boolean,
|
|
default: true,
|
|
},
|
|
inputPlaceholder: {
|
|
type: String,
|
|
default: 'Search',
|
|
},
|
|
noSearchResult: {
|
|
type: String,
|
|
default: 'No results found',
|
|
},
|
|
showEmojiIcon: {
|
|
type: Boolean,
|
|
default: false,
|
|
},
|
|
},
|
|
emits: ['select'],
|
|
|
|
data() {
|
|
return {
|
|
search: '',
|
|
};
|
|
},
|
|
|
|
computed: {
|
|
filteredOptions() {
|
|
return this.options.filter(option => {
|
|
return (option.name || '')
|
|
.toLowerCase()
|
|
.includes(this.search.toLowerCase());
|
|
});
|
|
},
|
|
noResult() {
|
|
return this.filteredOptions.length === 0 && this.search !== '';
|
|
},
|
|
},
|
|
|
|
mounted() {
|
|
this.focusInput();
|
|
},
|
|
|
|
methods: {
|
|
onclick(option) {
|
|
this.$emit('select', option);
|
|
},
|
|
focusInput() {
|
|
this.$refs.searchbar.focus();
|
|
},
|
|
isActive(option) {
|
|
return this.selectedItems.some(item => {
|
|
if (!item || option.id !== item.id) return false;
|
|
|
|
return (
|
|
(option.assignee_type || 'User') === (item.assignee_type || 'User')
|
|
);
|
|
});
|
|
},
|
|
},
|
|
};
|
|
</script>
|
|
|
|
<template>
|
|
<div class="dropdown-wrap">
|
|
<div class="flex-auto flex-grow-0 flex-shrink-0 mb-2 max-h-8">
|
|
<input
|
|
ref="searchbar"
|
|
v-model="search"
|
|
type="text"
|
|
class="search-input"
|
|
autofocus="true"
|
|
:placeholder="inputPlaceholder"
|
|
/>
|
|
</div>
|
|
<div class="flex items-start justify-start flex-auto overflow-auto mt-2">
|
|
<div class="w-full max-h-[10rem]">
|
|
<WootDropdownMenu>
|
|
<WootDropdownItem
|
|
v-for="option in filteredOptions"
|
|
:key="`${option.assignee_type || 'User'}-${option.id}`"
|
|
>
|
|
<NextButton
|
|
slate
|
|
:variant="isActive(option) ? 'faded' : 'ghost'"
|
|
trailing-icon
|
|
:icon="isActive(option) ? 'i-lucide-check' : ''"
|
|
class="w-full !px-2.5"
|
|
@click="() => onclick(option)"
|
|
>
|
|
<div
|
|
class="flex items-center justify-between w-full min-w-0 gap-2"
|
|
>
|
|
<span
|
|
class="my-0 overflow-hidden text-sm leading-4 whitespace-nowrap text-ellipsis"
|
|
:title="option.name"
|
|
>
|
|
{{ option.name }}
|
|
</span>
|
|
</div>
|
|
<Avatar
|
|
v-if="
|
|
hasThumbnail &&
|
|
(!option.icon || option.assignee_type === 'AgentBot')
|
|
"
|
|
:src="option.thumbnail"
|
|
:name="option.name"
|
|
:status="option.availability_status"
|
|
:icon-name="
|
|
option.assignee_type === 'AgentBot'
|
|
? 'i-lucide-bot'
|
|
: undefined
|
|
"
|
|
:size="24"
|
|
hide-offline-status
|
|
rounded-full
|
|
>
|
|
<template
|
|
v-if="option.assignee_type === 'AgentBot' && option.thumbnail"
|
|
#badge
|
|
>
|
|
<div
|
|
class="absolute z-20 flex items-center justify-center rounded-full outline outline-1 outline-n-weak bg-n-solid-1 -bottom-0.5 ltr:-right-0.5 rtl:-left-0.5 size-3.5"
|
|
>
|
|
<Icon
|
|
icon="i-lucide-bot"
|
|
class="text-n-slate-11 size-2.5"
|
|
/>
|
|
</div>
|
|
</template>
|
|
</Avatar>
|
|
<div
|
|
v-else-if="option.icon && showEmojiIcon"
|
|
class="flex items-center justify-center flex-shrink-0 text-sm rounded-full size-6 outline outline-1 -outline-offset-1 outline-n-weak"
|
|
>
|
|
<EmojiIcon
|
|
:value="option.icon"
|
|
:color="option.icon_color"
|
|
class="size-3.5 !text-sm"
|
|
/>
|
|
</div>
|
|
<Icon
|
|
v-else-if="option.icon"
|
|
:icon="option.icon"
|
|
class="size-5 text-n-slate-11"
|
|
/>
|
|
</NextButton>
|
|
</WootDropdownItem>
|
|
</WootDropdownMenu>
|
|
<h4
|
|
v-if="noResult"
|
|
class="w-full justify-center items-center flex text-n-slate-10 py-2 px-2.5 overflow-hidden whitespace-nowrap text-ellipsis text-sm"
|
|
>
|
|
{{ noSearchResult }}
|
|
</h4>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</template>
|
|
|
|
<style lang="scss" scoped>
|
|
.dropdown-wrap {
|
|
@apply w-full flex flex-col max-h-[12.5rem];
|
|
}
|
|
|
|
.search-input {
|
|
@apply m-0 w-full border border-solid border-transparent h-8 text-sm text-n-slate-12 rounded-md focus:border-n-brand bg-n-background dark:bg-n-background;
|
|
}
|
|
|
|
.multiselect-dropdown--item {
|
|
@apply justify-between w-full;
|
|
|
|
&.active {
|
|
@apply bg-n-slate-2 dark:bg-n-solid-3 border-n-weak/50 dark:border-n-weak font-medium;
|
|
}
|
|
|
|
&:hover {
|
|
@apply bg-n-slate-2 dark:bg-n-solid-3 text-n-slate-12;
|
|
}
|
|
}
|
|
</style>
|