Vishnu NarayananandGitHub
f66b551c7d
## Description Reverts [#14726](https://github.com/chatwoot/chatwoot/pull/14726) (\"feat: Add sidebar unread counts for filters (CW-7262)\"), which shipped in 4.15.0. After 4.15.0 rolled out to prod the unread-counts-for-filters code path caused a cascading incident: - `Counter#ensure_filters_cache!` fires on every `/unread_counts/index` and `update_last_seen` request. - On cache miss it calls `Builder#build_filters_for!`, which: - invokes `store.clear_user_filters!` -> `delete_matching` -> a Redis `SCAN_each` over a per-user pattern keyspace, and - runs 4 fresh SQL passes per user (mentions, participating, unattended, and per-folder `Conversations::FilterService` queries). - Threads blocked in the SCAN held their DB connections, the connection pool exhausted, Sidekiq jobs were discarded with `ActiveJob::DeserializationError: could not obtain a connection from the pool`, and the enqueued queue blew past 200K. Related: [CW-7262](https://linear.app/chatwoot/issue/CW-7262/unread-counts-for-filters-folders) ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality not to work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
87 lines
2.6 KiB
Ruby
87 lines
2.6 KiB
Ruby
# == Schema Information
|
|
#
|
|
# Table name: account_users
|
|
#
|
|
# id :bigint not null, primary key
|
|
# active_at :datetime
|
|
# auto_offline :boolean default(TRUE), not null
|
|
# availability :integer default("online"), not null
|
|
# role :integer default("agent")
|
|
# created_at :datetime not null
|
|
# updated_at :datetime not null
|
|
# account_id :bigint
|
|
# agent_capacity_policy_id :bigint
|
|
# custom_role_id :bigint
|
|
# inviter_id :bigint
|
|
# user_id :bigint
|
|
#
|
|
# Indexes
|
|
#
|
|
# index_account_users_on_account_id (account_id)
|
|
# index_account_users_on_agent_capacity_policy_id (agent_capacity_policy_id)
|
|
# index_account_users_on_custom_role_id (custom_role_id)
|
|
# index_account_users_on_user_id (user_id)
|
|
# uniq_user_id_per_account_id (account_id,user_id) UNIQUE
|
|
#
|
|
|
|
class AccountUser < ApplicationRecord
|
|
include AvailabilityStatusable
|
|
|
|
belongs_to :account
|
|
belongs_to :user
|
|
belongs_to :inviter, class_name: 'User', optional: true
|
|
|
|
enum role: { agent: 0, administrator: 1 }
|
|
enum availability: { online: 0, offline: 1, busy: 2 }
|
|
|
|
accepts_nested_attributes_for :account
|
|
|
|
after_create_commit :notify_creation, :create_notification_setting
|
|
after_destroy :notify_deletion, :remove_user_from_account
|
|
after_save :update_presence_in_redis, if: :saved_change_to_availability?
|
|
|
|
validates :user_id, uniqueness: { scope: :account_id }
|
|
|
|
def create_notification_setting
|
|
setting = user.notification_settings.new(account_id: account.id)
|
|
setting.selected_email_flags = [:email_conversation_assignment]
|
|
setting.selected_push_flags = [:push_conversation_assignment]
|
|
setting.save!
|
|
end
|
|
|
|
def remove_user_from_account
|
|
::Agents::DestroyJob.perform_later(account, user)
|
|
end
|
|
|
|
def permissions
|
|
administrator? ? ['administrator'] : ['agent']
|
|
end
|
|
|
|
def push_event_data
|
|
{
|
|
id: id,
|
|
availability: availability,
|
|
role: role,
|
|
user_id: user_id
|
|
}
|
|
end
|
|
|
|
private
|
|
|
|
def notify_creation
|
|
Rails.configuration.dispatcher.dispatch(AGENT_ADDED, Time.zone.now, account: account)
|
|
end
|
|
|
|
def notify_deletion
|
|
Rails.configuration.dispatcher.dispatch(AGENT_REMOVED, Time.zone.now, account: account)
|
|
end
|
|
|
|
def update_presence_in_redis
|
|
OnlineStatusTracker.set_status(account.id, user.id, availability)
|
|
end
|
|
end
|
|
|
|
AccountUser.prepend_mod_with('AccountUser')
|
|
AccountUser.include_mod_with('Audit::AccountUser')
|
|
AccountUser.include_mod_with('Concerns::AccountUser')
|