Vishnu NarayananandGitHub
f66b551c7d
## Description Reverts [#14726](https://github.com/chatwoot/chatwoot/pull/14726) (\"feat: Add sidebar unread counts for filters (CW-7262)\"), which shipped in 4.15.0. After 4.15.0 rolled out to prod the unread-counts-for-filters code path caused a cascading incident: - `Counter#ensure_filters_cache!` fires on every `/unread_counts/index` and `update_last_seen` request. - On cache miss it calls `Builder#build_filters_for!`, which: - invokes `store.clear_user_filters!` -> `delete_matching` -> a Redis `SCAN_each` over a per-user pattern keyspace, and - runs 4 fresh SQL passes per user (mentions, participating, unattended, and per-folder `Conversations::FilterService` queries). - Threads blocked in the SCAN held their DB connections, the connection pool exhausted, Sidekiq jobs were discarded with `ActiveJob::DeserializationError: could not obtain a connection from the pool`, and the enqueued queue blew past 200K. Related: [CW-7262](https://linear.app/chatwoot/issue/CW-7262/unread-counts-for-filters-folders) ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality not to work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
63 lines
1.4 KiB
JavaScript
63 lines
1.4 KiB
JavaScript
import types from '../../../mutation-types';
|
|
import { mutations } from '../../conversationUnreadCounts';
|
|
|
|
describe('#mutations', () => {
|
|
describe('#SET_CONVERSATION_UNREAD_COUNTS', () => {
|
|
it('normalizes unread count payload', () => {
|
|
const state = { allCount: 0, inboxes: {}, labels: {}, teams: {} };
|
|
|
|
mutations[types.SET_CONVERSATION_UNREAD_COUNTS](state, {
|
|
all_count: '3',
|
|
inboxes: {
|
|
1: '2',
|
|
2: 0,
|
|
3: 'invalid',
|
|
},
|
|
labels: {
|
|
4: 5,
|
|
5: -1,
|
|
},
|
|
teams: {
|
|
6: '7',
|
|
7: 0,
|
|
},
|
|
});
|
|
|
|
expect(state).toEqual({
|
|
allCount: 3,
|
|
inboxes: { 1: 2 },
|
|
labels: { 4: 5 },
|
|
teams: { 6: 7 },
|
|
});
|
|
});
|
|
|
|
it('clears counts when payload is empty', () => {
|
|
const state = {
|
|
allCount: 2,
|
|
inboxes: { 1: 2 },
|
|
labels: { 4: 5 },
|
|
teams: { 6: 7 },
|
|
};
|
|
|
|
mutations[types.SET_CONVERSATION_UNREAD_COUNTS](state, {});
|
|
|
|
expect(state).toEqual({
|
|
allCount: 0,
|
|
inboxes: {},
|
|
labels: {},
|
|
teams: {},
|
|
});
|
|
});
|
|
|
|
it('normalizes invalid aggregate counts to zero', () => {
|
|
const state = { allCount: 2, inboxes: {}, labels: {}, teams: {} };
|
|
|
|
mutations[types.SET_CONVERSATION_UNREAD_COUNTS](state, {
|
|
all_count: 'invalid',
|
|
});
|
|
|
|
expect(state.allCount).toBe(0);
|
|
});
|
|
});
|
|
});
|