Vishnu NarayananandGitHub
f66b551c7d
## Description Reverts [#14726](https://github.com/chatwoot/chatwoot/pull/14726) (\"feat: Add sidebar unread counts for filters (CW-7262)\"), which shipped in 4.15.0. After 4.15.0 rolled out to prod the unread-counts-for-filters code path caused a cascading incident: - `Counter#ensure_filters_cache!` fires on every `/unread_counts/index` and `update_last_seen` request. - On cache miss it calls `Builder#build_filters_for!`, which: - invokes `store.clear_user_filters!` -> `delete_matching` -> a Redis `SCAN_each` over a per-user pattern keyspace, and - runs 4 fresh SQL passes per user (mentions, participating, unattended, and per-folder `Conversations::FilterService` queries). - Threads blocked in the SCAN held their DB connections, the connection pool exhausted, Sidekiq jobs were discarded with `ActiveJob::DeserializationError: could not obtain a connection from the pool`, and the enqueued queue blew past 200K. Related: [CW-7262](https://linear.app/chatwoot/issue/CW-7262/unread-counts-for-filters-folders) ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality not to work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
81 lines
1.9 KiB
JavaScript
81 lines
1.9 KiB
JavaScript
import ConversationAPI from '../../api/conversations';
|
|
import types from '../mutation-types';
|
|
|
|
export const state = {
|
|
allCount: 0,
|
|
inboxes: {},
|
|
labels: {},
|
|
teams: {},
|
|
};
|
|
|
|
const normalizeCount = count => {
|
|
const parsedCount = Number(count);
|
|
return Number.isFinite(parsedCount) && parsedCount > 0 ? parsedCount : 0;
|
|
};
|
|
|
|
const normalizeCounts = counts => {
|
|
return Object.entries(counts || {}).reduce((result, [id, count]) => {
|
|
const parsedCount = normalizeCount(count);
|
|
if (parsedCount > 0) {
|
|
result[String(id)] = parsedCount;
|
|
}
|
|
|
|
return result;
|
|
}, {});
|
|
};
|
|
|
|
export const getters = {
|
|
getAllUnreadCount($state) {
|
|
return $state.allCount;
|
|
},
|
|
getInboxUnreadCount: $state => inboxId => {
|
|
return $state.inboxes[String(inboxId)] || 0;
|
|
},
|
|
getLabelUnreadCount: $state => labelId => {
|
|
return $state.labels[String(labelId)] || 0;
|
|
},
|
|
getTeamUnreadCount: $state => teamId => {
|
|
return $state.teams[String(teamId)] || 0;
|
|
},
|
|
getInboxUnreadCounts($state) {
|
|
return $state.inboxes;
|
|
},
|
|
getLabelUnreadCounts($state) {
|
|
return $state.labels;
|
|
},
|
|
getTeamUnreadCounts($state) {
|
|
return $state.teams;
|
|
},
|
|
};
|
|
|
|
export const actions = {
|
|
get: async function getUnreadCounts({ commit }) {
|
|
try {
|
|
const response = await ConversationAPI.getUnreadCounts();
|
|
commit(types.SET_CONVERSATION_UNREAD_COUNTS, response.data.payload);
|
|
} catch (error) {
|
|
// Ignore errors so the sidebar can continue rendering without badges.
|
|
}
|
|
},
|
|
clear({ commit }) {
|
|
commit(types.SET_CONVERSATION_UNREAD_COUNTS, {});
|
|
},
|
|
};
|
|
|
|
export const mutations = {
|
|
[types.SET_CONVERSATION_UNREAD_COUNTS]($state, payload = {}) {
|
|
$state.allCount = normalizeCount(payload.all_count);
|
|
$state.inboxes = normalizeCounts(payload.inboxes);
|
|
$state.labels = normalizeCounts(payload.labels);
|
|
$state.teams = normalizeCounts(payload.teams);
|
|
},
|
|
};
|
|
|
|
export default {
|
|
namespaced: true,
|
|
state,
|
|
getters,
|
|
actions,
|
|
mutations,
|
|
};
|