Multi-agent / module-state correctness
- Hoist WhatsApp outbound init lock to module scope so header + contact-panel
buttons share one guard; add an active-session guard so a second click
returns { status: 'locked' } instead of cleanup()-ing the live call.
- isLocalWhatsappCall() filter on voice_call.outbound_connected and
voice_call.ended cable handlers — account-wide broadcasts no longer
feed foreign SDP into this tab's PeerConnection or stop its recorder.
- Permission-flow path (200 with no call id) now releases the
prepareOutboundOffer() mic + RTCPeerConnection instead of leaving the
mic indicator stuck on.
- Drop the intentionallyClosing guard around sendWhatsappTerminateBeacon
so a hangup-then-close race still terminates Meta's side (beacon
endpoint is idempotent).
- Distinguish locked init from permission_requested in callers to avoid
a false "call initiated" alert.
Provider routing
- joinCall outbound short-circuit now scoped to WhatsApp-like calls so
FloatingCallWidget's auto-join for outbound Twilio still works.
- isWhatsappLikeCall(callId-keyed) so calls seeded by message.updated /
refresh path (which lack provider metadata) route to the WhatsApp flow.
- syncConversationCallVisibility per-call filter via shouldShowCall, so
outbound calls aren't ripped from under the caller on assignee change.
- removeCallsForConversation tears down each active call via
teardownByProvider — WhatsApp gets cleanupWhatsappSession (closes pc,
stops recorder/mic) instead of a Twilio-only endClientCall.
- await reject before dismissing in rejectIncomingCall so a failing reject
keeps the call surfaced for retry.
Per-bubble overhead
- Split useCallSession into the root-mount hook + a lightweight
useCallActions for components like VoiceCall.vue that just need state +
actions without registering global window/Twilio listeners. Globals
attach once via a refcount, dismissed-call sids live at module scope so
the seed watcher can't re-add a locally dismissed ringing call.
Lookup correctness
- /contacts/:id/conversations accepts an optional inbox_id filter; the
WhatsApp call button passes inboxId so a contact's older WhatsApp
thread doesn't fall outside the BE's 20-row cap.
Twilio lifecycle / security
- Defer accepted_by_agent claim to the participant-join webhook so a
failed agent device init doesn't leave the call ringing-but-claimed
with no recovery path. mark_agent_joined still raises 409 if another
agent has already claimed.
- Verify X-Twilio-Signature on recording_status — the controller fetches
the recording with channel auth credentials, so an unsigned POST
could coerce credential-bearing requests to an attacker-controlled host.
Legacy data
- Migration to delete orphaned inboxes whose channel_type still says
'Channel::Voice' after the model was removed. The polymorphic
belongs_to :channel lookup on those rows otherwise crashes the inbox
serializer with `uninitialized constant Channel::Voice`.
98 lines
3.1 KiB
JavaScript
98 lines
3.1 KiB
JavaScript
import { defineStore } from 'pinia';
|
|
import TwilioVoiceClient from 'dashboard/api/channel/voice/twilioVoiceClient';
|
|
import { cleanupWhatsappSession } from 'dashboard/composables/useWhatsappCallSession';
|
|
import { TERMINAL_STATUSES } from 'dashboard/helper/voice';
|
|
|
|
const teardownByProvider = call => {
|
|
if (call?.provider === 'whatsapp') {
|
|
cleanupWhatsappSession();
|
|
} else {
|
|
TwilioVoiceClient.endClientCall();
|
|
}
|
|
};
|
|
|
|
export const useCallsStore = defineStore('calls', {
|
|
state: () => ({
|
|
calls: [],
|
|
}),
|
|
|
|
getters: {
|
|
activeCall: state => state.calls.find(call => call.isActive) || null,
|
|
hasActiveCall: state => state.calls.some(call => call.isActive),
|
|
incomingCalls: state => state.calls.filter(call => !call.isActive),
|
|
hasIncomingCall: state => state.calls.some(call => !call.isActive),
|
|
},
|
|
|
|
actions: {
|
|
handleCallStatusChanged({ callSid, status }) {
|
|
if (!TERMINAL_STATUSES.includes(status)) return;
|
|
|
|
const call = this.calls.find(c => c.callSid === callSid);
|
|
// WhatsApp recordings live in the in-memory recorder until voice_call.ended
|
|
// uploads them; tearing down here would race-wipe those chunks.
|
|
if (call?.provider === 'whatsapp') {
|
|
this.calls = this.calls.filter(c => c.callSid !== callSid);
|
|
return;
|
|
}
|
|
|
|
this.removeCall(callSid);
|
|
},
|
|
|
|
addCall(callData) {
|
|
if (!callData?.callSid) return;
|
|
const existing = this.calls.find(c => c.callSid === callData.callSid);
|
|
if (existing) {
|
|
// Merge so a later cable event with sdp_offer/provider/caller fills in
|
|
// gaps left by the earlier message.created path (and vice versa).
|
|
Object.assign(existing, callData, { isActive: existing.isActive });
|
|
return;
|
|
}
|
|
|
|
this.calls.push({
|
|
...callData,
|
|
isActive: false,
|
|
});
|
|
},
|
|
|
|
removeCall(callSid) {
|
|
const callToRemove = this.calls.find(c => c.callSid === callSid);
|
|
if (callToRemove?.isActive) {
|
|
teardownByProvider(callToRemove);
|
|
}
|
|
this.calls = this.calls.filter(c => c.callSid !== callSid);
|
|
},
|
|
|
|
setCallActive(callSid) {
|
|
this.calls = this.calls.map(call => ({
|
|
...call,
|
|
isActive: call.callSid === callSid,
|
|
}));
|
|
},
|
|
|
|
clearActiveCall() {
|
|
const active = this.calls.find(c => c.isActive);
|
|
teardownByProvider(active);
|
|
this.calls = this.calls.filter(call => !call.isActive);
|
|
},
|
|
|
|
dismissCall(callSid) {
|
|
this.calls = this.calls.filter(call => call.callSid !== callSid);
|
|
},
|
|
|
|
removeCallsForConversation(conversationId) {
|
|
const callsToRemove = this.calls.filter(
|
|
call => call.conversationId === conversationId
|
|
);
|
|
|
|
// Tear down each active call via its own provider so a WhatsApp call
|
|
// gets cleanupWhatsappSession() (closes pc, stops recorder/mic) instead
|
|
// of the Twilio-only endClientCall() — otherwise mic stays open.
|
|
callsToRemove.filter(call => call.isActive).forEach(teardownByProvider);
|
|
|
|
this.calls = this.calls.filter(
|
|
call => call.conversationId !== conversationId
|
|
);
|
|
},
|
|
},
|
|
});
|