Sony MathewandGitHub
88e2661ca6
## Description Make conversation unread counts always available at runtime by removing account feature checks from the API endpoint, unread-count listener, notifier, and ActionCable broadcast path. Update the dashboard to fetch sidebar unread counts for the active account without checking FEATURE_FLAGS.CONVERSATION_UNREAD_COUNTS, and remove the now-unused store clear action that only supported the disabled state. Keep the feature entry in config/features.yml to preserve flag bit order, but mark it enabled and deprecated so fresh installs default to the always-on behavior while feature-management UI hides it. Leave existing installation default rows untouched; no migration is included, so upgraded installs may still store the old flag value but runtime behavior no longer depends on it. Update specs around the new always-on contract and remove obsolete disabled-feature assertions. Fixes # CW-7237 ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality not to work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? Update specs around the new always-on contract and remove obsolete disabled-feature assertions. Ran specs locally for the changes. ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
68 lines
1.6 KiB
JavaScript
68 lines
1.6 KiB
JavaScript
import ConversationAPI from '../../api/conversations';
|
|
import types from '../mutation-types';
|
|
|
|
export const state = {
|
|
inboxes: {},
|
|
labels: {},
|
|
teams: {},
|
|
};
|
|
|
|
const normalizeCounts = counts => {
|
|
return Object.entries(counts || {}).reduce((result, [id, count]) => {
|
|
const parsedCount = Number(count);
|
|
if (Number.isFinite(parsedCount) && parsedCount > 0) {
|
|
result[String(id)] = parsedCount;
|
|
}
|
|
|
|
return result;
|
|
}, {});
|
|
};
|
|
|
|
export const getters = {
|
|
getInboxUnreadCount: $state => inboxId => {
|
|
return $state.inboxes[String(inboxId)] || 0;
|
|
},
|
|
getLabelUnreadCount: $state => labelId => {
|
|
return $state.labels[String(labelId)] || 0;
|
|
},
|
|
getTeamUnreadCount: $state => teamId => {
|
|
return $state.teams[String(teamId)] || 0;
|
|
},
|
|
getInboxUnreadCounts($state) {
|
|
return $state.inboxes;
|
|
},
|
|
getLabelUnreadCounts($state) {
|
|
return $state.labels;
|
|
},
|
|
getTeamUnreadCounts($state) {
|
|
return $state.teams;
|
|
},
|
|
};
|
|
|
|
export const actions = {
|
|
get: async function getUnreadCounts({ commit }) {
|
|
try {
|
|
const response = await ConversationAPI.getUnreadCounts();
|
|
commit(types.SET_CONVERSATION_UNREAD_COUNTS, response.data.payload);
|
|
} catch (error) {
|
|
// Ignore errors so the sidebar can continue rendering without badges.
|
|
}
|
|
},
|
|
};
|
|
|
|
export const mutations = {
|
|
[types.SET_CONVERSATION_UNREAD_COUNTS]($state, payload = {}) {
|
|
$state.inboxes = normalizeCounts(payload.inboxes);
|
|
$state.labels = normalizeCounts(payload.labels);
|
|
$state.teams = normalizeCounts(payload.teams);
|
|
},
|
|
};
|
|
|
|
export default {
|
|
namespaced: true,
|
|
state,
|
|
getters,
|
|
actions,
|
|
mutations,
|
|
};
|