# Pull Request Template ## Description Adds a Contact condition to the conversation advanced filter so agents can search for an existing contact and filter conversations by `conversations.contact_id`. Fixes [CW-7239](https://linear.app/chatwoot/issue/CW-7239/contact-filter-for-conversations) ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality not to work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? - `eval "$(rbenv init -)" && bundle exec rspec spec/services/conversations/filter_service_spec.rb` - `pnpm exec vitest --no-watch --no-cache --no-coverage --logHeapUsage app/javascript/dashboard/components-next/filter/helper/filterHelper.spec.js app/javascript/dashboard/store/modules/conversations/helpers/specs/filterHelpers.spec.js app/javascript/dashboard/helper/specs/customViewsHelper.spec.js app/javascript/dashboard/helper/specs/filterQueryGenerator.spec.js` - `pnpm eslint` - `eval "$(rbenv init -)" && bundle exec rubocop spec/services/conversations/filter_service_spec.rb` ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: iamsivin <iamsivin@gmail.com> Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com>
63 lines
1.5 KiB
JavaScript
63 lines
1.5 KiB
JavaScript
import { getters } from '../../customViews';
|
|
import { contactFilterView, contactViewList, customViewList } from './fixtures';
|
|
|
|
describe('#getters', () => {
|
|
it('getCustomViewsByFilterType', () => {
|
|
const state = { contact: { records: contactViewList } };
|
|
expect(getters.getCustomViewsByFilterType(state)(1)).toEqual([
|
|
{
|
|
name: 'Custom view 1',
|
|
filter_type: 1,
|
|
query: {
|
|
payload: [
|
|
{
|
|
attribute_key: 'name',
|
|
filter_operator: 'equal_to',
|
|
values: ['john doe'],
|
|
query_operator: null,
|
|
},
|
|
],
|
|
},
|
|
},
|
|
]);
|
|
});
|
|
|
|
it('getUIFlags', () => {
|
|
const state = {
|
|
uiFlags: {
|
|
isFetching: true,
|
|
isCreating: false,
|
|
isDeleting: false,
|
|
},
|
|
};
|
|
expect(getters.getUIFlags(state)).toEqual({
|
|
isFetching: true,
|
|
isCreating: false,
|
|
isDeleting: false,
|
|
});
|
|
});
|
|
|
|
it('getActiveConversationFolder', () => {
|
|
const state = { activeConversationFolder: customViewList[0] };
|
|
expect(getters.getActiveConversationFolder(state)).toEqual(
|
|
customViewList[0]
|
|
);
|
|
});
|
|
|
|
it('getActiveFolderContactId', () => {
|
|
expect(
|
|
getters.getActiveFolderContactId({
|
|
activeConversationFolder: contactFilterView,
|
|
})
|
|
).toEqual(42);
|
|
});
|
|
|
|
it('getActiveFolderContactId returns undefined without a contact filter', () => {
|
|
expect(
|
|
getters.getActiveFolderContactId({
|
|
activeConversationFolder: customViewList[0],
|
|
})
|
|
).toBeUndefined();
|
|
});
|
|
});
|