Adds the server-side flow that turns Meta WhatsApp Cloud Calling webhooks into Chatwoot Calls, conversations, voice_call message bubbles, and ActionCable broadcasts. Stacked on top of #14312 (PR-2 — provider methods); intentionally does not include the HTTP controller, routes, or frontend (those land in PR-4 and PR-9). ## Closes - Part of the WhatsApp Cloud Calling rollout. Linear: TBD ## What changed **Webhook routing** - `app/jobs/webhooks/whatsapp_events_job.rb` — append `prepend_mod_with('Webhooks::WhatsappEventsJob')` so EE can extend it without forking. - `enterprise/app/jobs/enterprise/webhooks/whatsapp_events_job.rb` (new) — overlay that prepends `handle_message_events` to intercept `field: 'calls'` payloads (route to `Whatsapp::IncomingCallService`) and `interactive.call_permission_reply` messages (route to `Whatsapp::CallPermissionReplyService`); falls through with `super` for regular messages. **Services** - `enterprise/app/services/whatsapp/incoming_call_service.rb` (new) — gated on `provider_config['calling_enabled']`; processes `connect` (creates inbound call via `Voice::InboundCallBuilder` or transitions an existing outbound call to `in_progress`) and `terminate` events; updates conversation `additional_attributes` and broadcasts `voice_call.incoming`/`voice_call.outbound_connected`/`voice_call.ended`. - `enterprise/app/services/whatsapp/call_permission_reply_service.rb` (new) — handles WhatsApp interactive `call_permission_reply` replies; clears the conversation's `call_permission_requested_at` flag and broadcasts `voice_call.permission_granted` so the agent UI can re-enable the call button. **Builder/model adjustments** - `enterprise/app/services/voice/inbound_call_builder.rb` — provider-agnostic; accepts `provider:` and `extra_meta:` kwargs, drops `account:` (now derived from `inbox.account` to keep the param count under rubocop's ceiling without disabling cops), uses digits-only `source_id` for WhatsApp ContactInbox (validation requires `^\d{1,15}\z`), skips Twilio-only `conference_sid` for non-Twilio providers. - `enterprise/app/services/voice/call_message_builder.rb` — adds `create!`/`update_status!` API and `CALL_TO_VOICE_STATUS` map; uses direct `Message.create!` (bypasses `Messages::MessageBuilder`'s incoming-on-non-Api-inbox guard, which would otherwise reject the system bubble); content is `'WhatsApp Call'` for WhatsApp and `'Voice Call'` for Twilio. Backwards-compatible `perform!` retained for the existing Twilio call sites. - `enterprise/app/models/call.rb` — adds `default_ice_servers` (driven by `VOICE_CALL_STUN_URLS` env), `direction_label` alias for the `inbound`/`outbound` strings the FE expects, and `ringing?`/`in_progress?`/`terminal?` predicates used throughout the pipeline. **Outgoing-channel guard** - `app/services/base/send_on_channel_service.rb` — extends `invalid_message?` to skip messages with `content_type == 'voice_call'`. Without this, agent-initiated outbound calls (PR-4) would deliver \"WhatsApp Call\" as a text message to the contact every time. **Twilio call-site update** - `enterprise/app/controllers/twilio/voice_controller.rb` — drops the now-redundant `account: current_account` kwarg from the `Voice::InboundCallBuilder.perform!` call. **Tests** - New: `spec/enterprise/services/whatsapp/incoming_call_service_spec.rb` (5 examples — calling-disabled, inbound connect, outbound connect, terminate completed, terminate no-answer, unknown event). - New: `spec/enterprise/services/whatsapp/call_permission_reply_service_spec.rb` (3 examples — accept, reject, calling-disabled). - Updated: `spec/enterprise/services/voice/inbound_call_builder_spec.rb` and `spec/enterprise/controllers/twilio/voice_controller_spec.rb` to drop the `account:` kwarg from call expectations. ## How to test In `rails console` against an account with a WhatsApp inbox where `provider_config['calling_enabled']` is true: ```ruby inbox = Inbox.find(<id>) params = { calls: [{ id: 'wacid_test', from: '15550001111', event: 'connect', session: { sdp: 'v=0...', sdp_type: 'offer' } }] } Whatsapp::IncomingCallService.new(inbox: inbox, params: params).perform # => Conversation + Call (status: 'ringing', provider: 'whatsapp') + voice_call message bubble # => ActionCable broadcasts `voice_call.incoming` to the assignee or account-wide # Then terminate it: Whatsapp::IncomingCallService.new(inbox: inbox, params: { calls: [{ id: 'wacid_test', event: 'terminate', duration: 0, terminate_reason: 'no_answer' }] } ).perform # => Call status flips to 'no_answer', message bubble updates, `voice_call.ended` broadcast fires ``` End-to-end browser flow (Meta → cable → UI) requires the controller from PR-4 and the frontend from PR-9. --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
150 lines
4.8 KiB
Ruby
150 lines
4.8 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
RSpec.describe 'Twilio::VoiceController', type: :request do
|
|
let(:account) { create(:account) }
|
|
let(:channel) { create(:channel_twilio_sms, :with_voice, account: account, phone_number: '+15551230003') }
|
|
let(:inbox) { channel.inbox }
|
|
let(:digits) { channel.phone_number.delete_prefix('+') }
|
|
|
|
before do
|
|
allow(Twilio::VoiceWebhookSetupService).to receive(:new)
|
|
.and_return(instance_double(Twilio::VoiceWebhookSetupService, perform: "AP#{SecureRandom.hex(16)}"))
|
|
end
|
|
|
|
describe 'POST /twilio/voice/call/:phone' do
|
|
let(:call_sid) { 'CA_test_call_sid_123' }
|
|
let(:from_number) { '+15550003333' }
|
|
let(:to_number) { channel.phone_number }
|
|
|
|
it 'invokes Voice::InboundCallBuilder for inbound calls and renders conference TwiML' do
|
|
conversation = create(:conversation, account: account, inbox: inbox)
|
|
contact = conversation.contact
|
|
call = create(
|
|
:call,
|
|
account: account,
|
|
inbox: inbox,
|
|
conversation: conversation,
|
|
contact: contact,
|
|
provider_call_id: call_sid
|
|
)
|
|
call.update!(conference_sid: call.default_conference_sid)
|
|
|
|
expect(Voice::InboundCallBuilder).to receive(:perform!).with(
|
|
inbox: inbox,
|
|
from_number: from_number,
|
|
call_sid: call_sid
|
|
).and_return(call)
|
|
|
|
post "/twilio/voice/call/#{digits}", params: {
|
|
'CallSid' => call_sid,
|
|
'From' => from_number,
|
|
'To' => to_number,
|
|
'Direction' => 'inbound'
|
|
}
|
|
|
|
expect(response).to have_http_status(:ok)
|
|
expect(response.body).to include('<Response>')
|
|
expect(response.body).to include('<Dial>')
|
|
expect(response.body).to include(call.conference_sid)
|
|
end
|
|
|
|
it 'looks up the Call when Twilio sends the outbound-api PSTN leg' do
|
|
conversation = create(:conversation, account: account, inbox: inbox)
|
|
call = create(
|
|
:call,
|
|
account: account,
|
|
inbox: inbox,
|
|
conversation: conversation,
|
|
contact: conversation.contact,
|
|
direction: :outgoing,
|
|
provider_call_id: call_sid
|
|
)
|
|
call.update!(conference_sid: call.default_conference_sid)
|
|
|
|
post "/twilio/voice/call/#{digits}", params: {
|
|
'CallSid' => call_sid,
|
|
'From' => to_number,
|
|
'To' => from_number,
|
|
'Direction' => 'outbound-api'
|
|
}
|
|
|
|
expect(response).to have_http_status(:ok)
|
|
expect(response.body).to include(call.conference_sid)
|
|
expect(call.reload.parent_call_sid).to be_nil
|
|
end
|
|
|
|
it 'records the parent call SID when syncing outbound-dial legs' do
|
|
parent_sid = 'CA_parent'
|
|
child_sid = 'CA_child'
|
|
conversation = create(:conversation, account: account, inbox: inbox)
|
|
call = create(
|
|
:call,
|
|
account: account,
|
|
inbox: inbox,
|
|
conversation: conversation,
|
|
contact: conversation.contact,
|
|
direction: :outgoing,
|
|
provider_call_id: parent_sid
|
|
)
|
|
call.update!(conference_sid: call.default_conference_sid)
|
|
|
|
post "/twilio/voice/call/#{digits}", params: {
|
|
'CallSid' => child_sid,
|
|
'ParentCallSid' => parent_sid,
|
|
'From' => to_number,
|
|
'To' => from_number,
|
|
'Direction' => 'outbound-dial'
|
|
}
|
|
|
|
expect(response).to have_http_status(:ok)
|
|
expect(call.reload.parent_call_sid).to eq(parent_sid)
|
|
end
|
|
|
|
it 'raises not found when inbox is not present' do
|
|
expect(Voice::InboundCallBuilder).not_to receive(:perform!)
|
|
post '/twilio/voice/call/19998887777', params: {
|
|
'CallSid' => call_sid,
|
|
'From' => from_number,
|
|
'To' => to_number,
|
|
'Direction' => 'inbound'
|
|
}
|
|
expect(response).to have_http_status(:not_found)
|
|
end
|
|
end
|
|
|
|
describe 'POST /twilio/voice/status/:phone' do
|
|
let(:call_sid) { 'CA_status_sid_456' }
|
|
|
|
it 'invokes Voice::StatusUpdateService with expected params' do
|
|
service_double = instance_double(Voice::StatusUpdateService, perform: nil)
|
|
expect(Voice::StatusUpdateService).to receive(:new).with(
|
|
hash_including(
|
|
account: account,
|
|
call_sid: call_sid,
|
|
call_status: 'completed',
|
|
payload: hash_including('CallSid' => call_sid, 'CallStatus' => 'completed')
|
|
)
|
|
).and_return(service_double)
|
|
expect(service_double).to receive(:perform)
|
|
|
|
post "/twilio/voice/status/#{digits}", params: {
|
|
'CallSid' => call_sid,
|
|
'CallStatus' => 'completed'
|
|
}
|
|
|
|
expect(response).to have_http_status(:no_content)
|
|
end
|
|
|
|
it 'raises not found when inbox is not present' do
|
|
expect(Voice::StatusUpdateService).not_to receive(:new)
|
|
post '/twilio/voice/status/18005550101', params: {
|
|
'CallSid' => call_sid,
|
|
'CallStatus' => 'busy'
|
|
}
|
|
expect(response).to have_http_status(:not_found)
|
|
end
|
|
end
|
|
end
|