0e122188e9
Voice calling is now a capability on the existing TwilioSms rather than a separate Voice model. A single Twilio phone number handles both SMS and voice calls through one inbox. Fixes https://linear.app/chatwoot/issue/CW-6683/add-voice-calling-as-a-capability-on-twilio-sms-channel and https://linear.app/chatwoot/issue/PLA-120/add-the-support-for-sms **What changed** - Replaced Channel::Voice with voice_enabled flag on Channel::TwilioSms - Added voice_enabled, twiml_app_sid, api_key_secret columns to channel_twilio_sms table - Dropped channel_voice table (no production data) - All voice logic lives in Enterprise layer via prepend_mod_with('Channel::TwilioSms') - Added Voice settings tab on Twilio SMS inbox settings to enable/disable voice - Validates Twilio number voice capability before provisioning - Teardown service cleans up TwiML app and credentials when voice is disabled - Frontend voice detection uses isVoiceCallEnabled() / getVoiceCallProvider() helpers — extensible to future providers - Gated by channel_voice feature flag **How to test** 1. Enable feature flag: Account.find(<id>).enable_features('channel_voice') 2. Create voice inbox: Inboxes → Voice tile → enter Twilio credentials → verify incoming/outgoing calls and SMS work 3. Enable voice on existing SMS inbox: Inboxes → select Twilio SMS inbox → Voice tab → toggle on → provide API key credentials → verify calls work 4. Disable voice: Voice tab → toggle off → verify TwiML app is deleted, credentials cleared, SMS still works 5. Re-enable voice: Toggle on again → must provide api_key_secret again → new TwiML app provisioned --------- Co-authored-by: Muhsin <12408980+muhsin-k@users.noreply.github.com>
98 lines
3.2 KiB
Ruby
98 lines
3.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
RSpec.describe Voice::OutboundCallBuilder do
|
|
let(:account) { create(:account) }
|
|
let(:channel) { create(:channel_twilio_sms, :with_voice, account: account, phone_number: '+15551230000') }
|
|
let(:inbox) { channel.inbox }
|
|
let(:user) { create(:user, account: account) }
|
|
let(:contact) { create(:contact, account: account, phone_number: '+15550001111') }
|
|
let(:call_sid) { 'CA1234567890abcdef' }
|
|
|
|
before do
|
|
allow(Twilio::VoiceWebhookSetupService).to receive(:new)
|
|
.and_return(instance_double(Twilio::VoiceWebhookSetupService, perform: "AP#{SecureRandom.hex(8)}"))
|
|
allow(inbox).to receive(:channel).and_return(channel)
|
|
allow(channel).to receive(:initiate_call).and_return({ call_sid: call_sid })
|
|
allow(Voice::Conference::Name).to receive(:for).and_call_original
|
|
end
|
|
|
|
describe '.perform!' do
|
|
it 'creates a conversation and voice call message' do
|
|
conversation_count = account.conversations.count
|
|
inbox_link_count = contact.contact_inboxes.where(inbox_id: inbox.id).count
|
|
|
|
result = described_class.perform!(
|
|
account: account,
|
|
inbox: inbox,
|
|
user: user,
|
|
contact: contact
|
|
)
|
|
|
|
expect(account.conversations.count).to eq(conversation_count + 1)
|
|
expect(contact.contact_inboxes.where(inbox_id: inbox.id).count).to eq(inbox_link_count + 1)
|
|
|
|
conversation = result[:conversation].reload
|
|
attrs = conversation.additional_attributes
|
|
|
|
aggregate_failures do
|
|
expect(result[:call_sid]).to eq(call_sid)
|
|
expect(conversation.identifier).to eq(call_sid)
|
|
expect(attrs).to include('call_direction' => 'outbound', 'call_status' => 'ringing')
|
|
expect(attrs['agent_id']).to eq(user.id)
|
|
expect(attrs['conference_sid']).to be_present
|
|
|
|
voice_message = conversation.messages.voice_calls.last
|
|
expect(voice_message.message_type).to eq('outgoing')
|
|
|
|
message_data = voice_message.content_attributes['data']
|
|
expect(message_data).to include(
|
|
'call_sid' => call_sid,
|
|
'conference_sid' => attrs['conference_sid'],
|
|
'from_number' => channel.phone_number,
|
|
'to_number' => contact.phone_number
|
|
)
|
|
end
|
|
end
|
|
|
|
it 'raises an error when contact is missing a phone number' do
|
|
contact.update!(phone_number: nil)
|
|
|
|
expect do
|
|
described_class.perform!(
|
|
account: account,
|
|
inbox: inbox,
|
|
user: user,
|
|
contact: contact
|
|
)
|
|
end.to raise_error(ArgumentError, 'Contact phone number required')
|
|
end
|
|
|
|
it 'raises an error when user is nil' do
|
|
expect do
|
|
described_class.perform!(
|
|
account: account,
|
|
inbox: inbox,
|
|
user: nil,
|
|
contact: contact
|
|
)
|
|
end.to raise_error(ArgumentError, 'Agent required')
|
|
end
|
|
|
|
it 'ensures the conversation has a display_id before building the conference SID' do
|
|
allow(Voice::Conference::Name).to receive(:for).and_wrap_original do |original, conversation|
|
|
expect(conversation.display_id).to be_present
|
|
original.call(conversation)
|
|
end
|
|
|
|
described_class.perform!(
|
|
account: account,
|
|
inbox: inbox,
|
|
user: user,
|
|
contact: contact
|
|
)
|
|
end
|
|
end
|
|
end
|