Sony MathewandGitHub
66cfb26c77
## Description Adds the account-level `unread_count_for_filters` feature flag as the dark-launch gate for filtered sidebar unread counts. This reuses the deprecated `quoted_email_reply` flag slot, resets the reused bit for existing accounts, and removes stale defaults so new accounts do not reference the old flag. This also adds the feature where we are now calculating the unread counts for built in filters like mentions, participating and unattended along with unread count for saved filters/folders. Closes [CW-7262](https://linear.app/chatwoot/issue/CW-7262/unread-counts-for-filters-folders) ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality not to work as expected) - [ ] This change requires a documentation update
116 lines
3.8 KiB
Ruby
116 lines
3.8 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe Labels::DestroyService do
|
|
let(:account) { create(:account) }
|
|
let(:conversation) { create(:conversation, account: account) }
|
|
let(:label) { create(:label, account: account) }
|
|
let(:contact) { conversation.contact }
|
|
let(:label_deleted_at) { Time.zone.parse('2026-05-07 10:00:00 UTC') }
|
|
let(:store) { Conversations::UnreadCounts::FilteredCountStore }
|
|
|
|
before do
|
|
conversation.label_list.add(label.title)
|
|
conversation.label_list.add('billing')
|
|
conversation.save!
|
|
|
|
contact.label_list.add(label.title)
|
|
contact.label_list.add('vip')
|
|
contact.save!
|
|
|
|
set_label_tagging_created_at(conversation, label_deleted_at - 1.minute)
|
|
set_label_tagging_created_at(contact, label_deleted_at - 1.minute)
|
|
end
|
|
|
|
describe '#perform' do
|
|
it 'removes label from associated conversations and contacts' do
|
|
described_class.new(
|
|
label_title: label.title,
|
|
account_id: account.id,
|
|
label_deleted_at: label_deleted_at
|
|
).perform
|
|
|
|
expect(conversation.reload.label_list).to eq(['billing'])
|
|
expect(conversation.cached_label_list).to eq('billing')
|
|
expect(contact.reload.label_list).to eq(['vip'])
|
|
end
|
|
|
|
it 'removes label associations after the label record is destroyed' do
|
|
label_title = label.title
|
|
label.destroy!
|
|
|
|
described_class.new(
|
|
label_title: label_title,
|
|
account_id: account.id,
|
|
label_deleted_at: label_deleted_at
|
|
).perform
|
|
|
|
expect(conversation.reload.label_list).to eq(['billing'])
|
|
expect(conversation.cached_label_list).to eq('billing')
|
|
expect(contact.reload.label_list).to eq(['vip'])
|
|
end
|
|
|
|
it 'does not remove labels from other accounts' do
|
|
other_account = create(:account)
|
|
other_conversation = create(:conversation, account: other_account)
|
|
other_conversation.label_list.add(label.title)
|
|
other_conversation.save!
|
|
set_label_tagging_created_at(other_conversation, label_deleted_at - 1.minute)
|
|
|
|
described_class.new(
|
|
label_title: label.title,
|
|
account_id: account.id,
|
|
label_deleted_at: label_deleted_at
|
|
).perform
|
|
|
|
expect(other_conversation.reload.label_list).to eq([label.title])
|
|
end
|
|
|
|
it 'does not dispatch conversation or contact update events' do
|
|
expect(Rails.configuration.dispatcher).not_to receive(:dispatch)
|
|
|
|
described_class.new(
|
|
label_title: label.title,
|
|
account_id: account.id,
|
|
label_deleted_at: label_deleted_at
|
|
).perform
|
|
end
|
|
|
|
it 'invalidates filtered counts when conversation label associations are removed' do
|
|
account.enable_features!(:unread_count_for_filters)
|
|
|
|
expect do
|
|
described_class.new(
|
|
label_title: label.title,
|
|
account_id: account.id,
|
|
label_deleted_at: label_deleted_at
|
|
).perform
|
|
end.to change { store.conversation_version(account.id) }.by(1)
|
|
end
|
|
|
|
it 'does not remove label associations created after the label was deleted' do
|
|
other_conversation = create(:conversation, account: account)
|
|
other_conversation.label_list.add(label.title)
|
|
other_conversation.save!
|
|
set_label_tagging_created_at(other_conversation, label_deleted_at + 1.minute)
|
|
|
|
described_class.new(
|
|
label_title: label.title,
|
|
account_id: account.id,
|
|
label_deleted_at: label_deleted_at
|
|
).perform
|
|
|
|
expect(conversation.reload.label_list).to eq(['billing'])
|
|
expect(conversation.cached_label_list).to eq('billing')
|
|
expect(contact.reload.label_list).to eq(['vip'])
|
|
expect(other_conversation.reload.label_list).to eq([label.title])
|
|
end
|
|
end
|
|
|
|
def set_label_tagging_created_at(record, created_at)
|
|
ActsAsTaggableOn::Tagging
|
|
.joins(:tag)
|
|
.find_by!(context: 'labels', taggable: record, tags: { name: label.title })
|
|
.update!(created_at: created_at)
|
|
end
|
|
end
|