Vishnu NarayananandGitHub
f66b551c7d
## Description Reverts [#14726](https://github.com/chatwoot/chatwoot/pull/14726) (\"feat: Add sidebar unread counts for filters (CW-7262)\"), which shipped in 4.15.0. After 4.15.0 rolled out to prod the unread-counts-for-filters code path caused a cascading incident: - `Counter#ensure_filters_cache!` fires on every `/unread_counts/index` and `update_last_seen` request. - On cache miss it calls `Builder#build_filters_for!`, which: - invokes `store.clear_user_filters!` -> `delete_matching` -> a Redis `SCAN_each` over a per-user pattern keyspace, and - runs 4 fresh SQL passes per user (mentions, participating, unattended, and per-folder `Conversations::FilterService` queries). - Threads blocked in the SCAN held their DB connections, the connection pool exhausted, Sidekiq jobs were discarded with `ActiveJob::DeserializationError: could not obtain a connection from the pool`, and the enqueued queue blew past 200K. Related: [CW-7262](https://linear.app/chatwoot/issue/CW-7262/unread-counts-for-filters-folders) ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality not to work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
94 lines
4.0 KiB
Ruby
94 lines
4.0 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe Conversations::UnreadCounts::Builder do
|
|
let(:account) { create(:account) }
|
|
let(:inbox) { create(:inbox, account: account) }
|
|
let(:label) { create(:label, account: account, title: 'urgent', show_on_sidebar: true) }
|
|
let(:assignee) { create(:user, account: account, role: :agent) }
|
|
let(:team) { create(:team, account: account, allow_auto_assign: false) }
|
|
let(:store) { Conversations::UnreadCounts::Store }
|
|
|
|
after do
|
|
store.clear_account!(account.id)
|
|
end
|
|
|
|
describe '#build_base!' do
|
|
it 'stores unread open conversations by inbox and label inbox' do
|
|
unread_conversation = create_unread_conversation(account: account, inbox: inbox, labels: [label.title], team: team)
|
|
create_read_conversation
|
|
create_resolved_unread_conversation
|
|
|
|
described_class.new(account).build_base!
|
|
|
|
expect(store.base_ready?(account.id)).to be(true)
|
|
expect(redis_set_members(store.inbox_key(account.id, inbox.id))).to contain_exactly(unread_conversation.id.to_s)
|
|
expect(redis_set_members(store.label_inbox_key(account.id, label.id, inbox.id))).to contain_exactly(unread_conversation.id.to_s)
|
|
expect(redis_set_members(store.team_inbox_key(account.id, team.id, inbox.id))).to contain_exactly(unread_conversation.id.to_s)
|
|
end
|
|
|
|
it 'clears assignment-aware cache data before rebuilding base data' do
|
|
assigned_conversation = create_unread_conversation(
|
|
account: account,
|
|
inbox: inbox,
|
|
labels: [label.title],
|
|
assignee: assignee,
|
|
team: team
|
|
)
|
|
|
|
described_class.new(account).build_assignment!
|
|
described_class.new(account).build_base!
|
|
|
|
expect(store.assignment_ready?(account.id)).to be(false)
|
|
expect(redis_set_members(store.inbox_assignee_key(account.id, inbox.id, assignee.id))).to be_empty
|
|
expect(redis_set_members(store.inbox_key(account.id, inbox.id))).to contain_exactly(assigned_conversation.id.to_s)
|
|
end
|
|
end
|
|
|
|
describe '#build_assignment!' do
|
|
it 'stores unread open conversations by unassigned and assignee dimensions' do
|
|
assigned_conversation = create_unread_conversation(
|
|
account: account,
|
|
inbox: inbox,
|
|
labels: [label.title],
|
|
assignee: assignee,
|
|
team: team
|
|
)
|
|
unassigned_conversation = create_unread_conversation(account: account, inbox: inbox, labels: [label.title], team: team)
|
|
|
|
described_class.new(account).build_assignment!
|
|
|
|
expect(store.assignment_ready?(account.id)).to be(true)
|
|
expect(redis_set_members(store.inbox_assignee_key(account.id, inbox.id, assignee.id))).to contain_exactly(assigned_conversation.id.to_s)
|
|
expect(redis_set_members(store.label_inbox_assignee_key(account.id, label.id, inbox.id, assignee.id))).to contain_exactly(
|
|
assigned_conversation.id.to_s
|
|
)
|
|
expect(redis_set_members(store.team_inbox_assignee_key(account.id, team.id, inbox.id, assignee.id))).to contain_exactly(
|
|
assigned_conversation.id.to_s
|
|
)
|
|
expect(redis_set_members(store.inbox_unassigned_key(account.id, inbox.id))).to contain_exactly(unassigned_conversation.id.to_s)
|
|
expect(redis_set_members(store.label_inbox_unassigned_key(account.id, label.id, inbox.id))).to contain_exactly(
|
|
unassigned_conversation.id.to_s
|
|
)
|
|
expect(redis_set_members(store.team_inbox_unassigned_key(account.id, team.id, inbox.id))).to contain_exactly(
|
|
unassigned_conversation.id.to_s
|
|
)
|
|
end
|
|
end
|
|
|
|
def create_read_conversation
|
|
conversation = create(:conversation, account: account, inbox: inbox, agent_last_seen_at: 1.minute.from_now)
|
|
create(:message, account: account, inbox: inbox, conversation: conversation, message_type: :incoming)
|
|
conversation
|
|
end
|
|
|
|
def create_resolved_unread_conversation
|
|
conversation = create_unread_conversation(account: account, inbox: inbox)
|
|
conversation.update!(status: :resolved)
|
|
conversation
|
|
end
|
|
|
|
def redis_set_members(key)
|
|
Redis::Alfred.pipelined { |pipeline| pipeline.smembers(key) }.first
|
|
end
|
|
end
|