# Pull Request Template ## Description defaults new accounts to captain v2 ## Type of change - [x] New feature (non-breaking change which adds functionality) ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. locally and specs ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] Any dependent changes have been merged and published in downstream modules
126 lines
4.2 KiB
Ruby
126 lines
4.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
RSpec.describe CaptainFeaturable do
|
|
let(:account) { create(:account) }
|
|
|
|
describe 'dynamic method generation' do
|
|
it 'generates enabled? methods for all features' do
|
|
Llm::Models.feature_keys.each do |feature_key|
|
|
expect(account).to respond_to("captain_#{feature_key}_enabled?")
|
|
end
|
|
end
|
|
|
|
it 'generates model accessor methods for all features' do
|
|
Llm::Models.feature_keys.each do |feature_key|
|
|
expect(account).to respond_to("captain_#{feature_key}_model")
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'feature enabled methods' do
|
|
context 'when no features are explicitly enabled' do
|
|
it 'returns false for all features' do
|
|
Llm::Models.feature_keys.each do |feature_key|
|
|
expect(account.send("captain_#{feature_key}_enabled?")).to be false
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when features are explicitly enabled' do
|
|
before do
|
|
account.update!(captain_features: { 'editor' => true, 'assistant' => true })
|
|
end
|
|
|
|
it 'returns true for enabled features' do
|
|
expect(account.captain_editor_enabled?).to be true
|
|
expect(account.captain_assistant_enabled?).to be true
|
|
end
|
|
|
|
it 'returns false for disabled features' do
|
|
expect(account.captain_copilot_enabled?).to be false
|
|
expect(account.captain_label_suggestion_enabled?).to be false
|
|
end
|
|
end
|
|
|
|
context 'when captain_features is nil' do
|
|
before do
|
|
account.update!(captain_features: nil)
|
|
end
|
|
|
|
it 'returns false for all features' do
|
|
Llm::Models.feature_keys.each do |feature_key|
|
|
expect(account.send("captain_#{feature_key}_enabled?")).to be false
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'model accessor methods' do
|
|
context 'when models are explicitly configured' do
|
|
before do
|
|
account.update!(captain_models: {
|
|
'editor' => 'gpt-4.1-mini',
|
|
'assistant' => 'gpt-5.1',
|
|
'label_suggestion' => 'gpt-4.1-nano'
|
|
})
|
|
end
|
|
|
|
it 'returns configured models for configured features' do
|
|
expect(account.captain_editor_model).to eq('gpt-4.1-mini')
|
|
expect(account.captain_assistant_model).to eq('gpt-5.1')
|
|
expect(account.captain_label_suggestion_model).to eq('gpt-4.1-nano')
|
|
end
|
|
|
|
it 'returns default models for unconfigured features' do
|
|
expect(account.captain_copilot_model).to eq(Llm::Models.default_model_for('copilot'))
|
|
expect(account.captain_audio_transcription_model).to eq(Llm::Models.default_model_for('audio_transcription'))
|
|
end
|
|
end
|
|
|
|
context 'when configured with invalid model' do
|
|
before do
|
|
account.captain_models = { 'editor' => 'invalid-model' }
|
|
end
|
|
|
|
it 'falls back to default model' do
|
|
expect(account.captain_editor_model).to eq(Llm::Models.default_model_for('editor'))
|
|
end
|
|
end
|
|
|
|
context 'when captain_models is nil' do
|
|
before do
|
|
account.update!(captain_models: nil)
|
|
end
|
|
|
|
it 'returns default models for all features' do
|
|
Llm::Models.feature_keys.each do |feature_key|
|
|
expected_default = Llm::Models.default_model_for(feature_key)
|
|
expect(account.send("captain_#{feature_key}_model")).to eq(expected_default)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'integration with existing captain_preferences' do
|
|
it 'enabled? methods use the same logic as captain_preferences[:features]' do
|
|
account.update!(captain_features: { 'editor' => true, 'copilot' => true })
|
|
prefs = account.captain_preferences
|
|
|
|
Llm::Models.feature_keys.each do |feature_key|
|
|
expect(account.send("captain_#{feature_key}_enabled?")).to eq(prefs[:features][feature_key])
|
|
end
|
|
end
|
|
|
|
it 'model methods use the same logic as captain_preferences[:models]' do
|
|
account.update!(captain_models: { 'editor' => 'gpt-4.1-mini', 'assistant' => 'gpt-5.2' })
|
|
prefs = account.captain_preferences
|
|
|
|
Llm::Models.feature_keys.each do |feature_key|
|
|
expect(account.send("captain_#{feature_key}_model")).to eq(prefs[:models][feature_key])
|
|
end
|
|
end
|
|
end
|
|
end
|