3253e863ed
# Pull Request Template ## Description - Validates openai key while configuring hooks - added backfill logic Fixes # (issue) ## Type of change - [x] New feature (non-breaking change which adds functionality) ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. locally <img width="1710" height="1234" alt="CleanShot 2026-04-15 at 16 15 02@2x" src="https://github.com/user-attachments/assets/3d319fe0-19f9-4fd0-9308-74987daac2e1" /> <img width="2884" height="1136" alt="CleanShot 2026-05-11 at 19 22 53@2x" src="https://github.com/user-attachments/assets/5eae8650-985b-4c4a-af42-35f7175ff52d" /> ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Vishnu Narayanan <iamwishnu@gmail.com>
42 lines
1.5 KiB
Ruby
42 lines
1.5 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe Integrations::Openai::KeyValidator do
|
|
let(:api_key) { 'sk-test-valid-key-123456789' }
|
|
let(:probe_url) { 'https://api.openai.com/v1/models' }
|
|
|
|
it 'accepts keys that OpenAI recognizes' do
|
|
stub_request(:get, probe_url).to_return(status: 200)
|
|
expect(described_class.valid?(api_key)).to be true
|
|
end
|
|
|
|
it 'rejects keys that OpenAI does not recognize' do
|
|
stub_request(:get, probe_url).to_return(status: 401)
|
|
expect(described_class.valid?(api_key)).to be false
|
|
end
|
|
|
|
it 'rejects blank keys without making a network call' do
|
|
expect(described_class.valid?(nil)).to be false
|
|
expect(described_class.valid?('')).to be false
|
|
end
|
|
|
|
it 'treats transient failures as valid to avoid blocking saves' do
|
|
stub_request(:get, probe_url).to_return(status: 500)
|
|
expect(described_class.valid?(api_key)).to be true
|
|
|
|
stub_request(:get, probe_url).to_timeout
|
|
expect(described_class.valid?(api_key)).to be true
|
|
end
|
|
|
|
it 'routes the probe through the configured endpoint' do
|
|
custom_url = 'https://proxy.example.com/v1/models'
|
|
allow(InstallationConfig).to receive(:find_by).with(name: 'CAPTAIN_OPEN_AI_ENDPOINT')
|
|
.and_return(instance_double(InstallationConfig, value: 'https://proxy.example.com/'))
|
|
stub_request(:get, custom_url).to_return(status: 200)
|
|
|
|
described_class.valid?(api_key)
|
|
|
|
expect(WebMock).to have_requested(:get, custom_url)
|
|
expect(WebMock).not_to have_requested(:get, probe_url)
|
|
end
|
|
end
|