Vishnu NarayananandGitHub
f66b551c7d
## Description Reverts [#14726](https://github.com/chatwoot/chatwoot/pull/14726) (\"feat: Add sidebar unread counts for filters (CW-7262)\"), which shipped in 4.15.0. After 4.15.0 rolled out to prod the unread-counts-for-filters code path caused a cascading incident: - `Counter#ensure_filters_cache!` fires on every `/unread_counts/index` and `update_last_seen` request. - On cache miss it calls `Builder#build_filters_for!`, which: - invokes `store.clear_user_filters!` -> `delete_matching` -> a Redis `SCAN_each` over a per-user pattern keyspace, and - runs 4 fresh SQL passes per user (mentions, participating, unattended, and per-folder `Conversations::FilterService` queries). - Threads blocked in the SCAN held their DB connections, the connection pool exhausted, Sidekiq jobs were discarded with `ActiveJob::DeserializationError: could not obtain a connection from the pool`, and the enqueued queue blew past 200K. Related: [CW-7262](https://linear.app/chatwoot/issue/CW-7262/unread-counts-for-filters-folders) ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality not to work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
59 lines
1.9 KiB
Ruby
59 lines
1.9 KiB
Ruby
# == Schema Information
|
|
#
|
|
# Table name: mentions
|
|
#
|
|
# id :bigint not null, primary key
|
|
# mentioned_at :datetime not null
|
|
# created_at :datetime not null
|
|
# updated_at :datetime not null
|
|
# account_id :bigint not null
|
|
# conversation_id :bigint not null
|
|
# user_id :bigint not null
|
|
#
|
|
# Indexes
|
|
#
|
|
# index_mentions_on_account_id (account_id)
|
|
# index_mentions_on_conversation_id (conversation_id)
|
|
# index_mentions_on_user_id (user_id)
|
|
# index_mentions_on_user_id_and_conversation_id (user_id,conversation_id) UNIQUE
|
|
#
|
|
class Mention < ApplicationRecord
|
|
include SortHandler
|
|
|
|
before_validation :ensure_account_id
|
|
validates :mentioned_at, presence: true
|
|
validates :account_id, presence: true
|
|
validates :conversation_id, presence: true
|
|
validates :user_id, presence: true
|
|
validates :user, uniqueness: { scope: :conversation }
|
|
|
|
belongs_to :account
|
|
belongs_to :conversation
|
|
belongs_to :user
|
|
|
|
after_commit :notify_mentioned_user
|
|
|
|
scope :latest, -> { order(mentioned_at: :desc) }
|
|
|
|
def self.last_user_message_at
|
|
# INNER query finds the last message created in the conversation group
|
|
# The outer query JOINS with the latest created message conversations
|
|
# Then select only latest incoming message from the conversations which doesn't have last message as outgoing
|
|
# Order by message created_at
|
|
Mention.joins(
|
|
"INNER JOIN (#{last_messaged_conversations.to_sql}) AS grouped_conversations
|
|
ON grouped_conversations.conversation_id = mentions.conversation_id"
|
|
).sort_on_last_user_message_at
|
|
end
|
|
|
|
private
|
|
|
|
def ensure_account_id
|
|
self.account_id = conversation&.account_id
|
|
end
|
|
|
|
def notify_mentioned_user
|
|
Rails.configuration.dispatcher.dispatch(CONVERSATION_MENTIONED, Time.zone.now, user: user, conversation: conversation)
|
|
end
|
|
end
|