Vishnu NarayananandGitHub
f66b551c7d
## Description Reverts [#14726](https://github.com/chatwoot/chatwoot/pull/14726) (\"feat: Add sidebar unread counts for filters (CW-7262)\"), which shipped in 4.15.0. After 4.15.0 rolled out to prod the unread-counts-for-filters code path caused a cascading incident: - `Counter#ensure_filters_cache!` fires on every `/unread_counts/index` and `update_last_seen` request. - On cache miss it calls `Builder#build_filters_for!`, which: - invokes `store.clear_user_filters!` -> `delete_matching` -> a Redis `SCAN_each` over a per-user pattern keyspace, and - runs 4 fresh SQL passes per user (mentions, participating, unattended, and per-folder `Conversations::FilterService` queries). - Threads blocked in the SCAN held their DB connections, the connection pool exhausted, Sidekiq jobs were discarded with `ActiveJob::DeserializationError: could not obtain a connection from the pool`, and the enqueued queue blew past 200K. Related: [CW-7262](https://linear.app/chatwoot/issue/CW-7262/unread-counts-for-filters-folders) ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality not to work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
77 lines
1.8 KiB
JavaScript
77 lines
1.8 KiB
JavaScript
import { mount } from '@vue/test-utils';
|
|
import { h } from 'vue';
|
|
import SidebarGroupLeaf from '../SidebarGroupLeaf.vue';
|
|
|
|
vi.mock('../provider', () => ({
|
|
useSidebarContext: () => ({
|
|
resolvePermissions: () => [],
|
|
resolveFeatureFlag: () => '',
|
|
}),
|
|
}));
|
|
|
|
const PolicyStub = {
|
|
props: ['as', 'permissions', 'featureFlag'],
|
|
template: '<li><slot /></li>',
|
|
};
|
|
|
|
const RouterLinkStub = {
|
|
props: ['to'],
|
|
template: '<a><slot /></a>',
|
|
};
|
|
|
|
const mountLeaf = props =>
|
|
mount(SidebarGroupLeaf, {
|
|
props: {
|
|
label: 'Support',
|
|
to: '/support',
|
|
...props,
|
|
},
|
|
global: {
|
|
stubs: {
|
|
Icon: true,
|
|
Policy: PolicyStub,
|
|
RouterLink: RouterLinkStub,
|
|
},
|
|
},
|
|
});
|
|
|
|
describe('SidebarGroupLeaf', () => {
|
|
it('renders unread badge when count is present', () => {
|
|
const wrapper = mountLeaf({ badgeCount: 7 });
|
|
const badge = wrapper.find('[data-test-id="sidebar-unread-badge"]');
|
|
|
|
expect(badge.exists()).toBe(true);
|
|
expect(badge.text()).toBe('7');
|
|
});
|
|
|
|
it('does not render unread badge when count is zero', () => {
|
|
const wrapper = mountLeaf({ badgeCount: 0 });
|
|
|
|
expect(wrapper.find('[data-test-id="sidebar-unread-badge"]').exists()).toBe(
|
|
false
|
|
);
|
|
});
|
|
|
|
it('caps large unread counts', () => {
|
|
const wrapper = mountLeaf({ badgeCount: 120 });
|
|
|
|
expect(wrapper.find('[data-test-id="sidebar-unread-badge"]').text()).toBe(
|
|
'99+'
|
|
);
|
|
});
|
|
|
|
it('passes unread count to custom leaf components', () => {
|
|
const wrapper = mountLeaf({
|
|
badgeCount: 4,
|
|
component: leafProps =>
|
|
h(
|
|
'span',
|
|
{ 'data-test-id': 'custom-leaf-count' },
|
|
leafProps.badgeCount
|
|
),
|
|
});
|
|
|
|
expect(wrapper.find('[data-test-id="custom-leaf-count"]').text()).toBe('4');
|
|
});
|
|
});
|