1124c1b4c2
Twilio voice now uses first-class `Call` records as the source of truth for call state, instead of storing it on `conversation.additional_attributes` and `conversation.identifier`. Each call gets its own record, its own `voice_call` bubble matched by `call_sid`, and its own conference name keyed off `Call.id`. Multiple calls on the same conversation (for `lock_to_single_conversation` inboxes) now work correctly, and the conversation card stays in sync with the real latest message. Fixes https://linear.app/chatwoot/issue/PLA-121/lock-to-single-thread --------- Co-authored-by: Muhsin <12408980+muhsin-k@users.noreply.github.com>
84 lines
2.7 KiB
Ruby
84 lines
2.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
RSpec.describe Voice::OutboundCallBuilder do
|
|
let(:account) { create(:account) }
|
|
let(:channel) { create(:channel_twilio_sms, :with_voice, account: account, phone_number: '+15551230000') }
|
|
let(:inbox) { channel.inbox }
|
|
let(:user) { create(:user, account: account) }
|
|
let(:contact) { create(:contact, account: account, phone_number: '+15550001111') }
|
|
let(:call_sid) { 'CA1234567890abcdef' }
|
|
|
|
before do
|
|
allow(Twilio::VoiceWebhookSetupService).to receive(:new)
|
|
.and_return(instance_double(Twilio::VoiceWebhookSetupService, perform: "AP#{SecureRandom.hex(8)}"))
|
|
allow(inbox).to receive(:channel).and_return(channel)
|
|
allow(channel).to receive(:initiate_call).and_return({ call_sid: call_sid })
|
|
end
|
|
|
|
describe '.perform!' do
|
|
it 'creates a conversation, Call, and voice_call message' do
|
|
call = nil
|
|
expect do
|
|
call = described_class.perform!(
|
|
account: account,
|
|
inbox: inbox,
|
|
user: user,
|
|
contact: contact
|
|
)
|
|
end.to change(account.conversations, :count).by(1).and change(Call, :count).by(1)
|
|
|
|
aggregate_failures do
|
|
expect(call).to be_a(Call)
|
|
expect(call.provider_call_id).to eq(call_sid)
|
|
expect(call.direction).to eq('outgoing')
|
|
expect(call.status).to eq('ringing')
|
|
expect(call.accepted_by_agent_id).to eq(user.id)
|
|
expect(call.conference_sid).to eq("conf_account_#{account.id}_call_#{call.id}")
|
|
|
|
voice_message = call.conversation.messages.voice_calls.last
|
|
expect(call.message_id).to eq(voice_message.id)
|
|
expect(voice_message.message_type).to eq('outgoing')
|
|
expect(voice_message.call).to eq(call)
|
|
end
|
|
end
|
|
|
|
it 'does not set conversation.identifier or write call state to additional_attributes' do
|
|
call = described_class.perform!(
|
|
account: account,
|
|
inbox: inbox,
|
|
user: user,
|
|
contact: contact
|
|
)
|
|
|
|
expect(call.conversation.identifier).to be_nil
|
|
expect(call.conversation.additional_attributes).not_to include('call_status', 'call_direction', 'agent_id', 'conference_sid')
|
|
end
|
|
|
|
it 'raises an error when contact is missing a phone number' do
|
|
contact.update!(phone_number: nil)
|
|
|
|
expect do
|
|
described_class.perform!(
|
|
account: account,
|
|
inbox: inbox,
|
|
user: user,
|
|
contact: contact
|
|
)
|
|
end.to raise_error(ArgumentError, 'Contact phone number required')
|
|
end
|
|
|
|
it 'raises an error when user is nil' do
|
|
expect do
|
|
described_class.perform!(
|
|
account: account,
|
|
inbox: inbox,
|
|
user: nil,
|
|
contact: contact
|
|
)
|
|
end.to raise_error(ArgumentError, 'Agent required')
|
|
end
|
|
end
|
|
end
|