Vishnu NarayananandGitHub
f66b551c7d
## Description Reverts [#14726](https://github.com/chatwoot/chatwoot/pull/14726) (\"feat: Add sidebar unread counts for filters (CW-7262)\"), which shipped in 4.15.0. After 4.15.0 rolled out to prod the unread-counts-for-filters code path caused a cascading incident: - `Counter#ensure_filters_cache!` fires on every `/unread_counts/index` and `update_last_seen` request. - On cache miss it calls `Builder#build_filters_for!`, which: - invokes `store.clear_user_filters!` -> `delete_matching` -> a Redis `SCAN_each` over a per-user pattern keyspace, and - runs 4 fresh SQL passes per user (mentions, participating, unattended, and per-folder `Conversations::FilterService` queries). - Threads blocked in the SCAN held their DB connections, the connection pool exhausted, Sidekiq jobs were discarded with `ActiveJob::DeserializationError: could not obtain a connection from the pool`, and the enqueued queue blew past 200K. Related: [CW-7262](https://linear.app/chatwoot/issue/CW-7262/unread-counts-for-filters-folders) ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality not to work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
54 lines
1.9 KiB
Ruby
54 lines
1.9 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
RSpec.describe AccountUser, type: :model do
|
|
describe 'associations' do
|
|
# option and dependant nullify
|
|
it { is_expected.to belong_to(:custom_role).optional }
|
|
end
|
|
|
|
describe 'permissions' do
|
|
context 'when custom role is assigned' do
|
|
it 'returns permissions of the custom role along with `custom_role` permission' do
|
|
account = create(:account)
|
|
custom_role = create(:custom_role, account: account)
|
|
account_user = create(:account_user, account: account, custom_role: custom_role)
|
|
|
|
expect(account_user.permissions).to eq(custom_role.permissions + ['custom_role'])
|
|
end
|
|
end
|
|
|
|
context 'when custom role is not assigned' do
|
|
it 'returns permissions of the default role' do
|
|
account = create(:account)
|
|
account_user = create(:account_user, account: account)
|
|
|
|
expect(account_user.permissions).to eq([account_user.role])
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'audit log' do
|
|
context 'when account user is created' do
|
|
it 'has associated audit log created' do
|
|
account_user = create(:account_user)
|
|
account_user_audit_log = Audited::Audit.where(auditable_type: 'AccountUser', action: 'create').first
|
|
expect(account_user_audit_log).to be_present
|
|
expect(account_user_audit_log.associated).to eq(account_user.account)
|
|
end
|
|
end
|
|
|
|
context 'when account user is updated' do
|
|
it 'has associated audit log created' do
|
|
account_user = create(:account_user)
|
|
account_user.update!(availability: 'offline')
|
|
account_user_audit_log = Audited::Audit.where(auditable_type: 'AccountUser', action: 'update').first
|
|
expect(account_user_audit_log).to be_present
|
|
expect(account_user_audit_log.associated).to eq(account_user.account)
|
|
expect(account_user_audit_log.audited_changes).to eq('availability' => [0, 1])
|
|
end
|
|
end
|
|
end
|
|
end
|