Twilio voice now uses first-class `Call` records as the source of truth for call state, instead of storing it on `conversation.additional_attributes` and `conversation.identifier`. Each call gets its own record, its own `voice_call` bubble matched by `call_sid`, and its own conference name keyed off `Call.id`. Multiple calls on the same conversation (for `lock_to_single_conversation` inboxes) now work correctly, and the conversation card stays in sync with the real latest message. Fixes https://linear.app/chatwoot/issue/PLA-121/lock-to-single-thread --------- Co-authored-by: Muhsin <12408980+muhsin-k@users.noreply.github.com>
151 lines
4.8 KiB
Ruby
151 lines
4.8 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
RSpec.describe 'Twilio::VoiceController', type: :request do
|
|
let(:account) { create(:account) }
|
|
let(:channel) { create(:channel_twilio_sms, :with_voice, account: account, phone_number: '+15551230003') }
|
|
let(:inbox) { channel.inbox }
|
|
let(:digits) { channel.phone_number.delete_prefix('+') }
|
|
|
|
before do
|
|
allow(Twilio::VoiceWebhookSetupService).to receive(:new)
|
|
.and_return(instance_double(Twilio::VoiceWebhookSetupService, perform: "AP#{SecureRandom.hex(16)}"))
|
|
end
|
|
|
|
describe 'POST /twilio/voice/call/:phone' do
|
|
let(:call_sid) { 'CA_test_call_sid_123' }
|
|
let(:from_number) { '+15550003333' }
|
|
let(:to_number) { channel.phone_number }
|
|
|
|
it 'invokes Voice::InboundCallBuilder for inbound calls and renders conference TwiML' do
|
|
conversation = create(:conversation, account: account, inbox: inbox)
|
|
contact = conversation.contact
|
|
call = create(
|
|
:call,
|
|
account: account,
|
|
inbox: inbox,
|
|
conversation: conversation,
|
|
contact: contact,
|
|
provider_call_id: call_sid
|
|
)
|
|
call.update!(conference_sid: call.default_conference_sid)
|
|
|
|
expect(Voice::InboundCallBuilder).to receive(:perform!).with(
|
|
account: account,
|
|
inbox: inbox,
|
|
from_number: from_number,
|
|
call_sid: call_sid
|
|
).and_return(call)
|
|
|
|
post "/twilio/voice/call/#{digits}", params: {
|
|
'CallSid' => call_sid,
|
|
'From' => from_number,
|
|
'To' => to_number,
|
|
'Direction' => 'inbound'
|
|
}
|
|
|
|
expect(response).to have_http_status(:ok)
|
|
expect(response.body).to include('<Response>')
|
|
expect(response.body).to include('<Dial>')
|
|
expect(response.body).to include(call.conference_sid)
|
|
end
|
|
|
|
it 'looks up the Call when Twilio sends the outbound-api PSTN leg' do
|
|
conversation = create(:conversation, account: account, inbox: inbox)
|
|
call = create(
|
|
:call,
|
|
account: account,
|
|
inbox: inbox,
|
|
conversation: conversation,
|
|
contact: conversation.contact,
|
|
direction: :outgoing,
|
|
provider_call_id: call_sid
|
|
)
|
|
call.update!(conference_sid: call.default_conference_sid)
|
|
|
|
post "/twilio/voice/call/#{digits}", params: {
|
|
'CallSid' => call_sid,
|
|
'From' => to_number,
|
|
'To' => from_number,
|
|
'Direction' => 'outbound-api'
|
|
}
|
|
|
|
expect(response).to have_http_status(:ok)
|
|
expect(response.body).to include(call.conference_sid)
|
|
expect(call.reload.parent_call_sid).to be_nil
|
|
end
|
|
|
|
it 'records the parent call SID when syncing outbound-dial legs' do
|
|
parent_sid = 'CA_parent'
|
|
child_sid = 'CA_child'
|
|
conversation = create(:conversation, account: account, inbox: inbox)
|
|
call = create(
|
|
:call,
|
|
account: account,
|
|
inbox: inbox,
|
|
conversation: conversation,
|
|
contact: conversation.contact,
|
|
direction: :outgoing,
|
|
provider_call_id: parent_sid
|
|
)
|
|
call.update!(conference_sid: call.default_conference_sid)
|
|
|
|
post "/twilio/voice/call/#{digits}", params: {
|
|
'CallSid' => child_sid,
|
|
'ParentCallSid' => parent_sid,
|
|
'From' => to_number,
|
|
'To' => from_number,
|
|
'Direction' => 'outbound-dial'
|
|
}
|
|
|
|
expect(response).to have_http_status(:ok)
|
|
expect(call.reload.parent_call_sid).to eq(parent_sid)
|
|
end
|
|
|
|
it 'raises not found when inbox is not present' do
|
|
expect(Voice::InboundCallBuilder).not_to receive(:perform!)
|
|
post '/twilio/voice/call/19998887777', params: {
|
|
'CallSid' => call_sid,
|
|
'From' => from_number,
|
|
'To' => to_number,
|
|
'Direction' => 'inbound'
|
|
}
|
|
expect(response).to have_http_status(:not_found)
|
|
end
|
|
end
|
|
|
|
describe 'POST /twilio/voice/status/:phone' do
|
|
let(:call_sid) { 'CA_status_sid_456' }
|
|
|
|
it 'invokes Voice::StatusUpdateService with expected params' do
|
|
service_double = instance_double(Voice::StatusUpdateService, perform: nil)
|
|
expect(Voice::StatusUpdateService).to receive(:new).with(
|
|
hash_including(
|
|
account: account,
|
|
call_sid: call_sid,
|
|
call_status: 'completed',
|
|
payload: hash_including('CallSid' => call_sid, 'CallStatus' => 'completed')
|
|
)
|
|
).and_return(service_double)
|
|
expect(service_double).to receive(:perform)
|
|
|
|
post "/twilio/voice/status/#{digits}", params: {
|
|
'CallSid' => call_sid,
|
|
'CallStatus' => 'completed'
|
|
}
|
|
|
|
expect(response).to have_http_status(:no_content)
|
|
end
|
|
|
|
it 'raises not found when inbox is not present' do
|
|
expect(Voice::StatusUpdateService).not_to receive(:new)
|
|
post '/twilio/voice/status/18005550101', params: {
|
|
'CallSid' => call_sid,
|
|
'CallStatus' => 'busy'
|
|
}
|
|
expect(response).to have_http_status(:not_found)
|
|
end
|
|
end
|
|
end
|