This PR fixes TikTok attachment send failures and adds a capability-based guard so attachments are only enabled for conversations that support media sending. - Fixed TikTok media upload request formatting so TikTok accepts image uploads reliably. - Added TikTok capability check (IMAGE_SEND) during conversation creation. - Stored capability in conversation.additional_attributes.tiktok_capabilities. - Updated reply composer UI to disable/hide attachment upload for TikTok conversations where image_send is false. Fixes https://linear.app/chatwoot/issue/CW-6532/enable-attachments-based-on-the-conversation-capability and https://linear.app/chatwoot/issue/CW-6996/unable-to-send-image-attachments-to-tiktok-customer-400-parsing-error --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Muhsin <12408980+muhsin-k@users.noreply.github.com>
194 lines
6.9 KiB
Ruby
194 lines
6.9 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe Tiktok::MessageService do
|
|
let(:account) { create(:account) }
|
|
let(:channel) { create(:channel_tiktok, account: account, business_id: 'biz-123') }
|
|
let(:inbox) { channel.inbox }
|
|
let(:contact) { create(:contact, account: account) }
|
|
let(:contact_inbox) { create(:contact_inbox, inbox: inbox, contact: contact, source_id: 'tt-conv-1') }
|
|
let(:tiktok_client) { instance_double(Tiktok::Client, image_send_capable?: true) }
|
|
let(:text_content) do
|
|
{
|
|
type: 'text',
|
|
message_id: 'tt-msg-1',
|
|
timestamp: 1_700_000_000_000,
|
|
conversation_id: 'tt-conv-1',
|
|
text: { body: 'Hello from TikTok' },
|
|
from: 'Alice',
|
|
from_user: { id: 'user-1' },
|
|
to: 'Biz',
|
|
to_user: { id: 'biz-123' }
|
|
}.deep_symbolize_keys
|
|
end
|
|
|
|
before do
|
|
allow(Tiktok::Client).to receive(:new).and_return(tiktok_client)
|
|
end
|
|
|
|
describe '#perform' do
|
|
subject(:perform_text_message) do
|
|
service = described_class.new(channel: channel, content: current_content)
|
|
allow(service).to receive(:create_contact_inbox).and_return(contact_inbox)
|
|
service.perform
|
|
end
|
|
|
|
let(:current_content) { text_content }
|
|
|
|
it 'creates an incoming text message' do
|
|
expect do
|
|
service = described_class.new(channel: channel, content: text_content)
|
|
allow(service).to receive(:create_contact_inbox).and_return(contact_inbox)
|
|
service.perform
|
|
end.to change(Message, :count).by(1)
|
|
|
|
message = Message.last
|
|
expect(message.inbox).to eq(inbox)
|
|
expect(message.message_type).to eq('incoming')
|
|
expect(message.content).to eq('Hello from TikTok')
|
|
expect(message.source_id).to eq('tt-msg-1')
|
|
expect(message.sender).to eq(contact)
|
|
expect(message.content_attributes['is_unsupported']).to be_nil
|
|
end
|
|
|
|
it 'stores TikTok conversation capabilities when creating a new conversation' do
|
|
service = described_class.new(channel: channel, content: text_content)
|
|
allow(service).to receive(:create_contact_inbox).and_return(contact_inbox)
|
|
|
|
service.perform
|
|
|
|
message = Message.last
|
|
expect(message.conversation.additional_attributes.dig('tiktok_capabilities', 'image_send')).to be(true)
|
|
expect(message.conversation.additional_attributes.dig('tiktok_capabilities', 'updated_at')).to be_present
|
|
expect(tiktok_client).to have_received(:image_send_capable?).with('tt-conv-1')
|
|
end
|
|
|
|
it 'creates an incoming unsupported message for non-supported types' do
|
|
content = {
|
|
type: 'sticker',
|
|
message_id: 'tt-msg-2',
|
|
timestamp: 1_700_000_000_000,
|
|
conversation_id: 'tt-conv-1',
|
|
from: 'Alice',
|
|
from_user: { id: 'user-1' },
|
|
to: 'Biz',
|
|
to_user: { id: 'biz-123' }
|
|
}.deep_symbolize_keys
|
|
|
|
service = described_class.new(channel: channel, content: content)
|
|
allow(service).to receive(:create_contact_inbox).and_return(contact_inbox)
|
|
service.perform
|
|
|
|
message = Message.last
|
|
expect(message.content).to be_nil
|
|
expect(message.content_attributes['is_unsupported']).to be true
|
|
end
|
|
|
|
it 'creates an incoming embed attachment for share_post messages' do
|
|
content = {
|
|
type: 'share_post',
|
|
message_id: 'tt-msg-3',
|
|
timestamp: 1_700_000_000_000,
|
|
conversation_id: 'tt-conv-1',
|
|
share_post: { embed_url: 'https://www.tiktok.com/embed/123' },
|
|
from: 'Alice',
|
|
from_user: { id: 'user-1' },
|
|
to: 'Biz',
|
|
to_user: { id: 'biz-123' }
|
|
}.deep_symbolize_keys
|
|
|
|
service = described_class.new(channel: channel, content: content)
|
|
allow(service).to receive(:create_contact_inbox).and_return(contact_inbox)
|
|
service.perform
|
|
|
|
message = Message.last
|
|
expect(message.attachments.count).to eq(1)
|
|
attachment = message.attachments.last
|
|
expect(attachment.file_type).to eq('embed')
|
|
expect(attachment.external_url).to eq('https://www.tiktok.com/embed/123')
|
|
end
|
|
|
|
it 'creates an incoming image attachment when media is present' do
|
|
content = {
|
|
type: 'image',
|
|
message_id: 'tt-msg-4',
|
|
timestamp: 1_700_000_000_000,
|
|
conversation_id: 'tt-conv-1',
|
|
image: { media_id: 'media-1' },
|
|
from: 'Alice',
|
|
from_user: { id: 'user-1' },
|
|
to: 'Biz',
|
|
to_user: { id: 'biz-123' }
|
|
}.deep_symbolize_keys
|
|
|
|
tempfile = Tempfile.new(['tiktok', '.png'])
|
|
tempfile.write('fake-image')
|
|
tempfile.rewind
|
|
tempfile.define_singleton_method(:original_filename) { 'tiktok.png' }
|
|
tempfile.define_singleton_method(:content_type) { 'image/png' }
|
|
|
|
service = described_class.new(channel: channel, content: content)
|
|
allow(service).to receive(:create_contact_inbox).and_return(contact_inbox)
|
|
allow(service).to receive(:fetch_attachment).and_return(tempfile)
|
|
|
|
service.perform
|
|
|
|
message = Message.last
|
|
expect(message.attachments.count).to eq(1)
|
|
expect(message.attachments.last.file_type).to eq('image')
|
|
expect(message.attachments.last.file).to be_attached
|
|
ensure
|
|
tempfile.close!
|
|
end
|
|
|
|
it 'creates a conversation even when capability lookup fails' do
|
|
allow(tiktok_client).to receive(:image_send_capable?).and_raise('TikTok capability API error')
|
|
|
|
content = {
|
|
type: 'text',
|
|
message_id: 'tt-msg-5',
|
|
timestamp: 1_700_000_000_000,
|
|
conversation_id: 'tt-conv-1',
|
|
text: { body: 'Hello with capability failure' },
|
|
from: 'Alice',
|
|
from_user: { id: 'user-1' },
|
|
to: 'Biz',
|
|
to_user: { id: 'biz-123' }
|
|
}.deep_symbolize_keys
|
|
|
|
service = described_class.new(channel: channel, content: content)
|
|
allow(service).to receive(:create_contact_inbox).and_return(contact_inbox)
|
|
|
|
expect { service.perform }.to change(Message, :count).by(1)
|
|
|
|
message = Message.last
|
|
expect(message.conversation.additional_attributes['tiktok_capabilities']).to be_nil
|
|
end
|
|
|
|
context 'when lock_to_single_conversation is enabled' do
|
|
it 'reuses the last resolved conversation' do
|
|
inbox.update!(lock_to_single_conversation: true)
|
|
resolved_conversation = create(:conversation, inbox: inbox, contact: contact, contact_inbox: contact_inbox, status: :resolved)
|
|
|
|
perform_text_message
|
|
|
|
expect(inbox.conversations.count).to eq(1)
|
|
expect(resolved_conversation.reload.messages.last.content).to eq('Hello from TikTok')
|
|
end
|
|
end
|
|
|
|
context 'when lock_to_single_conversation is disabled' do
|
|
let(:current_content) { text_content.merge(message_id: 'tt-msg-lock-2') }
|
|
|
|
it 'creates a new conversation if the previous one is resolved' do
|
|
inbox.update!(lock_to_single_conversation: false)
|
|
create(:conversation, inbox: inbox, contact: contact, contact_inbox: contact_inbox, status: :resolved)
|
|
|
|
perform_text_message
|
|
|
|
expect(inbox.conversations.count).to eq(2)
|
|
expect(inbox.conversations.last.messages.last.content).to eq('Hello from TikTok')
|
|
end
|
|
end
|
|
end
|
|
end
|