Vishnu NarayananandGitHub
f66b551c7d
## Description Reverts [#14726](https://github.com/chatwoot/chatwoot/pull/14726) (\"feat: Add sidebar unread counts for filters (CW-7262)\"), which shipped in 4.15.0. After 4.15.0 rolled out to prod the unread-counts-for-filters code path caused a cascading incident: - `Counter#ensure_filters_cache!` fires on every `/unread_counts/index` and `update_last_seen` request. - On cache miss it calls `Builder#build_filters_for!`, which: - invokes `store.clear_user_filters!` -> `delete_matching` -> a Redis `SCAN_each` over a per-user pattern keyspace, and - runs 4 fresh SQL passes per user (mentions, participating, unattended, and per-folder `Conversations::FilterService` queries). - Threads blocked in the SCAN held their DB connections, the connection pool exhausted, Sidekiq jobs were discarded with `ActiveJob::DeserializationError: could not obtain a connection from the pool`, and the enqueued queue blew past 200K. Related: [CW-7262](https://linear.app/chatwoot/issue/CW-7262/unread-counts-for-filters-folders) ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality not to work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
76 lines
3.7 KiB
Ruby
76 lines
3.7 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe Conversations::UnreadCounts::Counter do
|
|
let(:account) { create(:account) }
|
|
let(:agent) { create(:user, account: account, role: :agent) }
|
|
let(:other_agent) { create(:user, account: account, role: :agent) }
|
|
let(:inbox) { create(:inbox, account: account) }
|
|
let(:label) { create(:label, account: account, title: 'support', show_on_sidebar: true) }
|
|
let(:team) { create(:team, account: account, allow_auto_assign: false) }
|
|
let(:account_user) { account.account_users.find_by(user: agent) }
|
|
let(:store) { Conversations::UnreadCounts::Store }
|
|
|
|
before do
|
|
create(:inbox_member, user: agent, inbox: inbox)
|
|
create(:team_member, user: agent, team: team)
|
|
end
|
|
|
|
after do
|
|
store.clear_account!(account.id)
|
|
end
|
|
|
|
it 'uses base counts for custom roles with conversation_manage permission' do
|
|
account_user.update!(custom_role: create(:custom_role, account: account, permissions: ['conversation_manage']))
|
|
create_unread_conversation(account: account, inbox: inbox, labels: [label.title], assignee: other_agent, team: team)
|
|
create_unread_conversation(account: account, inbox: inbox, labels: [label.title], team: team)
|
|
|
|
result = described_class.new(account: account, user: agent).perform
|
|
|
|
expect(result[:all_count]).to eq(2)
|
|
expect(result[:inboxes]).to eq(inbox.id.to_s => 2)
|
|
expect(result[:labels]).to eq(label.id.to_s => 2)
|
|
expect(result[:teams]).to eq(team.id.to_s => 2)
|
|
expect(store.assignment_ready?(account.id)).to be(false)
|
|
end
|
|
|
|
it 'counts assigned and unassigned conversations for conversation_unassigned_manage permission' do
|
|
account_user.update!(custom_role: create(:custom_role, account: account, permissions: ['conversation_unassigned_manage']))
|
|
create_unread_conversation(account: account, inbox: inbox, labels: [label.title], assignee: agent, team: team)
|
|
create_unread_conversation(account: account, inbox: inbox, labels: [label.title], team: team)
|
|
create_unread_conversation(account: account, inbox: inbox, labels: [label.title], assignee: other_agent, team: team)
|
|
|
|
result = described_class.new(account: account, user: agent).perform
|
|
|
|
expect(result[:all_count]).to eq(2)
|
|
expect(result[:inboxes]).to eq(inbox.id.to_s => 2)
|
|
expect(result[:labels]).to eq(label.id.to_s => 2)
|
|
expect(result[:teams]).to eq(team.id.to_s => 2)
|
|
expect(store.assignment_ready?(account.id)).to be(true)
|
|
end
|
|
|
|
it 'counts only assigned conversations for conversation_participating_manage permission' do
|
|
account_user.update!(custom_role: create(:custom_role, account: account, permissions: ['conversation_participating_manage']))
|
|
create_unread_conversation(account: account, inbox: inbox, labels: [label.title], assignee: agent, team: team)
|
|
create_unread_conversation(account: account, inbox: inbox, labels: [label.title], team: team)
|
|
|
|
result = described_class.new(account: account, user: agent).perform
|
|
|
|
expect(result[:all_count]).to eq(1)
|
|
expect(result[:inboxes]).to eq(inbox.id.to_s => 1)
|
|
expect(result[:labels]).to eq(label.id.to_s => 1)
|
|
expect(result[:teams]).to eq(team.id.to_s => 1)
|
|
expect(store.assignment_ready?(account.id)).to be(true)
|
|
end
|
|
|
|
it 'returns zero for custom roles without conversation permissions' do
|
|
account_user.update!(custom_role: create(:custom_role, account: account, permissions: []))
|
|
create_unread_conversation(account: account, inbox: inbox, labels: [label.title], assignee: agent, team: team)
|
|
|
|
result = described_class.new(account: account, user: agent).perform
|
|
|
|
expect(result).to eq(all_count: 0, inboxes: {}, labels: {}, teams: {})
|
|
expect(store.base_ready?(account.id)).to be(false)
|
|
expect(store.assignment_ready?(account.id)).to be(false)
|
|
end
|
|
end
|