## Description Adds a per-inbox "Allow incoming calls" toggle for voice-enabled WhatsApp and Twilio inboxes. When turned off, the setting is persisted on the channel; actually rejecting inbound calls is handled in a follow-up PR. ## Type of change - [ ] New feature (non-breaking change which adds functionality) ## Screenshot <img width="804" height="384" alt="Screenshot 2026-06-04 at 11 44 07 AM" src="https://github.com/user-attachments/assets/df8bb026-0387-4031-bcba-6d9a56872eb7" /> ## Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
117 lines
4.6 KiB
Ruby
117 lines
4.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
RSpec.describe Channel::TwilioSms do
|
|
let(:account) { create(:account) }
|
|
let(:twiml_app_sid) { 'AP1234567890abcdef' }
|
|
|
|
before do
|
|
allow(Twilio::VoiceWebhookSetupService).to receive(:new).and_return(instance_double(Twilio::VoiceWebhookSetupService, perform: twiml_app_sid))
|
|
end
|
|
|
|
describe 'factory' do
|
|
it 'has a valid :with_voice factory' do
|
|
channel = create(:channel_twilio_sms, :with_voice, account: account)
|
|
expect(channel).to be_valid
|
|
expect(channel.voice_enabled?).to be true
|
|
end
|
|
end
|
|
|
|
describe 'validations' do
|
|
it 'requires a phone number when voice is enabled' do
|
|
channel = build(:channel_twilio_sms, :with_voice, account: account, phone_number: nil)
|
|
channel.valid?
|
|
expect(channel.errors[:base]).to include('Voice calling requires a phone number and cannot be used with messaging service SID')
|
|
end
|
|
end
|
|
|
|
describe '#voice_enabled?' do
|
|
it 'returns true when voice_enabled is set' do
|
|
channel = create(:channel_twilio_sms, :with_voice, account: account)
|
|
expect(channel.voice_enabled?).to be true
|
|
end
|
|
|
|
it 'returns false by default' do
|
|
channel = create(:channel_twilio_sms, account: account)
|
|
expect(channel.voice_enabled?).to be false
|
|
end
|
|
end
|
|
|
|
describe '#inbound_calls_enabled?' do
|
|
it 'returns true by default when nothing has been toggled' do
|
|
channel = create(:channel_twilio_sms, :with_voice, account: account)
|
|
expect(channel.inbound_calls_enabled?).to be true
|
|
end
|
|
|
|
it 'returns false only when explicitly disabled in provider_config' do
|
|
channel = create(:channel_twilio_sms, :with_voice, account: account,
|
|
provider_config: { 'inbound_calls_enabled' => false })
|
|
expect(channel.inbound_calls_enabled?).to be false
|
|
end
|
|
end
|
|
|
|
describe '#voice_call_webhook_url' do
|
|
it 'returns the webhook URL based on phone number' do
|
|
channel = create(:channel_twilio_sms, :with_voice)
|
|
digits = channel.phone_number.delete_prefix('+')
|
|
expect(channel.voice_call_webhook_url).to include(digits)
|
|
end
|
|
end
|
|
|
|
describe '#voice_status_webhook_url' do
|
|
it 'returns the status webhook URL based on phone number' do
|
|
channel = create(:channel_twilio_sms, :with_voice)
|
|
digits = channel.phone_number.delete_prefix('+')
|
|
expect(channel.voice_status_webhook_url).to include(digits)
|
|
end
|
|
end
|
|
|
|
describe 'provisioning on create' do
|
|
it 'stores twiml_app_sid from the webhook setup service' do
|
|
stub_request(:get, %r{api\.twilio\.com/2010-04-01/Accounts/.*/IncomingPhoneNumbers\.json})
|
|
.to_return(status: 200, body: { incoming_phone_numbers: [{ capabilities: { 'voice' => true } }] }.to_json,
|
|
headers: { 'Content-Type' => 'application/json' })
|
|
channel = create(:channel_twilio_sms, :with_voice, twiml_app_sid: nil)
|
|
expect(channel.twiml_app_sid).to eq(twiml_app_sid)
|
|
end
|
|
end
|
|
|
|
describe 'teardown on disable' do
|
|
let(:channel) { create(:channel_twilio_sms, :with_voice, account: account) }
|
|
let(:app_context) { instance_double(Twilio::REST::Api::V2010::AccountContext::ApplicationContext) }
|
|
let(:twilio_client) { instance_double(Twilio::REST::Client) }
|
|
let(:numbers_list) { instance_double(Twilio::REST::Api::V2010::AccountContext::IncomingPhoneNumberList) }
|
|
|
|
before do
|
|
allow(Twilio::REST::Client).to receive(:new).and_return(twilio_client)
|
|
allow(twilio_client).to receive(:applications).with(channel.twiml_app_sid).and_return(app_context)
|
|
allow(app_context).to receive(:delete)
|
|
allow(twilio_client).to receive(:incoming_phone_numbers).and_return(numbers_list)
|
|
allow(numbers_list).to receive(:list).with(phone_number: channel.phone_number).and_return([])
|
|
end
|
|
|
|
it 'deletes the TwiML app and clears twiml_app_sid' do
|
|
original_twiml_sid = channel.twiml_app_sid
|
|
channel.update!(voice_enabled: false)
|
|
|
|
expect(twilio_client).to have_received(:applications).with(original_twiml_sid)
|
|
expect(app_context).to have_received(:delete)
|
|
expect(channel.reload.twiml_app_sid).to be_nil
|
|
end
|
|
|
|
it 'preserves api_key_sid and api_key_secret' do
|
|
channel.update!(voice_enabled: false)
|
|
expect(channel.reload.api_key_sid).to be_present
|
|
expect(channel.reload.api_key_secret).to be_present
|
|
end
|
|
|
|
it 'does not fail if Twilio API errors' do
|
|
allow(app_context).to receive(:delete).and_raise(StandardError.new('Not found'))
|
|
|
|
expect { channel.update!(voice_enabled: false) }.not_to raise_error
|
|
expect(channel.reload.twiml_app_sid).to be_nil
|
|
end
|
|
end
|
|
end
|