Vishnu NarayananandGitHub
f66b551c7d
## Description Reverts [#14726](https://github.com/chatwoot/chatwoot/pull/14726) (\"feat: Add sidebar unread counts for filters (CW-7262)\"), which shipped in 4.15.0. After 4.15.0 rolled out to prod the unread-counts-for-filters code path caused a cascading incident: - `Counter#ensure_filters_cache!` fires on every `/unread_counts/index` and `update_last_seen` request. - On cache miss it calls `Builder#build_filters_for!`, which: - invokes `store.clear_user_filters!` -> `delete_matching` -> a Redis `SCAN_each` over a per-user pattern keyspace, and - runs 4 fresh SQL passes per user (mentions, participating, unattended, and per-folder `Conversations::FilterService` queries). - Threads blocked in the SCAN held their DB connections, the connection pool exhausted, Sidekiq jobs were discarded with `ActiveJob::DeserializationError: could not obtain a connection from the pool`, and the enqueued queue blew past 200K. Related: [CW-7262](https://linear.app/chatwoot/issue/CW-7262/unread-counts-for-filters-folders) ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality not to work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
37 lines
816 B
Ruby
37 lines
816 B
Ruby
class Conversations::UnreadCounts::BroadcastScope
|
|
attr_reader :event
|
|
|
|
def initialize(event)
|
|
@event = event
|
|
end
|
|
|
|
def perform
|
|
return [conversation.account, conversation.inbox.members] if conversation.present?
|
|
|
|
deleted_conversation_scope
|
|
end
|
|
|
|
private
|
|
|
|
def conversation
|
|
event.data[:conversation]
|
|
end
|
|
|
|
def deleted_conversation_scope
|
|
conversation_data = event.data[:conversation_data]&.with_indifferent_access
|
|
return if conversation_data.blank?
|
|
|
|
account = Account.find_by(id: conversation_data[:account_id])
|
|
return if account.blank?
|
|
|
|
[account, inbox_members_for(account, conversation_data[:inbox_id])]
|
|
end
|
|
|
|
def inbox_members_for(account, inbox_id)
|
|
inbox = account.inboxes.find_by(id: inbox_id)
|
|
return User.none if inbox.blank?
|
|
|
|
inbox.members
|
|
end
|
|
end
|