From ff1286928d0d605914718dd6d3f1c1f5b887ef68 Mon Sep 17 00:00:00 2001
From: Muhsin Keloth <muhsinkeramam@gmail.com>
Date: Fri, 26 Apr 2024 10:04:38 +0530
Subject: [PATCH] chore: refactor shouldShowImage

---
 app/javascript/v3/components/Form/ProfileAvatar.vue | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/app/javascript/v3/components/Form/ProfileAvatar.vue b/app/javascript/v3/components/Form/ProfileAvatar.vue
index af5e3c351..fe60ad0e8 100644
--- a/app/javascript/v3/components/Form/ProfileAvatar.vue
+++ b/app/javascript/v3/components/Form/ProfileAvatar.vue
@@ -7,6 +7,7 @@
     <img
       v-if="shouldShowImage"
       class="rounded-xl h-[72px] w-[72px]"
+      :alt="name"
       :src="src"
       draggable="false"
       @load="onImageLoad"
@@ -62,15 +63,7 @@ const imageLoadedError = ref(false);
 const shouldShowUploadIcon = ref(false);
 const fileInputRef = ref(null);
 
-const shouldShowImage = computed(() => {
-  if (!props.src) {
-    return false;
-  }
-  if (hasImageLoaded.value) {
-    return !imageLoadedError.value;
-  }
-  return true;
-});
+const shouldShowImage = computed(() => props.src && !imageLoadedError.value);
 
 const onImageLoadError = () => {
   imageLoadedError.value = true;