From efc3de165aae4efcf1422e2e64caa42439e56a6a Mon Sep 17 00:00:00 2001 From: Tanmay Sharma Date: Mon, 11 Aug 2025 21:19:06 +0530 Subject: [PATCH] self review --- .../api/v1/accounts/captain/documents_controller.rb | 4 ---- enterprise/app/jobs/captain/llm/update_embedding_job.rb | 3 --- 2 files changed, 7 deletions(-) diff --git a/enterprise/app/controllers/api/v1/accounts/captain/documents_controller.rb b/enterprise/app/controllers/api/v1/accounts/captain/documents_controller.rb index 36393f1a8..67ac10515 100644 --- a/enterprise/app/controllers/api/v1/accounts/captain/documents_controller.rb +++ b/enterprise/app/controllers/api/v1/accounts/captain/documents_controller.rb @@ -25,10 +25,6 @@ class Api::V1::Accounts::Captain::DocumentsController < Api::V1::Accounts::BaseC @document.save! rescue Captain::Document::LimitExceededError => e render_could_not_create_error(e.message) - rescue StandardError => e - Rails.logger.error "Document creation error: #{e.message}" - Rails.logger.error "Error backtrace: #{e.backtrace.first(5).join("\n")}" - render_could_not_create_error('Failed to create document') end def destroy diff --git a/enterprise/app/jobs/captain/llm/update_embedding_job.rb b/enterprise/app/jobs/captain/llm/update_embedding_job.rb index e88c5d4f9..20d10f8f5 100644 --- a/enterprise/app/jobs/captain/llm/update_embedding_job.rb +++ b/enterprise/app/jobs/captain/llm/update_embedding_job.rb @@ -2,9 +2,6 @@ class Captain::Llm::UpdateEmbeddingJob < ApplicationJob queue_as :low def perform(record, content) - # Early return if record was deleted before job execution - return unless record&.persisted? - embedding = Captain::Llm::EmbeddingService.new.get_embedding(content) record.update!(embedding: embedding) end