chore: cleanup code

This commit is contained in:
Muhsin Keloth
2024-05-07 14:19:34 +05:30
parent 3595903fb5
commit ee184d9792
4 changed files with 12 additions and 22 deletions
+1 -5
View File
@@ -1,5 +1,5 @@
class Integrations::Linear::ProcessorService
pattr_initialize [:account!, :conversation!]
pattr_initialize [:account!]
def teams
response = linear_client.teams
@@ -22,10 +22,6 @@ class Integrations::Linear::ProcessorService
private
def conversation_link
"#{ENV.fetch('FRONTEND_URL', nil)}/app/accounts/#{account.id}/conversations/#{conversation.display_id}"
end
def linear_hook
@linear_hook ||= account.hooks.find_by!(app_id: 'linear')
end
+9 -8
View File
@@ -31,17 +31,18 @@ class Linear
def execute_query(query)
response = @client.query(query)
unless response.data
raise StandardError, "Error retrieving data: #{response.errors.messages}" if response.errors.any?
return { error: 'No data returned' }
end
log_and_return_error("Error retrieving data: #{response.errors.messages}") if response.data.nil? && response.errors.any?
response.data.to_h
rescue Graphlient::Errors::GraphQLError => e
{ error: "GraphQL Error: #{e.message}" }
log_and_return_error("GraphQL Error: #{e.message}")
rescue Graphlient::Errors::ServerError => e
{ error: "Server Error: #{e.message}" }
log_and_return_error("Server Error: #{e.message}")
rescue StandardError => e
{ error: "Unexpected Error: #{e.message}" }
log_and_return_error("Unexpected Error: #{e.message}")
end
def log_and_return_error(message)
Rails.logger.error message
{ error: message }
end
end