From e47d7ae894a022a9d40c29758698ea774e6ab7b1 Mon Sep 17 00:00:00 2001 From: Shivam Mishra Date: Wed, 4 Feb 2026 21:01:12 +0530 Subject: [PATCH] refactor: remove METRIC_TO_HIDDEN_KEY --- .../v2/reports/conversations/metric_builder.rb | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/app/builders/v2/reports/conversations/metric_builder.rb b/app/builders/v2/reports/conversations/metric_builder.rb index 3c28298b2..a9687fe1e 100644 --- a/app/builders/v2/reports/conversations/metric_builder.rb +++ b/app/builders/v2/reports/conversations/metric_builder.rb @@ -1,10 +1,5 @@ class V2::Reports::Conversations::MetricBuilder < V2::Reports::Conversations::BaseReportBuilder - # Mapping from metric keys to canonical hidden metric names - METRIC_TO_HIDDEN_KEY = { - 'incoming_messages_count' => 'incoming_messages_count', - 'outgoing_messages_count' => 'outgoing_messages_count', - 'reply_time' => 'reply_time' - }.freeze + HIDEABLE_METRICS = %w[incoming_messages_count outgoing_messages_count reply_time].freeze def summary { @@ -38,9 +33,9 @@ class V2::Reports::Conversations::MetricBuilder < V2::Reports::Conversations::Ba end def metric_hidden?(metric) - hidden_metrics = params[:hidden_metrics] || [] - canonical_key = METRIC_TO_HIDDEN_KEY[metric] - canonical_key && hidden_metrics.include?(canonical_key) + return false unless HIDEABLE_METRICS.include?(metric) + + (params[:hidden_metrics] || []).include?(metric) end def builder_params(metric)