From e1d0b565576f512fc67478097c04ad29fb134d71 Mon Sep 17 00:00:00 2001
From: iamsivin <iamsivin@gmail.com>
Date: Fri, 26 Jul 2024 11:21:47 +0530
Subject: [PATCH] fix: apply ESLint rule vue/no-use-v-else-with-v-for

---
 .eslintrc.js                                  |  1 +
 .../ArticleSearch/SearchResults.vue           | 31 ++++++++++---------
 2 files changed, 17 insertions(+), 15 deletions(-)

diff --git a/.eslintrc.js b/.eslintrc.js
index 522fd5bab..b4b1cc7d5 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -149,6 +149,7 @@ module.exports = {
     ],
     'vue/no-unused-emit-declarations': 'error',
     'vue/no-unused-refs': 'error',
+    'vue/no-use-v-else-with-v-for': 'error',
     'vue/max-attributes-per-line': [
       'error',
       {
diff --git a/app/javascript/dashboard/routes/dashboard/helpcenter/components/ArticleSearch/SearchResults.vue b/app/javascript/dashboard/routes/dashboard/helpcenter/components/ArticleSearch/SearchResults.vue
index 1a9413a77..12d838b4e 100644
--- a/app/javascript/dashboard/routes/dashboard/helpcenter/components/ArticleSearch/SearchResults.vue
+++ b/app/javascript/dashboard/routes/dashboard/helpcenter/components/ArticleSearch/SearchResults.vue
@@ -42,28 +42,29 @@ export default {
 
 <template>
   <div
-    class="flex justify-end gap-1 py-4 bg-white dark:bg-slate-900 h-full overflow-y-auto"
+    class="flex justify-end h-full gap-1 py-4 overflow-y-auto bg-white dark:bg-slate-900"
   >
-    <div class="flex flex-col gap-1 w-full">
+    <div class="flex flex-col w-full gap-1">
       <div v-if="isLoading" class="empty-state-message">
         {{ $t('HELP_CENTER.ARTICLE_SEARCH_RESULT.SEARCH_LOADER') }}
       </div>
       <div v-else-if="showNoResults" class="empty-state-message">
         {{ $t('HELP_CENTER.ARTICLE_SEARCH_RESULT.NO_RESULT') }}
       </div>
-      <SearchResultItem
-        v-for="article in articles"
-        v-else
-        :id="article.id"
-        :key="article.id"
-        :title="article.title"
-        :body="article.content"
-        :url="article.url"
-        :category="article.category.name"
-        :locale="article.localeName"
-        @preview="handlePreview"
-        @insert="handleInsert"
-      />
+      <template v-else>
+        <SearchResultItem
+          v-for="article in articles"
+          :id="article.id"
+          :key="article.id"
+          :title="article.title"
+          :body="article.content"
+          :url="article.url"
+          :category="article.category.name"
+          :locale="article.localeName"
+          @preview="handlePreview"
+          @insert="handleInsert"
+        />
+      </template>
     </div>
   </div>
 </template>