From deeb580feed5f89cfb885a8b31b0f52e11a717c1 Mon Sep 17 00:00:00 2001 From: Fayaz Ahmed Date: Mon, 26 Aug 2024 17:55:04 +0530 Subject: [PATCH] cleanup: Remove ununsed spec file and review changes --- .../specs/useRouterHelper.spec.js | 2 +- .../mixins/specs/useRouteReplace.spec.js | 51 ------------------- 2 files changed, 1 insertion(+), 52 deletions(-) rename app/javascript/widget/{mixins => composables}/specs/useRouterHelper.spec.js (95%) delete mode 100644 app/javascript/widget/mixins/specs/useRouteReplace.spec.js diff --git a/app/javascript/widget/mixins/specs/useRouterHelper.spec.js b/app/javascript/widget/composables/specs/useRouterHelper.spec.js similarity index 95% rename from app/javascript/widget/mixins/specs/useRouterHelper.spec.js rename to app/javascript/widget/composables/specs/useRouterHelper.spec.js index 6a2247f72..d2f20d258 100644 --- a/app/javascript/widget/mixins/specs/useRouterHelper.spec.js +++ b/app/javascript/widget/composables/specs/useRouterHelper.spec.js @@ -1,5 +1,5 @@ import { describe, it, expect, vi, beforeEach } from 'vitest'; -import { useRouterHelper } from '../../composables/useRouterHelper'; +import { useRouterHelper } from '../useRouterHelper'; const mockRouter = { currentRoute: { name: 'initialRoute' }, diff --git a/app/javascript/widget/mixins/specs/useRouteReplace.spec.js b/app/javascript/widget/mixins/specs/useRouteReplace.spec.js deleted file mode 100644 index 34c7ca598..000000000 --- a/app/javascript/widget/mixins/specs/useRouteReplace.spec.js +++ /dev/null @@ -1,51 +0,0 @@ -import { describe, it, expect, vi, beforeEach } from 'vitest'; -import { useReplaceRoute } from 'widget/composables/useReplaceRoute'; - -const mockReplace = vi.fn(); -const mockRoute = { name: 'initialRoute' }; - -vi.mock('dashboard/composables/route', () => ({ - useRouter: () => ({ - replace: mockReplace, - }), - useRoute: () => mockRoute, -})); - -describe('useReplaceRoute', () => { - let replaceRoute; - - beforeEach(() => { - vi.clearAllMocks(); - mockRoute.name = 'initialRoute'; - replaceRoute = useReplaceRoute(); - }); - - it('should replace route when current route is different', async () => { - mockReplace.mockResolvedValue(undefined); - - await replaceRoute('newRoute', { id: 1 }); - - expect(mockReplace).toHaveBeenCalledWith({ - name: 'newRoute', - params: { id: 1 }, - }); - }); - - it('should not replace route when current route is the same', async () => { - mockRoute.name = 'sameRoute'; - - const result = await replaceRoute('sameRoute'); - - expect(mockReplace).not.toHaveBeenCalled(); - expect(result).toBeUndefined(); - }); - - it('should handle router replace rejection', async () => { - const error = new Error('Navigation aborted'); - mockReplace.mockRejectedValue(error); - - await expect(replaceRoute('newRoute')).rejects.toThrow( - 'Navigation aborted' - ); - }); -});