From d85ab0344470431505fbb9c365e8bde12cea1836 Mon Sep 17 00:00:00 2001 From: aakashb95 Date: Wed, 22 Jul 2026 23:29:40 +0530 Subject: [PATCH] fix(captain): retain approved FAQ suggestion sources --- .../app/services/captain/faq_suggestion_approval_service.rb | 1 - .../api/v1/accounts/captain/faq_suggestions_controller_spec.rb | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/enterprise/app/services/captain/faq_suggestion_approval_service.rb b/enterprise/app/services/captain/faq_suggestion_approval_service.rb index 10dd1e4b2..b894b27cf 100644 --- a/enterprise/app/services/captain/faq_suggestion_approval_service.rb +++ b/enterprise/app/services/captain/faq_suggestion_approval_service.rb @@ -16,7 +16,6 @@ class Captain::FaqSuggestionApprovalService answer: suggestion.answer, status: :approved ) - suggestion.observations.delete_all suggestion.approved! response end diff --git a/spec/enterprise/controllers/api/v1/accounts/captain/faq_suggestions_controller_spec.rb b/spec/enterprise/controllers/api/v1/accounts/captain/faq_suggestions_controller_spec.rb index 910a53ecc..fd404f82a 100644 --- a/spec/enterprise/controllers/api/v1/accounts/captain/faq_suggestions_controller_spec.rb +++ b/spec/enterprise/controllers/api/v1/accounts/captain/faq_suggestions_controller_spec.rb @@ -122,7 +122,7 @@ RSpec.describe 'Api::V1::Accounts::Captain::FaqSuggestions', type: :request do expect(response).to have_http_status(:success) expect(response.parsed_body['answer']).to eq('Enable it in account settings.') expect(suggestion.reload).to be_approved - expect(suggestion.observations).to be_empty + expect(suggestion.observations.pluck(:conversation_id)).to contain_exactly(conversation.id) end it 'lets an agent approve an accessible suggestion' do