From d24b51302880d0f58f9f9ae9f9ea25e59e5430b5 Mon Sep 17 00:00:00 2001
From: Sojan Jose <sojan@pepalo.com>
Date: Thu, 14 Aug 2025 14:01:28 +0200
Subject: [PATCH] chore: revert final cosmetic Performance optimization

- Disable Performance/MapHash rule
- Revert .pluck(:id) back to .map { |tool| tool[:id] }
- Reduce PR to 35 files focused on functional Rails upgrade changes
---
 .rubocop.yml                                            | 6 ++++++
 enterprise/app/models/concerns/captain_tools_helpers.rb | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/.rubocop.yml b/.rubocop.yml
index 648642e80..3d58bc94e 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -372,3 +372,9 @@ RSpec/DescribeClass:
 
 Performance/MapCompact:
   Enabled: false
+
+Performance/CollectionLiteralInLoop:
+  Enabled: false
+
+Performance/MapHash:
+  Enabled: false
diff --git a/enterprise/app/models/concerns/captain_tools_helpers.rb b/enterprise/app/models/concerns/captain_tools_helpers.rb
index 413dd54db..5a660310c 100644
--- a/enterprise/app/models/concerns/captain_tools_helpers.rb
+++ b/enterprise/app/models/concerns/captain_tools_helpers.rb
@@ -31,7 +31,7 @@ module Concerns::CaptainToolsHelpers
     #
     # @return [Array<String>] Array of available tool IDs
     def available_tool_ids
-      @available_tool_ids ||= available_agent_tools.pluck(:id)
+      @available_tool_ids ||= available_agent_tools.map { |tool| tool[:id] }
     end
 
     private