From cef0491d151f81c5c51a0db324c05a55bf3b422d Mon Sep 17 00:00:00 2001
From: iamsivin <iamsivin@gmail.com>
Date: Fri, 26 Jul 2024 11:43:30 +0530
Subject: [PATCH] fix: apply ESLint rule vue/no-useless-v-bind

---
 .eslintrc.js                                               | 7 +++++++
 app/javascript/dashboard/components/ChatList.vue           | 2 +-
 .../dashboard/components/widgets/FilterInput/Index.vue     | 4 ++--
 .../components/widgets/WootWriter/ReplyBottomPanel.vue     | 4 ++--
 app/javascript/dashboard/i18n/locale/en/conversation.json  | 3 ++-
 app/javascript/dashboard/i18n/locale/en/search.json        | 1 +
 .../modules/search/components/SearchResultSection.vue      | 5 ++++-
 .../routes/dashboard/settings/reports/BotReports.vue       | 2 +-
 8 files changed, 20 insertions(+), 8 deletions(-)

diff --git a/.eslintrc.js b/.eslintrc.js
index b4b1cc7d5..709cf10e5 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -150,6 +150,13 @@ module.exports = {
     'vue/no-unused-emit-declarations': 'error',
     'vue/no-unused-refs': 'error',
     'vue/no-use-v-else-with-v-for': 'error',
+    'vue/no-useless-v-bind': [
+      'error',
+      {
+        ignoreIncludesComment: false,
+        ignoreStringEscape: false,
+      },
+    ],
     'vue/max-attributes-per-line': [
       'error',
       {
diff --git a/app/javascript/dashboard/components/ChatList.vue b/app/javascript/dashboard/components/ChatList.vue
index 9f09f5a85..6ab310b11 100644
--- a/app/javascript/dashboard/components/ChatList.vue
+++ b/app/javascript/dashboard/components/ChatList.vue
@@ -937,7 +937,7 @@ export default {
     >
       <VirtualList
         ref="conversationVirtualList"
-        :data-key="'id'"
+        data-key="id"
         :data-sources="conversationList"
         :data-component="itemComponent"
         :extra-props="virtualListExtraProps"
diff --git a/app/javascript/dashboard/components/widgets/FilterInput/Index.vue b/app/javascript/dashboard/components/widgets/FilterInput/Index.vue
index 96c7832ad..b79b9e40c 100644
--- a/app/javascript/dashboard/components/widgets/FilterInput/Index.vue
+++ b/app/javascript/dashboard/components/widgets/FilterInput/Index.vue
@@ -202,7 +202,7 @@ export default {
               v-model="values"
               track-by="id"
               label="name"
-              :placeholder="'Select'"
+              placeholder="Select"
               :multiple="true"
               selected-label
               :select-label="$t('FORMS.MULTISELECT.ENTER_TO_SELECT')"
@@ -220,7 +220,7 @@ export default {
               v-model="values"
               track-by="id"
               label="name"
-              :placeholder="'Select'"
+              placeholder="Select"
               selected-label
               :select-label="$t('FORMS.MULTISELECT.ENTER_TO_SELECT')"
               deselect-label=""
diff --git a/app/javascript/dashboard/components/widgets/WootWriter/ReplyBottomPanel.vue b/app/javascript/dashboard/components/widgets/WootWriter/ReplyBottomPanel.vue
index 9b9086b5a..1869813a7 100644
--- a/app/javascript/dashboard/components/widgets/WootWriter/ReplyBottomPanel.vue
+++ b/app/javascript/dashboard/components/widgets/WootWriter/ReplyBottomPanel.vue
@@ -318,12 +318,12 @@ export default {
       />
       <woot-button
         v-if="hasWhatsappTemplates"
-        v-tooltip.top-end="'Whatsapp Templates'"
+        v-tooltip.top-end="$t('CONVERSATION.FOOTER.WHATSAPP_TEMPLATES')"
         icon="whatsapp"
         color-scheme="secondary"
         variant="smooth"
         size="small"
-        :title="'Whatsapp Templates'"
+        :title="$t('CONVERSATION.FOOTER.WHATSAPP_TEMPLATES')"
         @click="$emit('selectWhatsappTemplate')"
       />
       <VideoCallButton
diff --git a/app/javascript/dashboard/i18n/locale/en/conversation.json b/app/javascript/dashboard/i18n/locale/en/conversation.json
index 742a3657e..4cc4b9bed 100644
--- a/app/javascript/dashboard/i18n/locale/en/conversation.json
+++ b/app/javascript/dashboard/i18n/locale/en/conversation.json
@@ -142,7 +142,8 @@
       "MSG_INPUT": "Shift + enter for new line. Start with '/' to select a Canned Response.",
       "PRIVATE_MSG_INPUT": "Shift + enter for new line. This will be visible only to Agents",
       "MESSAGE_SIGNATURE_NOT_CONFIGURED": "Message signature is not configured, please configure it in profile settings.",
-      "CLICK_HERE": "Click here to update"
+      "CLICK_HERE": "Click here to update",
+      "WHATSAPP_TEMPLATES": "Whatsapp Templates"
     },
     "REPLYBOX": {
       "REPLY": "Reply",
diff --git a/app/javascript/dashboard/i18n/locale/en/search.json b/app/javascript/dashboard/i18n/locale/en/search.json
index 107e64fd8..546982b36 100644
--- a/app/javascript/dashboard/i18n/locale/en/search.json
+++ b/app/javascript/dashboard/i18n/locale/en/search.json
@@ -11,6 +11,7 @@
       "CONVERSATIONS": "Conversations",
       "MESSAGES": "Messages"
     },
+    "SEARCHING_DATA": "Searching",
     "EMPTY_STATE": "No %{item} found for query '%{query}'",
     "EMPTY_STATE_FULL": "No results found for query '%{query}'",
     "PLACEHOLDER_KEYBINDING": "/ to focus",
diff --git a/app/javascript/dashboard/modules/search/components/SearchResultSection.vue b/app/javascript/dashboard/modules/search/components/SearchResultSection.vue
index 776ead2e1..8a417db90 100644
--- a/app/javascript/dashboard/modules/search/components/SearchResultSection.vue
+++ b/app/javascript/dashboard/modules/search/components/SearchResultSection.vue
@@ -35,7 +35,10 @@ export default {
     <div v-if="showTitle" class="header">
       <h3 class="text-sm text-slate-800 dark:text-slate-100">{{ title }}</h3>
     </div>
-    <woot-loading-state v-if="isFetching" :message="'Searching'" />
+    <woot-loading-state
+      v-if="isFetching"
+      :message="$t('SEARCH.SEARCHING_DATA')"
+    />
     <slot v-else />
     <div v-if="empty && !isFetching" class="empty">
       <fluent-icon icon="info" size="16px" class="icon" />
diff --git a/app/javascript/dashboard/routes/dashboard/settings/reports/BotReports.vue b/app/javascript/dashboard/routes/dashboard/settings/reports/BotReports.vue
index 96e1ad215..b4b1dcce3 100644
--- a/app/javascript/dashboard/routes/dashboard/settings/reports/BotReports.vue
+++ b/app/javascript/dashboard/routes/dashboard/settings/reports/BotReports.vue
@@ -99,9 +99,9 @@ export default {
 
     <BotMetrics :filters="requestPayload" />
     <ReportContainer
+      account-summary-key="getBotSummary"
       :group-by="groupBy"
       :report-keys="reportKeys"
-      :account-summary-key="'getBotSummary'"
     />
   </div>
 </template>