fix rubocop validations
This commit is contained in:
Tanmay Deep Sharma
@@ -130,8 +130,10 @@ class Api::V1::Accounts::AgentCapacityPoliciesController < Api::V1::Accounts::Ba
|
||||
end
|
||||
|
||||
def fetch_agent_capacity_policy
|
||||
@agent_capacity_policy = Enterprise::AgentCapacityPolicy.where(account_id: Current.account.id).includes(:users,
|
||||
inbox_capacity_limits: :inbox).find(params[:id])
|
||||
@agent_capacity_policy = Enterprise::AgentCapacityPolicy
|
||||
.where(account_id: Current.account.id)
|
||||
.includes(:users, inbox_capacity_limits: :inbox)
|
||||
.find(params[:id])
|
||||
end
|
||||
|
||||
def agent_capacity_policy_params
|
||||
|
||||
@@ -6,13 +6,13 @@ class Api::V1::Accounts::InboxAssignmentPoliciesController < Api::V1::Accounts::
|
||||
|
||||
def show
|
||||
@inbox_assignment_policy = @inbox.inbox_assignment_policy
|
||||
|
||||
|
||||
if @inbox_assignment_policy
|
||||
render json: {
|
||||
inbox_assignment_policy: serialize_inbox_assignment_policy(@inbox_assignment_policy)
|
||||
render json: {
|
||||
inbox_assignment_policy: serialize_inbox_assignment_policy(@inbox_assignment_policy)
|
||||
}
|
||||
else
|
||||
render json: {
|
||||
render json: {
|
||||
inbox_assignment_policy: nil,
|
||||
message: 'No assignment policy assigned to this inbox'
|
||||
}
|
||||
@@ -27,8 +27,8 @@ class Api::V1::Accounts::InboxAssignmentPoliciesController < Api::V1::Accounts::
|
||||
@inbox_assignment_policy = @inbox.build_inbox_assignment_policy(assignment_policy: @assignment_policy)
|
||||
|
||||
if @inbox_assignment_policy.save
|
||||
render json: {
|
||||
inbox_assignment_policy: serialize_inbox_assignment_policy(@inbox_assignment_policy)
|
||||
render json: {
|
||||
inbox_assignment_policy: serialize_inbox_assignment_policy(@inbox_assignment_policy)
|
||||
}, status: :created
|
||||
else
|
||||
render json: { errors: @inbox_assignment_policy.errors.full_messages }, status: :unprocessable_entity
|
||||
@@ -78,4 +78,4 @@ class Api::V1::Accounts::InboxAssignmentPoliciesController < Api::V1::Accounts::
|
||||
updated_at: inbox_assignment_policy.updated_at
|
||||
}
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
@@ -1,18 +1,23 @@
|
||||
# frozen_string_literal: true
|
||||
|
||||
class Api::V1::Accounts::Reports::AssignmentMetricsController < Api::V1::Accounts::BaseController
|
||||
include AssignmentMetricsHelper
|
||||
include DistributionMetrics
|
||||
|
||||
before_action :check_authorization
|
||||
before_action :validate_date_range
|
||||
|
||||
def index
|
||||
@metrics = compute_assignment_metrics
|
||||
@metrics = metrics_service.compute_assignment_metrics
|
||||
render json: { assignment_metrics: @metrics }
|
||||
end
|
||||
|
||||
def agent_history
|
||||
history_service = Reports::AgentHistoryService.new(Current.account, params)
|
||||
|
||||
if params[:agent_id].present?
|
||||
@agent = Current.account.users.find(params[:agent_id])
|
||||
@assignment_history = fetch_agent_assignment_history(@agent)
|
||||
@assignment_history = history_service.fetch_agent_assignment_history(@agent)
|
||||
|
||||
render json: {
|
||||
agent: serialize_agent(@agent),
|
||||
@@ -20,8 +25,7 @@ class Api::V1::Accounts::Reports::AssignmentMetricsController < Api::V1::Account
|
||||
meta: pagination_meta
|
||||
}
|
||||
else
|
||||
# Return all agents' history summary
|
||||
agents_summary = compute_all_agents_history
|
||||
agents_summary = history_service.compute_all_agents_history
|
||||
render json: { agents_history: agents_summary }
|
||||
end
|
||||
end
|
||||
@@ -29,7 +33,7 @@ class Api::V1::Accounts::Reports::AssignmentMetricsController < Api::V1::Account
|
||||
def policy_performance
|
||||
@policies = Current.account.assignment_policies.includes(:inboxes)
|
||||
performance_data = @policies.map do |policy|
|
||||
compute_policy_performance(policy)
|
||||
metrics_service.compute_policy_performance(policy)
|
||||
end
|
||||
|
||||
render json: { policy_performance: performance_data }
|
||||
@@ -38,7 +42,7 @@ class Api::V1::Accounts::Reports::AssignmentMetricsController < Api::V1::Account
|
||||
def agent_utilization
|
||||
agents = Current.account.users.joins(:account_users).where(account_users: { role: %w[agent administrator] })
|
||||
utilization_data = agents.map do |agent|
|
||||
compute_agent_utilization(agent)
|
||||
metrics_service.compute_agent_utilization(agent)
|
||||
end
|
||||
|
||||
render json: { agent_utilization: utilization_data }
|
||||
@@ -46,9 +50,9 @@ class Api::V1::Accounts::Reports::AssignmentMetricsController < Api::V1::Account
|
||||
|
||||
def assignment_distribution
|
||||
distribution_data = {
|
||||
by_inbox: compute_distribution_by_inbox,
|
||||
by_team: compute_distribution_by_team,
|
||||
by_hour: compute_distribution_by_hour,
|
||||
by_inbox: metrics_service.compute_distribution_by_inbox,
|
||||
by_team: metrics_service.compute_distribution_by_team,
|
||||
by_hour: metrics_service.compute_distribution_by_hour,
|
||||
by_day_of_week: compute_distribution_by_day_of_week
|
||||
}
|
||||
|
||||
@@ -57,11 +61,12 @@ class Api::V1::Accounts::Reports::AssignmentMetricsController < Api::V1::Account
|
||||
|
||||
def export
|
||||
type = params[:type] || 'csv'
|
||||
data = compute_assignment_metrics
|
||||
data = metrics_service.compute_assignment_metrics
|
||||
|
||||
case type
|
||||
when 'csv'
|
||||
send_data generate_csv(data), filename: "assignment_metrics_#{Date.current}.csv", type: 'text/csv'
|
||||
export_service = Reports::AssignmentExportService.new(data)
|
||||
send_data export_service.generate_csv, filename: "assignment_metrics_#{Date.current}.csv", type: 'text/csv'
|
||||
when 'json'
|
||||
send_data data.to_json, filename: "assignment_metrics_#{Date.current}.json", type: 'application/json'
|
||||
else
|
||||
@@ -71,310 +76,26 @@ class Api::V1::Accounts::Reports::AssignmentMetricsController < Api::V1::Account
|
||||
|
||||
private
|
||||
|
||||
def compute_assignment_metrics
|
||||
{
|
||||
summary: compute_summary_metrics,
|
||||
by_period: compute_period_metrics,
|
||||
by_inbox: compute_inbox_metrics,
|
||||
by_agent: compute_agent_metrics,
|
||||
by_policy: compute_policy_metrics
|
||||
}
|
||||
end
|
||||
|
||||
def compute_summary_metrics
|
||||
conversations = filter_conversations_by_date_range
|
||||
|
||||
{
|
||||
total_assignments: conversations.count,
|
||||
average_assignment_time: calculate_average_assignment_time(conversations),
|
||||
assignments_per_agent: calculate_assignments_per_agent(conversations),
|
||||
unassigned_conversations: Current.account.conversations.open.unassigned.count,
|
||||
policies_active: Current.account.assignment_policies.enabled.count
|
||||
}
|
||||
end
|
||||
|
||||
def compute_period_metrics
|
||||
group_by = params[:group_by] || 'day'
|
||||
conversations = filter_conversations_by_date_range
|
||||
|
||||
case group_by
|
||||
when 'hour'
|
||||
group_by_hour(conversations)
|
||||
when 'day'
|
||||
group_by_day(conversations)
|
||||
when 'week'
|
||||
group_by_week(conversations)
|
||||
when 'month'
|
||||
group_by_month(conversations)
|
||||
else
|
||||
group_by_day(conversations)
|
||||
end
|
||||
end
|
||||
|
||||
def compute_inbox_metrics
|
||||
inbox_id = params[:inbox_id]
|
||||
base_query = filter_conversations_by_date_range
|
||||
|
||||
base_query = base_query.where(inbox_id: inbox_id) if inbox_id.present?
|
||||
|
||||
base_query.joins(:inbox)
|
||||
.group('inboxes.id', 'inboxes.name')
|
||||
.count
|
||||
.map { |k, v| { inbox_id: k[0], inbox_name: k[1], assignment_count: v } }
|
||||
end
|
||||
|
||||
def compute_agent_metrics
|
||||
agent_id = params[:agent_id]
|
||||
base_query = filter_conversations_by_date_range.where.not(assignee_id: nil)
|
||||
|
||||
base_query = base_query.where(assignee_id: agent_id) if agent_id.present?
|
||||
|
||||
base_query.joins(:assignee)
|
||||
.group('users.id', 'users.name', 'users.email')
|
||||
.count
|
||||
.map { |k, v| { agent_id: k[0], agent_name: k[1], agent_email: k[2], assignment_count: v } }
|
||||
.sort_by { |a| -a[:assignment_count] }
|
||||
end
|
||||
|
||||
def compute_policy_metrics
|
||||
# Get metrics grouped by assignment policy
|
||||
policy_metrics = {}
|
||||
|
||||
Current.account.assignment_policies.includes(:inboxes).each do |policy|
|
||||
inbox_ids = policy.inboxes.pluck(:id)
|
||||
next if inbox_ids.empty?
|
||||
|
||||
conversations = filter_conversations_by_date_range.where(inbox_id: inbox_ids)
|
||||
|
||||
policy_metrics[policy.id] = {
|
||||
policy_id: policy.id,
|
||||
policy_name: policy.name,
|
||||
assignment_order: policy.assignment_order,
|
||||
total_assignments: conversations.count,
|
||||
average_assignment_time: calculate_average_assignment_time(conversations),
|
||||
inbox_count: inbox_ids.count
|
||||
}
|
||||
end
|
||||
|
||||
policy_metrics.values
|
||||
end
|
||||
|
||||
def fetch_agent_assignment_history(agent)
|
||||
conversations = agent.assigned_conversations
|
||||
.includes(:inbox, :contact)
|
||||
.where(created_at: date_range)
|
||||
.order(created_at: :desc)
|
||||
.page(params[:page])
|
||||
.per(params[:per_page] || 50)
|
||||
|
||||
conversations.map do |conversation|
|
||||
{
|
||||
conversation_id: conversation.id,
|
||||
inbox_id: conversation.inbox_id,
|
||||
inbox_name: conversation.inbox.name,
|
||||
contact_name: conversation.contact.name,
|
||||
assigned_at: conversation.assignee_last_seen_at || conversation.created_at,
|
||||
status: conversation.status,
|
||||
created_at: conversation.created_at
|
||||
}
|
||||
end
|
||||
end
|
||||
|
||||
def filter_conversations_by_date_range
|
||||
Current.account.conversations.where(created_at: date_range)
|
||||
end
|
||||
|
||||
def date_range
|
||||
start_date = params[:start_date] ? Date.parse(params[:start_date]).beginning_of_day : 30.days.ago
|
||||
end_date = params[:end_date] ? Date.parse(params[:end_date]).end_of_day : Time.current
|
||||
|
||||
start_date..end_date
|
||||
end
|
||||
|
||||
def validate_date_range
|
||||
if params[:start_date].present? && params[:end_date].present?
|
||||
start_date = Date.parse(params[:start_date])
|
||||
end_date = Date.parse(params[:end_date])
|
||||
return if params[:since].blank? || params[:until].blank?
|
||||
|
||||
if start_date > end_date
|
||||
render json: { error: 'Start date must be before end date' }, status: :bad_request
|
||||
elsif (end_date - start_date).to_i > 365
|
||||
render json: { error: 'Date range cannot exceed 365 days' }, status: :bad_request
|
||||
end
|
||||
start_date = Date.parse(params[:since])
|
||||
end_date = Date.parse(params[:until])
|
||||
|
||||
if start_date > end_date
|
||||
render json: { error: 'Start date must be before end date' }, status: :unprocessable_entity
|
||||
elsif (end_date - start_date).to_i > 365
|
||||
render json: { error: 'Date range cannot exceed 365 days' }, status: :unprocessable_entity
|
||||
end
|
||||
rescue Date::Error
|
||||
render json: { error: 'Invalid date format' }, status: :bad_request
|
||||
end
|
||||
|
||||
def calculate_average_assignment_time(conversations)
|
||||
assigned_conversations = conversations.where.not(assignee_id: nil)
|
||||
return 0 if assigned_conversations.empty?
|
||||
|
||||
total_time = assigned_conversations.sum do |conv|
|
||||
assignment_time = conv.assignee_last_seen_at || conv.updated_at
|
||||
(assignment_time - conv.created_at).to_i
|
||||
end
|
||||
|
||||
(total_time / assigned_conversations.count / 60).round(2) # Return in minutes
|
||||
end
|
||||
|
||||
def calculate_assignments_per_agent(conversations)
|
||||
assigned_count = conversations.where.not(assignee_id: nil).count
|
||||
agent_count = conversations.where.not(assignee_id: nil).distinct.count(:assignee_id)
|
||||
|
||||
return 0 if agent_count.zero?
|
||||
|
||||
(assigned_count.to_f / agent_count).round(2)
|
||||
end
|
||||
|
||||
def group_by_hour(conversations)
|
||||
conversations.group_by_hour(:created_at).count
|
||||
end
|
||||
|
||||
def group_by_day(conversations)
|
||||
conversations.group_by_day(:created_at).count
|
||||
end
|
||||
|
||||
def group_by_week(conversations)
|
||||
conversations.group_by_week(:created_at).count
|
||||
end
|
||||
|
||||
def group_by_month(conversations)
|
||||
conversations.group_by_month(:created_at).count
|
||||
end
|
||||
|
||||
def serialize_agent(agent)
|
||||
{
|
||||
id: agent.id,
|
||||
name: agent.name,
|
||||
email: agent.email,
|
||||
avatar_url: agent.avatar_url
|
||||
}
|
||||
end
|
||||
|
||||
def pagination_meta
|
||||
{
|
||||
current_page: params[:page] || 1,
|
||||
per_page: params[:per_page] || 50
|
||||
}
|
||||
render json: { error: 'Invalid date format' }, status: :unprocessable_entity
|
||||
end
|
||||
|
||||
def check_authorization
|
||||
authorize(Conversation, :index?)
|
||||
authorize Current.account, :show_metrics?
|
||||
end
|
||||
|
||||
def compute_all_agents_history
|
||||
agents = Current.account.users.joins(:account_users).where(account_users: { role: %w[agent administrator] })
|
||||
agents.map do |agent|
|
||||
conversations = agent.assigned_conversations.where(created_at: date_range)
|
||||
{
|
||||
agent: serialize_agent(agent),
|
||||
total_assignments: conversations.count,
|
||||
average_resolution_time: calculate_average_resolution_time(conversations),
|
||||
active_conversations: conversations.open.count
|
||||
}
|
||||
end
|
||||
end
|
||||
|
||||
def compute_policy_performance(policy)
|
||||
inbox_ids = policy.inboxes.pluck(:id)
|
||||
conversations = filter_conversations_by_date_range.where(inbox_id: inbox_ids)
|
||||
|
||||
{
|
||||
policy_id: policy.id,
|
||||
policy_name: policy.name,
|
||||
assignment_order: policy.assignment_order,
|
||||
total_assignments: conversations.count,
|
||||
average_assignment_time: calculate_average_assignment_time(conversations),
|
||||
success_rate: calculate_assignment_success_rate(conversations),
|
||||
agent_count: policy.account_users.count,
|
||||
inbox_count: inbox_ids.count
|
||||
}
|
||||
end
|
||||
|
||||
def compute_agent_utilization(agent)
|
||||
capacity_policy = agent.account_users.first&.agent_capacity_policy
|
||||
assigned_conversations = agent.assigned_conversations.open.count
|
||||
|
||||
utilization = if capacity_policy
|
||||
policy_limit = capacity_policy.inbox_capacity_limits.sum(:conversation_limit)
|
||||
policy_limit > 0 ? (assigned_conversations.to_f / policy_limit * 100).round(2) : 0
|
||||
else
|
||||
0
|
||||
end
|
||||
|
||||
{
|
||||
agent: serialize_agent(agent),
|
||||
assigned_conversations: assigned_conversations,
|
||||
capacity_policy: capacity_policy&.name,
|
||||
utilization_percentage: utilization,
|
||||
available_capacity: capacity_policy ? capacity_policy.inbox_capacity_limits.sum(:conversation_limit) - assigned_conversations : nil
|
||||
}
|
||||
end
|
||||
|
||||
def compute_distribution_by_inbox
|
||||
filter_conversations_by_date_range
|
||||
.joins(:inbox)
|
||||
.group('inboxes.id', 'inboxes.name')
|
||||
.count
|
||||
.map { |k, v| { inbox_id: k[0], inbox_name: k[1], count: v } }
|
||||
end
|
||||
|
||||
def compute_distribution_by_team
|
||||
filter_conversations_by_date_range
|
||||
.joins(assignee: { team_members: :team })
|
||||
.group('teams.id', 'teams.name')
|
||||
.count
|
||||
.map { |k, v| { team_id: k[0], team_name: k[1], count: v } }
|
||||
end
|
||||
|
||||
def compute_distribution_by_hour
|
||||
filter_conversations_by_date_range
|
||||
.group_by_hour_of_day(:created_at)
|
||||
.count
|
||||
end
|
||||
|
||||
def compute_distribution_by_day_of_week
|
||||
filter_conversations_by_date_range
|
||||
.group_by_day_of_week(:created_at)
|
||||
.count
|
||||
end
|
||||
|
||||
def calculate_average_resolution_time(conversations)
|
||||
resolved = conversations.resolved
|
||||
return 0 if resolved.empty?
|
||||
|
||||
total_time = resolved.sum { |c| (c.resolved_at - c.created_at).to_i }
|
||||
(total_time / resolved.count / 3600).round(2) # Return in hours
|
||||
end
|
||||
|
||||
def calculate_assignment_success_rate(conversations)
|
||||
total = conversations.count
|
||||
return 0 if total.zero?
|
||||
|
||||
assigned = conversations.where.not(assignee_id: nil).count
|
||||
(assigned.to_f / total * 100).round(2)
|
||||
end
|
||||
|
||||
def generate_csv(data)
|
||||
require 'csv'
|
||||
|
||||
CSV.generate(headers: true) do |csv|
|
||||
# Summary metrics
|
||||
csv << ['Summary Metrics']
|
||||
csv << %w[Metric Value]
|
||||
data[:summary].each do |key, value|
|
||||
csv << [key.to_s.humanize, value]
|
||||
end
|
||||
|
||||
csv << []
|
||||
|
||||
# Agent metrics
|
||||
csv << ['Agent Metrics']
|
||||
csv << ['Agent Name', 'Email', 'Assignment Count']
|
||||
data[:by_agent].each do |agent|
|
||||
csv << [agent[:agent_name], agent[:agent_email], agent[:assignment_count]]
|
||||
end
|
||||
end
|
||||
def metrics_service
|
||||
@metrics_service ||= Reports::AssignmentMetricsService.new(Current.account, params)
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user