fix rubocop

spec/services/auto_assignment/assignment_service_spec.rb

@@ -46,7 +46,7 @@ RSpec.describe AutoAssignment::AssignmentService do
       it 'only assigns open conversations' do
         resolved_conversation = create(:conversation, inbox: inbox, assignee: nil, status: 'resolved')
 
-        assigned_count = service.perform_bulk_assignment(limit: 10)
+        service.perform_bulk_assignment(limit: 10)
 
         expect(conversation.reload.assignee).to eq(agent)
         expect(resolved_conversation.reload.assignee).to be_nil
@@ -54,7 +54,7 @@ RSpec.describe AutoAssignment::AssignmentService do
 
       it 'does not reassign already assigned conversations' do
         assigned_conversation = create(:conversation, inbox: inbox, assignee: agent)
-        unassigned_conversation = create(:conversation, inbox: inbox, assignee: nil)
+        create(:conversation, inbox: inbox, assignee: nil)
 
         assigned_count = service.perform_bulk_assignment(limit: 10)
 
@@ -95,16 +95,16 @@ RSpec.describe AutoAssignment::AssignmentService do
         end
 
         it 'assigns conversations with oldest last_activity_at first' do
-          old_conversation = create(:conversation, 
-                                   inbox: inbox, 
-                                   assignee: nil, 
-                                   created_at: 2.hours.ago,
-                                   last_activity_at: 2.hours.ago)
-          new_conversation = create(:conversation, 
-                                   inbox: inbox, 
-                                   assignee: nil,
-                                   created_at: 1.hour.ago,
-                                   last_activity_at: 1.hour.ago)
+          old_conversation = create(:conversation,
+                                    inbox: inbox,
+                                    assignee: nil,
+                                    created_at: 2.hours.ago,
+                                    last_activity_at: 2.hours.ago)
+          new_conversation = create(:conversation,
+                                    inbox: inbox,
+                                    assignee: nil,
+                                    created_at: 1.hour.ago,
+                                    last_activity_at: 1.hour.ago)
 
           service.perform_bulk_assignment(limit: 1)
 
@@ -130,23 +130,27 @@ RSpec.describe AutoAssignment::AssignmentService do
       before do
         create(:inbox_member, inbox: inbox, user: agent2)
         allow(OnlineStatusTracker).to receive(:get_available_users).and_return({
-          agent.id.to_s => 'online',
-          agent2.id.to_s => 'online'
-        })
+                                                                                 agent.id.to_s => 'online',
+                                                                                 agent2.id.to_s => 'online'
+                                                                               })
       end
 
       context 'when fair distribution is enabled' do
         before do
           allow(inbox).to receive(:auto_assignment_config).and_return({
-            'fair_distribution_limit' => 2,
-            'fair_distribution_window' => 3600
-          })
+                                                                        'fair_distribution_limit' => 2,
+                                                                        'fair_distribution_window' => 3600
+                                                                      })
         end
 
         it 'respects the assignment limit per agent' do
           # Mock agent1 at limit
-          allow_any_instance_of(AutoAssignment::RateLimiter).to receive(:within_limit?) do |limiter|
-            limiter.agent == agent ? false : true
+          instance_double(AutoAssignment::RateLimiter)
+          allow(AutoAssignment::RateLimiter).to receive(:new) do |args|
+            limiter = instance_double(AutoAssignment::RateLimiter)
+            allow(limiter).to receive(:within_limit?).and_return(args[:agent] != agent)
+            allow(limiter).to receive(:track_assignment)
+            limiter
           end
 
           unassigned_conversation = create(:conversation, inbox: inbox, assignee: nil)
@@ -176,7 +180,7 @@ RSpec.describe AutoAssignment::AssignmentService do
           end
 
           # Move forward past the window
-          Timecop.freeze(Time.current + 2.hours) do
+          Timecop.freeze(2.hours.from_now) do
             new_convo = create(:conversation, inbox: inbox, assignee: nil)
             service.perform_bulk_assignment(limit: 1)
             expect(new_convo.reload.assignee).not_to be_nil
@@ -197,7 +201,7 @@ RSpec.describe AutoAssignment::AssignmentService do
 
       context 'with round robin assignment' do
         it 'distributes conversations evenly among agents' do
-          conversations = 4.times.map { create(:conversation, inbox: inbox, assignee: nil) }
+          conversations = Array.new(4) { create(:conversation, inbox: inbox, assignee: nil) }
 
           service.perform_bulk_assignment(limit: 4)
 
@@ -210,4 +214,4 @@ RSpec.describe AutoAssignment::AssignmentService do
       end
     end
   end
-end
+end

spec/services/auto_assignment/inbox_round_robin_service_spec.rb

@@ -1,4 +1,6 @@
-RSpec.describe AutoAssignment::InboxRoundRobinService do
+require 'rails_helper'
+
+describe AutoAssignment::InboxRoundRobinService do
   subject(:inbox_round_robin_service) { described_class.new(inbox: inbox) }
 
   let!(:account) { create(:account) }

spec/services/auto_assignment/round_robin_selector_spec.rb

@@ -7,20 +7,17 @@ RSpec.describe AutoAssignment::RoundRobinSelector do
   let(:agent1) { create(:user, account: account, role: :agent, availability: :online) }
   let(:agent2) { create(:user, account: account, role: :agent, availability: :online) }
   let(:agent3) { create(:user, account: account, role: :agent, availability: :online) }
-
-  before do
-    @member1 = create(:inbox_member, inbox: inbox, user: agent1)
-    @member2 = create(:inbox_member, inbox: inbox, user: agent2)
-    @member3 = create(:inbox_member, inbox: inbox, user: agent3)
-  end
+  let(:member1) { create(:inbox_member, inbox: inbox, user: agent1) }
+  let(:member2) { create(:inbox_member, inbox: inbox, user: agent2) }
+  let(:member3) { create(:inbox_member, inbox: inbox, user: agent3) }
 
   describe '#select_agent' do
     context 'when agents are available' do
-      let(:available_agents) { [@member1, @member2, @member3] }
+      let(:available_agents) { [member1, member2, member3] }
 
       it 'returns an agent from the available list' do
         selected_agent = selector.select_agent(available_agents)
-        
+
         expect(selected_agent).not_to be_nil
         expect([agent1, agent2, agent3]).to include(selected_agent)
       end
@@ -28,11 +25,11 @@ RSpec.describe AutoAssignment::RoundRobinSelector do
       it 'uses round robin service for selection' do
         round_robin_service = instance_double(AutoAssignment::InboxRoundRobinService)
         allow(AutoAssignment::InboxRoundRobinService).to receive(:new).and_return(round_robin_service)
-        
+
         expect(round_robin_service).to receive(:available_agent).with(
           allowed_agent_ids: [agent1.id.to_s, agent2.id.to_s, agent3.id.to_s]
         ).and_return(agent1)
-        
+
         selected_agent = selector.select_agent(available_agents)
         expect(selected_agent).to eq(agent1)
       end
@@ -47,9 +44,9 @@ RSpec.describe AutoAssignment::RoundRobinSelector do
 
     context 'when one agent is available' do
       it 'returns that agent' do
-        selected_agent = selector.select_agent([@member1])
+        selected_agent = selector.select_agent([member1])
         expect(selected_agent).to eq(agent1)
       end
     end
   end
-end
+end