From a347416667af3ce03a0f880d3474cc8cbf2bc341 Mon Sep 17 00:00:00 2001 From: Tanmay Deep Sharma <32020192+tds-1@users.noreply.github.com> Date: Tue, 8 Jul 2025 15:42:07 +0700 Subject: [PATCH] do not catch exception --- .../jobs/captain/documents/pdf_extraction_job.rb | 13 +++---------- .../captain/tools/pdf_extraction_service.rb | 3 --- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/enterprise/app/jobs/captain/documents/pdf_extraction_job.rb b/enterprise/app/jobs/captain/documents/pdf_extraction_job.rb index 1b9634612..97deb4fc1 100644 --- a/enterprise/app/jobs/captain/documents/pdf_extraction_job.rb +++ b/enterprise/app/jobs/captain/documents/pdf_extraction_job.rb @@ -25,11 +25,9 @@ class Captain::Documents::PdfExtractionJob < ApplicationJob end def process_extraction_result(document, result) - if result[:success] && result[:content].present? - process_pdf_content_chunks(document, result[:content]) - else - handle_pdf_extraction_failure(document, result) - end + return unless result[:success] && result[:content].present? + + process_pdf_content_chunks(document, result[:content]) end def process_pdf_content_chunks(document, content_chunks) @@ -74,9 +72,4 @@ class Captain::Documents::PdfExtractionJob < ApplicationJob Rails.logger.error "PDF extraction failed for document #{document.id}: #{error_message}" document.update(status: 'available') end - - def handle_pdf_extraction_error(document, error) - Rails.logger.error "PDF extraction failed for document #{document.id}: #{error.message}" - document.update(status: 'available') - end end \ No newline at end of file diff --git a/enterprise/app/services/captain/tools/pdf_extraction_service.rb b/enterprise/app/services/captain/tools/pdf_extraction_service.rb index 291839274..e6ccd3e4f 100644 --- a/enterprise/app/services/captain/tools/pdf_extraction_service.rb +++ b/enterprise/app/services/captain/tools/pdf_extraction_service.rb @@ -41,9 +41,6 @@ class Captain::Tools::PdfExtractionService log_extraction_success(chunked_content) success_response(chunked_content) - rescue StandardError => e - Rails.logger.error "PDF extraction failed: #{e.message}" - failure_response([e.message]) end def log_extraction_success(chunked_content)