From 9ded1180595ee8c9edf9232d034537c30e71c7fc Mon Sep 17 00:00:00 2001 From: Shivam Mishra Date: Wed, 10 Sep 2025 12:31:38 +0530 Subject: [PATCH] style: remove let! --- .../devise_overrides/session_controller_spec.rb | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/spec/enterprise/controllers/enterprise/devise_overrides/session_controller_spec.rb b/spec/enterprise/controllers/enterprise/devise_overrides/session_controller_spec.rb index 8e04af776..08c69c840 100644 --- a/spec/enterprise/controllers/enterprise/devise_overrides/session_controller_spec.rb +++ b/spec/enterprise/controllers/enterprise/devise_overrides/session_controller_spec.rb @@ -6,8 +6,13 @@ RSpec.describe 'Enterprise Audit API', type: :request do describe 'POST /sign_in' do context 'with SAML user attempting password login' do - let!(:saml_settings) { create(:account_saml_settings, account: account) } - let!(:saml_user) { create(:user, email: 'saml@example.com', provider: 'saml', account: account) } + let(:saml_settings) { create(:account_saml_settings, account: account) } + let(:saml_user) { create(:user, email: 'saml@example.com', provider: 'saml', account: account) } + + before do + saml_settings + saml_user + end it 'prevents login and returns SAML authentication error' do params = { email: saml_user.email, password: 'Password1!' } @@ -16,7 +21,7 @@ RSpec.describe 'Enterprise Audit API', type: :request do expect(response).to have_http_status(:unauthorized) json_response = JSON.parse(response.body) - expect(json_response['success']).to eq(false) + expect(json_response['success']).to be(false) expect(json_response['errors']).to include(I18n.t('messages.login_saml_user')) end