From 9dddd1b020217fa13689393034c0d7072f199468 Mon Sep 17 00:00:00 2001 From: Shivam Mishra Date: Tue, 4 Mar 2025 15:09:21 +0530 Subject: [PATCH] refactor: move facebook redact job --- app/controllers/facebook/delete_controller.rb | 2 +- .../facebook/redact_contact_data_job.rb} | 2 +- spec/controllers/facebook/delete_controller_spec.rb | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) rename app/jobs/{webhooks/facebook_delete_job.rb => channels/facebook/redact_contact_data_job.rb} (91%) diff --git a/app/controllers/facebook/delete_controller.rb b/app/controllers/facebook/delete_controller.rb index 214885d01..c0ca16501 100644 --- a/app/controllers/facebook/delete_controller.rb +++ b/app/controllers/facebook/delete_controller.rb @@ -7,7 +7,7 @@ class Facebook::DeleteController < ApplicationController id_to_process = payload['user_id'] mark_deleting(id_to_process) - Webhooks::FacebookDeleteJob.perform_later(id_to_process) + ::Channels::Facebook::RedactContactDataJob.perform_later(id_to_process) status_url = "#{app_url_base}/facebook/confirm/#{id_to_process}" # IMPORTANT: Do not change the response format below. diff --git a/app/jobs/webhooks/facebook_delete_job.rb b/app/jobs/channels/facebook/redact_contact_data_job.rb similarity index 91% rename from app/jobs/webhooks/facebook_delete_job.rb rename to app/jobs/channels/facebook/redact_contact_data_job.rb index bcc973c1b..f0e91f633 100644 --- a/app/jobs/webhooks/facebook_delete_job.rb +++ b/app/jobs/channels/facebook/redact_contact_data_job.rb @@ -1,4 +1,4 @@ -class Webhooks::FacebookDeleteJob < ApplicationJob +class Channels::Facebook::RedactContactDataJob < ApplicationJob queue_as :low def perform(id_to_process) diff --git a/spec/controllers/facebook/delete_controller_spec.rb b/spec/controllers/facebook/delete_controller_spec.rb index ea13f9fb1..d7ce6097c 100644 --- a/spec/controllers/facebook/delete_controller_spec.rb +++ b/spec/controllers/facebook/delete_controller_spec.rb @@ -20,14 +20,14 @@ RSpec.describe Facebook::DeleteController do before do allow(Redis::Alfred).to receive(:set) - allow(Webhooks::FacebookDeleteJob).to receive(:perform_later) + allow(Channels::Facebook::RedactContactDataJob).to receive(:perform_later) end it 'processes the delete request and returns status URL' do post :create, params: { signed_request: signed_request } expect(Redis::Alfred).to have_received(:set).with(redis_key, true) - expect(Webhooks::FacebookDeleteJob).to have_received(:perform_later).with(user_id) + expect(Channels::Facebook::RedactContactDataJob).to have_received(:perform_later).with(user_id) expect(response).to have_http_status(:ok)